Re: Code Review Request, JDK-8178728 Check the AlgorithmParameters in algorithm constraints

2017-06-06 Thread Xuelei Fan
On 6/6/2017 6:03 PM, Anthony Scarpino wrote: On 06/06/2017 04:04 PM, Xuelei Fan wrote: New webrev: http://cr.openjdk.java.net/~xuelei/8178728/webrev.01/ On 6/6/2017 1:45 PM, Anthony Scarpino wrote: On 06/05/2017 02:15 PM, Xuelei Fan wrote: Hi, Please review the JDK 10 update: http://

Re: RFR JDK-8179614: Test for jarsigner on verifying jars that are signed and timestamped by other JDK releases

2017-06-06 Thread Weijun Wang
On 06/07/2017 09:14 AM, sha.ji...@oracle.com wrote: Hi Sean, On 07/06/2017 04:27, Sean Mullan wrote: Hi John, This looks like a very useful test. I have not gone through all of the code, but here are a few comments for now until I have more time: - add tests for EC keys - add tests for SH

Re: RFR JDK-8179614: Test for jarsigner on verifying jars that are signed and timestamped by other JDK releases

2017-06-06 Thread sha . jiang
Hi Sean, On 07/06/2017 04:27, Sean Mullan wrote: Hi John, This looks like a very useful test. I have not gone through all of the code, but here are a few comments for now until I have more time: - add tests for EC keys - add tests for SHA-512 variants of the signature algorithms - add tests

Re: Code Review Request, JDK-8178728 Check the AlgorithmParameters in algorithm constraints

2017-06-06 Thread Anthony Scarpino
On 06/06/2017 04:04 PM, Xuelei Fan wrote: New webrev: http://cr.openjdk.java.net/~xuelei/8178728/webrev.01/ On 6/6/2017 1:45 PM, Anthony Scarpino wrote: On 06/05/2017 02:15 PM, Xuelei Fan wrote: Hi, Please review the JDK 10 update: http://cr.openjdk.java.net/~xuelei/8178728/webrev.00/

Re: Code Review Request, JDK-8178728 Check the AlgorithmParameters in algorithm constraints

2017-06-06 Thread Xuelei Fan
New webrev: http://cr.openjdk.java.net/~xuelei/8178728/webrev.01/ On 6/6/2017 1:45 PM, Anthony Scarpino wrote: On 06/05/2017 02:15 PM, Xuelei Fan wrote: Hi, Please review the JDK 10 update: http://cr.openjdk.java.net/~xuelei/8178728/webrev.00/ This update extends the DisabledAlgorithmC

Re: Code Review Request, JDK-8178728 Check the AlgorithmParameters in algorithm constraints

2017-06-06 Thread Valerie Peng
Looks fine to me. Thanks, Valerie On 6/5/2017 2:15 PM, Xuelei Fan wrote: Hi, Please review the JDK 10 update: http://cr.openjdk.java.net/~xuelei/8178728/webrev.00/ This update extends the DisabledAlgorithmConstraints implementation by checking the AlgorithmParameters, which is ignored at

Re: Code Review Request, JDK-8178728 Check the AlgorithmParameters in algorithm constraints

2017-06-06 Thread Anthony Scarpino
On 06/05/2017 02:15 PM, Xuelei Fan wrote: Hi, Please review the JDK 10 update: http://cr.openjdk.java.net/~xuelei/8178728/webrev.00/ This update extends the DisabledAlgorithmConstraints implementation by checking the AlgorithmParameters, which is ignored at present. Thanks, Xuelei I'm fi

Re: RFR JDK-8179614: Test for jarsigner on verifying jars that are signed and timestamped by other JDK releases

2017-06-06 Thread Sean Mullan
Hi John, This looks like a very useful test. I have not gone through all of the code, but here are a few comments for now until I have more time: - add tests for EC keys - add tests for SHA-512 variants of the signature algorithms - add tests for larger key sizes (ex: 2048 for DSA/RSA) - you c

Re: RFR : 8181205:JRE fails to load/register security providers when started from UNC pathname

2017-06-06 Thread Seán Coffey
On 06/06/2017 16:28, Xuelei Fan wrote: Looks fine to me. There is no clear reason why Paths.get(uri).toFile().getParentFile() works but not File(uri).getParentFile(). Would you mind add a comment so that the code will not modified back to use File(uri) later? Thanks for review. It seems to

Re: RFR : 8181205:JRE fails to load/register security providers when started from UNC pathname

2017-06-06 Thread Xuelei Fan
Looks fine to me. There is no clear reason why Paths.get(uri).toFile().getParentFile() works but not File(uri).getParentFile(). Would you mind add a comment so that the code will not modified back to use File(uri) later? Thanks, Xuelei On 6/6/2017 1:40 AM, Seán Coffey wrote: ping. Can I ge

Re: RFR : 8181205:JRE fails to load/register security providers when started from UNC pathname

2017-06-06 Thread Seán Coffey
ping. Can I get a review for this please ? regards, Sean. On 01/06/2017 17:23, Seán Coffey wrote: The recent JDK-8163528 fix caused a regression for JDK binaries launched with a UNC pathname. We can use the Paths class to create the required File. I managed to put a test together which shoul

Re: RFR 8181461: sun/security/krb5/auto/KdcPolicy.java fails with java.lang.Exception: Does not match

2017-06-06 Thread Xuelei Fan
Please update the copyright year. Otherwise, looks fine to me. Xuelei On 6/5/2017 10:53 PM, Weijun Wang wrote: Please take a review on this change: http://cr.openjdk.java.net/~weijun/8181461/webrev.00/ This is a test bug and the fix is simply: // 1. Default policy is tryLast .