Re: (10) RFR of JDK-8184165: sun.security.provider.PolicyFile$PolicyEntry.toString() throws MissingResourceException

2017-07-11 Thread Weijun Wang
> On Jul 12, 2017, at 11:03 AM, Hamlin Li wrote: > > Hi Max, > > On 2017/7/12 10:50, Weijun Wang wrote: >> Change looks fine. >> >> Please remember to add a noreg-trivial label. > Added the label, and will push the change. >> Also, can you do some more investigation

Re: (10) RFR of JDK-8184165: sun.security.provider.PolicyFile$PolicyEntry.toString() throws MissingResourceException

2017-07-11 Thread Hamlin Li
Hi Max, On 2017/7/12 10:50, Weijun Wang wrote: Change looks fine. Please remember to add a noreg-trivial label. Added the label, and will push the change. Also, can you do some more investigation when this starts to happen? The bug says affected versions are 9 and 10 but PolicyFile.java has

Re: (10) RFR of JDK-8184165: sun.security.provider.PolicyFile$PolicyEntry.toString() throws MissingResourceException

2017-07-11 Thread Weijun Wang
Change looks fine. Please remember to add a noreg-trivial label. Also, can you do some more investigation when this starts to happen? The bug says affected versions are 9 and 10 but PolicyFile.java has been there long long ago. Was there a regression? Thanks Max > On Jul 12, 2017, at 10:28

(10) RFR of JDK-8184165: sun.security.provider.PolicyFile$PolicyEntry.toString() throws MissingResourceException

2017-07-11 Thread Hamlin Li
Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8184165 webrev: http://cr.openjdk.java.net/~mli/8184165/webrev.00/ Thank you -Hamlin

Re: RFR: 8184208: update class="striped" tables for accessibility

2017-07-11 Thread Jonathan Gibbons
On 07/11/2017 04:02 PM, Brian Burkhalter wrote: On Jul 11, 2017, at 2:39 PM, Jonathan Gibbons > wrote: Please review this auto-generated update to improve the accessibility of many of the tables in the API docs for the

Re: RFR: 8184208: update class="striped" tables for accessibility

2017-07-11 Thread Brian Burkhalter
On Jul 11, 2017, at 2:39 PM, Jonathan Gibbons wrote: > Please review this auto-generated update to improve the accessibility of many > of the tables > in the API docs for the java.base module. Looks all right to me. > All the modifiied tables have been visually

RFR: 8184208: update class="striped" tables for accessibility

2017-07-11 Thread Jonathan Gibbons
Please review this auto-generated update to improve the accessibility of many of the tables in the API docs for the java.base module. The changes are just to the HTML markup for selected tables; there is no change to the wording of any documentation. This update was generated by a utility

RE: [RFR] 8174849: Change SHA1 certpath restrictions - issue with 3rd party JCE provider

2017-07-11 Thread Langer, Christoph
Hi Sean, thanks for coming back on this. > > I'd like to ping you again upon that question. In the meanwhile I have > produced a standalone test case and could verify that changing to x509Cert > vs. the original cert for obtaining the SigAlgName would be a fix. I can share > the test with you,

RE: [RFR] 8174849: Change SHA1 certpath restrictions - issue with 3rd party JCE provider

2017-07-11 Thread Langer, Christoph
Hi, I'd like to ping you again upon that question. In the meanwhile I have produced a standalone test case and could verify that changing to x509Cert vs. the original cert for obtaining the SigAlgName would be a fix. I can share the test with you, however, you'll need the security provider