Re: RFR [10]: JDK-8182484: Remove 1024-bit default requirement from javadoc of java.security.interfaces.DSAKeyPairGenerator

2017-11-14 Thread Sean Mullan
On 11/8/17 6:47 PM, Valerie Peng wrote: Hi, Sean, I updated the webrev in place - now this change contains only javadoc update of DSAKeyPairGenerator interface. CSR has also been updated accordingly. Could you please take a look? Sure. 35 * DSAKeyPairGenerator, each provider must supply

Re: JDK-8180819 No installed provider supports this key: sun.security.pkcs.PKCS8Key

2017-11-14 Thread Adam Petcher
On 11/13/2017 2:20 PM, Florian Bruckner (3kraft) wrote: Hi, have just stumbled upon a quite strange behavior in a SSL connection with a client certificate. Looks like your private key is BER encoded. I think this is supposed to be fine, but the code is being a bit too strict and rejecting i

Re: java.net.ConnectException: Received fatal alert:unexpected_message

2017-11-14 Thread Sean Dawson
Thank you for the responses - turns out that even though I was using the latest version of AsyncHttpClient that I found in maven; there was another slightly different one that was more current - and seems to work. Old: https://mvnrepository.com/artifact/com.ning/async-http-client Newer: https://m

Re: RFR 8191137: keytool fails to format resource strings for keys for some languages after JDK-8171319

2017-11-14 Thread Sean Mullan
Fix looks good. Do you also need to add a label or subtask to the bug so that the localization team knows that they still need to fix the resource files? --Sean On 11/13/17 11:20 PM, Weijun Wang wrote: keytool contains a printf("%d-bit %s key", 1024, "RSA") call but when it's translated into

Re: RFR 8191137: keytool fails to format resource strings for keys for some languages after JDK-8171319

2017-11-14 Thread Weijun Wang
> On Nov 14, 2017, at 7:40 PM, Severin Gehwolf wrote: > > On Tue, 2017-11-14 at 18:47 +0800, Wang Weijun wrote: >>> 在 2017年11月14日,18:02,Severin Gehwolf 写道: >>> >>> This looks fine, but I wonder if a regression test would be in >>> order. >>> E.g. test/sun/security/tools/keytool/WeakAlg.java w

Re: RFR 8191137: keytool fails to format resource strings for keys for some languages after JDK-8171319

2017-11-14 Thread Severin Gehwolf
On Tue, 2017-11-14 at 18:47 +0800, Wang Weijun wrote: > > 在 2017年11月14日,18:02,Severin Gehwolf 写道: > > > > This looks fine, but I wonder if a regression test would be in > > order. > > E.g. test/sun/security/tools/keytool/WeakAlg.java with > > -Duser.language=fr or some such. > > But my change ha

Re: RFR 8191137: keytool fails to format resource strings for keys for some languages after JDK-8171319

2017-11-14 Thread Wang Weijun
> 在 2017年11月14日,18:02,Severin Gehwolf 写道: > > This looks fine, but I wonder if a regression test would be in order. > E.g. test/sun/security/tools/keytool/WeakAlg.java with > -Duser.language=fr or some such. But my change has not really fixed anything. It’s just a hint on how to correctly tra

Re: RFR 8191137: keytool fails to format resource strings for keys for some languages after JDK-8171319

2017-11-14 Thread Severin Gehwolf
Hi, On Tue, 2017-11-14 at 12:20 +0800, Weijun Wang wrote: > keytool contains a printf("%d-bit %s key", 1024, "RSA") call but when it's > translated into French the call becomes printf("Clave %s de %d bits", 1024, > "RSA") and %s does not match 1024. > > The fix adds position parameters to print