On Tue, 2017-11-14 at 18:47 +0800, Wang Weijun wrote: > > 在 2017年11月14日，18:02，Severin Gehwolf <sgehw...@redhat.com> 写道： > > > > This looks fine, but I wonder if a regression test would be in > > order. > > E.g. test/sun/security/tools/keytool/WeakAlg.java with > > -Duser.language=fr or some such. > > But my change has not really fixed anything. It’s just a hint on how > to correctly translate the strings. The test you suggested would > still fail after this change. It might be useful when the French > translation is updated.
Why can't this change update Resources_fr.java to include the correct position and then the test updated to also work in French? It's not really a localization change, but introduction of the correct position of the parameter. A follow-up bug could then move all other resources to a model similar to Resources_fr.java? Thanks, Severin
