Re: RFR 8199198: Remove unused functions in jdk.crypto.mscapi native code

It looks good! With kind regards, Ivan On 3/6/18 6:19 PM, Weijun Wang wrote: Please take a review at http://cr.openjdk.java.net/~weijun/8199198/webrev.00 I just removed the 3 unused functions. They were there from the beginning (2005) but had never existed in any Java class. Thanks

RFR 8199198: Remove unused functions in jdk.crypto.mscapi native code

Please take a review at http://cr.openjdk.java.net/~weijun/8199198/webrev.00 I just removed the 3 unused functions. They were there from the beginning (2005) but had never existed in any Java class. Thanks Max

Re: RFR 8198898: Compilation errors in jdk.crypto.mscapi with VS 2017

> On Mar 6, 2018, at 11:46 PM, Xuelei Fan wrote: > > Looks fine to me. > > On 3/6/2018 6:36 AM, Weijun Wang wrote: >> Please take a review at >> http://cr.openjdk.java.net/~weijun/8198898/webrev.00/ >> Two notes: >> 1. In fact, I am not able to build now because there

RFR 8199154: Accessibility issues in jdk.security.auth

Please take a review at http://cr.openjdk.java.net/~weijun/8199154/webrev.00/ In LdapLoginModule.java, there seems to be an erroneous DL inside DL. I removed the outer DL and its incomplete DD. There is no visual difference after the change. In Krb5LoginModule.java, there were only DDs and

RFR 8178370 : [TEST_BUG] java/security/Signature/SignatureLength.java fails

Hello! The regression test SignatureLength.java was seen to fail on some Solaris systems. This is because signature verifier from SunPKCS11-Solaris provider doesn't always throw SignatureException when the signature is of wrong length, but can simply return false to indicate it is invalid.

Re: RFR: 8199018: Test crypto provider not registering

Thanks for pointing out where the review was, I don't check the update email list as often. Reviewed in jdk8u-dev. Looks good. Brad On 3/6/2018 1:03 AM, Seán Coffey wrote: Thanks Brad - yes, this review is for JDK 11 (jdk/jdk). I've another review request open for you in order to handle

Re: RFR 8198898: Compilation errors in jdk.crypto.mscapi with VS 2017

Looks fine to me. On 3/6/2018 6:36 AM, Weijun Wang wrote: Please take a review at http://cr.openjdk.java.net/~weijun/8198898/webrev.00/ Two notes: 1. In fact, I am not able to build now because there are other codes not compiling with VS 2017 and they fail before security.cpp is

RFR 8198898: Compilation errors in jdk.crypto.mscapi with VS 2017

Please take a review at http://cr.openjdk.java.net/~weijun/8198898/webrev.00/ Two notes: 1. In fact, I am not able to build now because there are other codes not compiling with VS 2017 and they fail before security.cpp is compiled. I just installed VS 2017 locally, extracted the command

Re: RFR: 8199018: Test crypto provider not registering

Thanks Brad - yes, this review is for JDK 11 (jdk/jdk). I've another review request open for you in order to handle the jdk8u-dev edit : http://mail.openjdk.java.net/pipermail/jdk8u-dev/2018-March/007284.html regards, Sean. On 05/03/2018 23:41, Brad Wetmore wrote: Looks good. This looks