Re: RFR: JDK-8199640 Split up BUILD_LIBKRB5 into the two, unrelated compilations it consists of

Looks good. /Erik On 2018-03-14 16:18, Magnus Ihse Bursie wrote: BUILD_LIBKRB5 is currently a strange chimera between compiling w2k_lsa_auth on windows, and osxkrb5 on macos. They do not share source code, name or compilation options. This patch separates them into two separate compilations

Re: RFR: JDK-8199636 Unify naming for jaas_unix and jaas_nt

Looks good. /Erik On 2018-03-14 14:50, Magnus Ihse Bursie wrote: For some odd reason, the native library compiled for jdk.security.auth is called jaas_unix on unix and jaas_nt on windows. There's no good reason for this, and it breaks with the common practice in OpenJDK. This patch renames

RFR: JDK-8199640 Split up BUILD_LIBKRB5 into the two, unrelated compilations it consists of

BUILD_LIBKRB5 is currently a strange chimera between compiling w2k_lsa_auth on windows, and osxkrb5 on macos. They do not share source code, name or compilation options. This patch separates them into two separate compilations, one for each platform, so that they then can follow the normal JDK

RFR: JDK-8199636 Unify naming for jaas_unix and jaas_nt

For some odd reason, the native library compiled for jdk.security.auth is called jaas_unix on unix and jaas_nt on windows. There's no good reason for this, and it breaks with the common practice in OpenJDK. This patch renames both libraries to the basename "jaas" (that is, libjaas.so, libjaas.

Re: RFR: 8165996:PKCS11 using NSS throws an error regarding secmod.db when NSS uses sqlite

I'll have a look Martin, but it'll be better if we can get an NSS or PKCS11 expert to take a look. Any takers ? Can you expand some bit on the exact reason for your 8195607 changes ? Pointers to NSS changes etc. ? Regards, Sean. On 14/03/18 16:11, Martin Balao wrote: Hi Sean, Thanks! Can yo

Re: RFR: 8165996:PKCS11 using NSS throws an error regarding secmod.db when NSS uses sqlite

Hi Sean, Thanks! Can you please review the fix [0] so we have it in? As far as I know, fix makes Oracle internal tests pass. Kind regards, Martin.- -- [0] - http://mail.openjdk.java.net/pipermail/security-dev/ 2018-February/016776.html On Wed, Mar 14, 2018 at 12:05 PM, Seán Coffey wrote: > H

Re: RFR: 8165996:PKCS11 using NSS throws an error regarding secmod.db when NSS uses sqlite

Hi Martin, Thanks for the 8195607 pointer. I'll get this ported to jdk8u also. I didn't see that actual issue during testing but no harm to port it. Will submit a new webrev shortly. Regards, Sean. On 14/03/18 14:55, Martin Balao wrote: Hi Sean, Is this related to http://mail.openjdk.java

Re: RFR: 8165996:PKCS11 using NSS throws an error regarding secmod.db when NSS uses sqlite

Hi Sean, Is this related to http://mail.openjdk.java.net/pipermail/security-dev/2018-February/016776.html ? Kind regards, Martin.- On Wed, Mar 14, 2018 at 11:48 AM, Seán Coffey wrote: > Looking to backport this fix to jdk8u-dev. Contributed to JDK Project by > Martin Balao. > > https://bugs.

RFR: 8165996:PKCS11 using NSS throws an error regarding secmod.db when NSS uses sqlite

Looking to backport this fix to jdk8u-dev. Contributed to JDK Project by Martin Balao. https://bugs.openjdk.java.net/browse/JDK-8165996 webrev : http://cr.openjdk.java.net/~coffeys/webrev.8165996.8u/webrev/ The test/jdk/sun/security/pkcs11/PKCS11Test.java edits didn't seem applicable to jdk8u