Re: JDK 14 RFR of JDK-8229999 : Apply java.io.Serial annotations to security types in java.base

2019-08-29 Thread Joe Darcy
Hi Sean, On 8/29/2019 6:18 AM, Sean Mullan wrote: Looks fine to me although I didn't check if you missed anything. What kind of documentation changes can we expect by using this annotation? The documentation changes are just when reading the sources, the annotation type itself is not @Docum

Re: JDK 14 RFR of JDK-8229999 : Apply java.io.Serial annotations to security types in java.base

2019-08-29 Thread Sean Mullan
Looks fine to me although I didn't check if you missed anything. What kind of documentation changes can we expect by using this annotation? --Sean On 8/27/19 8:16 PM, Joe Darcy wrote: Hello, Recent work for JDK-8202385: "Annotation to mark serial-related fields and methods" added the java.io

Re: [14] RFR 8162628: Migrate cacerts keystore from JKS

2019-08-29 Thread Weijun Wang
Updated webrev at https://cr.openjdk.java.net/~weijun/8162628/webrev.01/. The only change is using CertificateFactory. I tried piped streams and it's even slower. --Max > On Aug 29, 2019, at 8:21 AM, Weijun Wang wrote: > > > >> On Aug 28, 2019, at 11:00 PM, Sean Mullan wrote: >> >> On 8/