Re: RFR 8234267: DelegationPermission implementation doesn't completely follow the updated specification

2019-12-02 Thread Weijun Wang
Ping again. > On Nov 16, 2019, at 10:02 PM, Weijun Wang wrote: > > Please take a review at > > http://cr.openjdk.java.net/~weijun/8234267/webrev.00/ > > Here, the returnDelims argument of the StringTokenizer is true so that we can > detect duplicated delimiters. > > If I understand correct

Re: SunPKCS11 connection lost after Decrypt doFinal (noPadding) openjdk 8_232

2019-12-02 Thread Valerie Peng
Hi Hubert, I've filed https://bugs.openjdk.java.net/browse/JDK-8235215 to keep track of this issue. I have not yet tried if this can be reproduced in house with NSS yet. Just curious, which HSM vendor did you use? It'd be helpful to include in the bug report. Thanks, Valerie On 12/2/2019 8

Re: 8216012: Infinite loop in RSA KeyPairGenerator

2019-12-02 Thread Valerie Peng
Hi Masanori Yano, I can help sponsoring this fix. However, as it's a P4, it may be targeted to 15 depending on the available cycles. Are you a contributor for OpenJDK? If not, please see http://openjdk.java.net/contribute/ for the process. Thanks, Valerie On 10/8/2019 8:10 PM, yano-masan...

SunPKCS11 connection lost after Decrypt doFinal (noPadding) openjdk 8_232

2019-12-02 Thread DEBORDEAUX Hubert
Hello, Following the update to OpenJDK 8_232, we did face a problem after a DECRYPT with no padding. We use a SunPKCS11 provider linked to a Network HSM. After a DECRYPT command (DES or AES) NOPADDING, we noticed the log : "Killing session (sun.security.pkcs11.P11Cipher.cancelOperation(P11Cipher.

Re: Aftermath of TLS 1.3 in Java 11 with wrapped IOExceptions

2019-12-02 Thread Rory O'Donnell
On 01/12/2019 13:37, Michael Osipov wrote: Hi folks, I am one of the Apache HttpComponents committers and we get these nags once in a while: - https://github.com/apache/httpcomponents-client/pull/178#discussion_r351492056 - https://issues.apache.org/jira/browse/HTTPCLIENT-2032 - https://st

8216012: Infinite loop in RSA KeyPairGenerator

2019-12-02 Thread yano-masan...@fujitsu.com
Hello. I would like to contribute for JDK-8216012. The cause of this problem is RSAKeyPairGenerator that doesn't check the public exponent even though the algorithm of rsa key generation can use only odd exponent number. To generate a KeyPair, the RSAKeyPairGenerator finds two random primes P a

RFR(S): 8220348: [ntintel] asserts about copying unalinged array

2019-12-02 Thread Doerr, Martin
Hi, I'd like to propose a fix for an old issue on 32 bit Windows (also for an 11u backport): https://bugs.openjdk.java.net/browse/JDK-8220348 Some jdk native methods use jni_SetLongArrayRegion with a stack allocated buffer. jni_SetLongArrayRegion uses Copy::conjoint_jlongs_atomic which requires

Re: Aftermath of TLS 1.3 in Java 11 with wrapped IOExceptions

2019-12-02 Thread Simone Bordet
Hi, On Mon, Dec 2, 2019 at 7:36 PM Xuelei Fan wrote: > > Hi, > > Could someone please help to verify if the attached patch (JDK 14) works > HttpComponents? I'm not sure I see the difference between a generic IOException and SSLHandshakeException. If a client is connecting to a busy proxy that s

Re: Aftermath of TLS 1.3 in Java 11 with wrapped IOExceptions

2019-12-02 Thread Michael Osipov
Am 2019-12-02 um 19:34 schrieb Xuelei Fan: Hi, Could someone please help to verify if the attached patch (JDK 14) works HttpComponents? Requested a review of the patch and will try myself. I see also other spots where IOException is wrapped inside an SSLException: * https://github.com/AdoptOp

Re: Aftermath of TLS 1.3 in Java 11 with wrapped IOExceptions

2019-12-02 Thread Xuelei Fan
Hi, Could someone please help to verify if the attached patch (JDK 14) works HttpComponents? Thanks & Regards, Xuelei On 12/1/2019 5:37 AM, Michael Osipov wrote: Hi folks, I am one of the Apache HttpComponents committers and we get these nags once in a while: - https://github.com/apache/ht

Re: RFR [14] JDK-8235183, Remove the "HACK CODE" in comment

2019-12-02 Thread Jamil Nimeh
Looks fine to me.--Jamil Original message From: Xuelei Fan Date: 12/2/19 7:36 AM (GMT-08:00) To: security-dev@openjdk.java.net Subject: RFR [14] JDK-8235183, Remove the "HACK CODE" in comment Hi,Could I get the following update reviewed?    http://cr.openjdk.java.net/~xuelei

RFR [14] JDK-8235183, Remove the "HACK CODE" in comment

2019-12-02 Thread Xuelei Fan
Hi, Could I get the following update reviewed? http://cr.openjdk.java.net/~xuelei/8235183/webrev.00/ There are some comments in the SunJSSE implementation that come with "HACK CODE". Which are not really bad code. They are just used to mark unusual scenarios in case the block get removed in

Re: RFR 8234744: KeyStore.store can write wrong type of file

2019-12-02 Thread Sean Mullan
Looks fine. --Sean On 11/28/19 4:28 AM, Weijun Wang wrote: Please review the change at https://cr.openjdk.java.net/~weijun/8234744/webrev.00 A mach5 test on tier1,tier2 is ongoing. Thanks, Max