Re: RFR[15] 8242060: Add revocation checking to jarsigner

2020-05-02 Thread Weijun Wang
In jarsigner/Main, you can just call pkixParameters.setRevocationEnabled(revocationCheck); Last time, you mentioned that "Event.clearReportListener()" cannot be called immediately after validation check because of some race conditions. Is that easily reproducible? I still find it strange. T

Re: RFR[15] 8242060: Add revocation checking to jarsigner

2020-05-02 Thread Hai-May Chao
Thanks Max! Using localhost would do it as well. Hai-May > On May 1, 2020, at 7:49 PM, Weijun Wang wrote: > >> >> * EnableRevocation.java >> >> - How long does this test take - does it hang for a little while trying to >> make a connection or timeout right away? If it takes a while, you cou

Re: RFR[15] 8242060: Add revocation checking to jarsigner

2020-05-02 Thread Hai-May Chao
Hi Sean, Thanks for your review. Reply inline. > On May 1, 2020, at 11:50 AM, Sean Mullan wrote: > > * Main.java: > > 2067 Event.setReportListener(new Event.Reporter() { > 2068 @Override > 2069 public void handle(S

Re: 8244281: test/jdk/com/sun/crypto/provider/KeyProtector/IterationCount.java fails with --illegal-access=deny

2020-05-02 Thread Xuelei Fan
Looks good to me. Thanks, Xuelei On 5/2/2020 7:30 AM, Alan Bateman wrote: I need a reviewer for a small update to test/jdk/com/sun/crypto/provider/KeyProtector/IterationCount.java. The test accesses a private field in com.sun.crypto.provider from a VM launched by the test. The launched VM n

Re: 8244281: test/jdk/com/sun/crypto/provider/KeyProtector/IterationCount.java fails with --illegal-access=deny

2020-05-02 Thread Weijun Wang
The change looks fine to me. Thanks, Max > On May 2, 2020, at 10:30 PM, Alan Bateman wrote: > > > I need a reviewer for a small update to > test/jdk/com/sun/crypto/provider/KeyProtector/IterationCount.java. The test > accesses a private field in com.sun.crypto.provider from a VM launched by

8244281: test/jdk/com/sun/crypto/provider/KeyProtector/IterationCount.java fails with --illegal-access=deny

2020-05-02 Thread Alan Bateman
I need a reviewer for a small update to test/jdk/com/sun/crypto/provider/KeyProtector/IterationCount.java. The test accesses a private field in com.sun.crypto.provider from a VM launched by the test. The launched VM needs to be run with --add-open to open the package, otherwise the test will