New webrev:
webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.02/security/open/webrev/
incremental:
http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.02/security.incr/open/webrev/
Items to be resolved:
* File follow-up to drop $ISA support in
> On May 7, 2020, at 4:08 PM, Valerie Peng wrote:
>
> It should be ok to remove the if (secret == null) block of
> test/jdk/sun/security/pkcs11/tls/TestPRF.java.
>
> I verified that the test runs fine on Linux without that block, so the
> comment is legit.
Thank you for verifying!
I’ll
Hi,
May someone please sponsor this patch?
Bug: https://bugs.openjdk.java.net/browse/JDK-8244199
Description:
The test
"test/jdk/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh" fails
intermittently on a lower release. While investigating the cause for the
failure, I felt
Ping?
On 4/23/2020 3:28 PM, Valerie Peng wrote:
Anyone has time to help review this fix? After the support for
RSASSA-PSS keys is added, when parsing the DER encoding, the key
algorithm is based on the parsed algorithm oid/name. However, an
exception is thrown if the parsed algorithm oid/name
It should be ok to remove the if (secret == null) block of
test/jdk/sun/security/pkcs11/tls/TestPRF.java.
I verified that the test runs fine on Linux without that block, so the
comment is legit.
Thanks,
Valerie
On 5/5/2020 4:17 PM, Mikael Vidstedt wrote:
John,
Thanks for the review!
Looks fine to me.
Xuelei
On 5/7/2020 1:31 PM, Sean Mullan wrote:
The LuxTrust CA has resolved the issue on their side, so the fix is
simply to remove the test from the ProblemList:
diff -r 868fe697bad4 test/jdk/ProblemList.txt
--- a/test/jdk/ProblemList.txt Thu May 07 19:18:22 2020 +0100
One more thing:
test/jdk/sun/security/pkcs11/Config/ReadConfInUTF16Env.java:
Not worth keeping the tests in this directory.
We do need the tests under test/jdk/sun/security/pkcs11/Config/, please
add them back if you have already removed them.
As stated earlier, the config parsing
Will generate a new webrev shortly, meanwhile some comments inline..
> On May 7, 2020, at 1:02 AM, Weijun Wang wrote:
>
>
>
>> On May 7, 2020, at 1:05 PM, Mikael Vidstedt
>> wrote:
>>
>>
>> New webrev here:
>>
>> webrev:
>>
src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/Config.java:
Maybe we should not support $ISA at all?
I suppose it should be ok not supporting $ISA. Existing PKCS11 provider
documentation does not mention it anyway.
test/jdk/sun/security/pkcs11/Provider/ConfigShortPath.java:
The LuxTrust CA has resolved the issue on their side, so the fix is
simply to remove the test from the ProblemList:
diff -r 868fe697bad4 test/jdk/ProblemList.txt
--- a/test/jdk/ProblemList.txt Thu May 07 19:18:22 2020 +0100
+++ b/test/jdk/ProblemList.txt Thu May 07 16:30:47 2020 -0400
@@
>
>>
>> * Get confirmation if https://bugs.openjdk.java.net/browse/JDK-8039280 is
>> enough to cover
>> test/jdk/sun/security/provider/PolicyParser/PrincipalExpansionError.java
>
> The test has been neglected for a long time, but I think in theory the
> SolarisPrincipal can be substituted
> On May 7, 2020, at 1:05 PM, Mikael Vidstedt
> wrote:
>
>
> New webrev here:
>
> webrev:
> http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.01/security/open/webrev/
> incremental:
> http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.01/security.incr/open/webrev/
>
>
12 matches
Mail list logo
