Please take a review at
https://cr.openjdk.java.net/~weijun/8244674/webrev.00
I've consolidated 2 old tests into one and added a new case.
Thanks,
Max
Looks fine to me.
Xuelei
On 5/8/2020 1:14 PM, Valerie Peng wrote:
Anyone can help with this trivial two-line change? Just updating the
version to 1.8.26 from 1.8.24, no change to the headers' content besides
the version change/update.
RFE: https://bugs.openjdk.java.net/browse/JDK-8244151
Anyone can help with this trivial two-line change? Just updating the
version to 1.8.26 from 1.8.24, no change to the headers' content besides
the version change/update.
RFE: https://bugs.openjdk.java.net/browse/JDK-8244151
Webrev: http://cr.openjdk.java.net/~valeriep/8244151/webrev.00/
Noticed one minor thing:
Additional lines can be removed, i.e. other non-SunPKCS11-nss ones can
probably removed, i.e. line 15, 16, and 19.
Thanks,
Valerie
On 5/6/2020 10:05 PM, Mikael Vidstedt wrote:
New webrev here:
webrev:
Found an existing test I can update. Webrev updated at
http://cr.openjdk.java.net/~weijun/8244565/webrev.01/
Thanks,
Max
> On May 8, 2020, at 5:41 PM, Weijun Wang wrote:
>
> Please take a review at
>
> http://cr.openjdk.java.net/~weijun/8244565/webrev.00/
>
> Now we accepts a PKCS8
Please take a review at
http://cr.openjdk.java.net/~weijun/8244565/webrev.00/
Now we accepts a PKCS8 file with version being 0 or 1. The publicKey and
attributes are still not parsed.
I also take this chance to make some format change.
There is no regression test and I'll add one. I can