Re: RFR JDK-8247630: Use two key share entries

2020-07-27 Thread Xuelei Fan
I was just wondering, could we just simplify the implementation by using two named groups for the top two-preferred categories, without limited to XDH and ECDHE? For example, if FFDHE is on the top 2, FFDHE will be used as well. Normally, XDH and ECDHE will be used, but the simplifying is a l

Re: DTLS Support

2020-07-27 Thread Xuelei Fan
Hi Scott, Thanks for the feedback. May I have more information if there is a real project/requirement for the use_srtp extension? As would help me plan for the priority for the support. I'm thinking about to support more flexible extension customization, but for now it is not easy to add

Re: RFR JDK-8247630: Use two key share entries

2020-07-27 Thread Jamil Nimeh
Yes, I think I could restructure this to support that approach. You're right in that FFDHE gets the short end of the stick in the current scheme unless it's the only type in the namedGroups property and even then it takes the longest in terms of time. I'll restructure this and issue a new webre

RFR [16] [JDK-8248745] Add jarsigner and keytool tests for restricted algorithms

2020-07-27 Thread abdul . kolarkunnu
Hi All, This is a new test int the area of jarsigner and keytool for the restricted/disabled algorithms. Bug Id - https://bugs.openjdk.java.net/browse/JDK-8248745 Webrev - http://cr.openjdk.java.net/~akolarkunnu/8248745/webrev.00/ Description: Adding a test for key generation, jar signing a

Re: RFR JDK-8247630: Use two key share entries

2020-07-27 Thread Jamil Nimeh
Hi Xuelei, I've updated the webrev based on your suggestion.  It actually made the logic a lot simpler so that was a good suggestion for sure. I also added a couple additional tests in ClientHelloKeyShares.java to cover a few different namedGroup orderings. https://cr.openjdk.java.net/~jnime

Re: DTLS Support

2020-07-27 Thread Scott Palmer
My goal is implementing a server that can stream video to a browser using the WebRTC standard. WebRTC has good browser support and requires only a few lines of JavaScript code on the client side making it an ideal means to send low-latency video. It has many advantages over other mechanisms like

Re: RFR JDK-8247630: Use two key share entries

2020-07-27 Thread Xuelei Fan
Hi Jamil, Thanks for taking the comment. The webrev looks good to me. Just a few trivial comments about the coding style. No more code review is required to me. -for (NamedGroup ng : namedGroups) { +while(ngTypes.size() < 2 && ngIter.hasNext()) { I prefer to use for-each as it h

Re: DTLS Support

2020-07-27 Thread Xuelei Fan
Hi Scott, Thank you very much for the feedback. I filed a feature request: https://bugs.openjdk.java.net/browse/JDK-8250643. Please keep track of the status. Thanks, Xuelei On 7/27/2020 1:24 PM, Scott Palmer wrote: My goal is implementing a server that can stream video to a browser using

Re: RFR JDK-8247630: Use two key share entries

2020-07-27 Thread Jamil Nimeh
All taken care of. https://cr.openjdk.java.net/~jnimeh/reviews/8247630/webrev.03/ --Jamil On 7/27/20 1:58 PM, Xuelei Fan wrote: Hi Jamil, Thanks for taking the comment.  The webrev looks good to me. Just a few trivial comments about the coding style.  No more code review is required to me.

Re: RFR JDK-8247630: Use two key share entries

2020-07-27 Thread Xuelei Fan
Looks good to me. Thanks! Xuelei On 7/27/2020 4:03 PM, Jamil Nimeh wrote: All taken care of. https://cr.openjdk.java.net/~jnimeh/reviews/8247630/webrev.03/ --Jamil On 7/27/20 1:58 PM, Xuelei Fan wrote: Hi Jamil, Thanks for taking the comment.  The webrev looks good to me. Just a few triv