Ok, thanks for the reply.
Valerie
On 8/26/2020 5:02 AM, Sean Mullan wrote:
On 8/21/20 2:14 PM, Valerie Peng wrote:
Is it intentional to use toString() in
src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java?
Normally, toString() is kind of loose, not as strict as getName().
Hi Sean,
I think the changes are OK in the latest version. A couple of the files have a
2019 copyright still.
> On Aug 27, 2020, at 10:58 AM, Weijun Wang wrote:
>
>
>
>> On Aug 27, 2020, at 10:36 AM, Seán Coffey wrote:
>>
>> Thanks for the review Max. Comments inline..
>>
>> On 27/08/202
> On Aug 27, 2020, at 10:36 AM, Seán Coffey wrote:
>
> Thanks for the review Max. Comments inline..
>
> On 27/08/2020 14:45, Weijun Wang wrote:
>> I’m OK with using one warning, but prefer it to a little more formal like
>> "POSIX file permission and/or symlink attributes detected…”.
>>
>>
Thanks for the review Max. Comments inline..
On 27/08/2020 14:45, Weijun Wang wrote:
I’m OK with using one warning, but prefer it to a little more formal like
"POSIX file permission and/or symlink attributes detected…”.
One nit in ZipFile.java:
1098 // only set posix perms val
I’m OK with using one warning, but prefer it to a little more formal like
"POSIX file permission and/or symlink attributes detected…”.
One nit in ZipFile.java:
1098 // only set posix perms value via ZipEntry constructor for
now
1099 @Override
1100
updated webrev:
http://cr.openjdk.java.net/~coffeys/webrev.8250968.v2/webrev/
regards,
Sean.
On 27/08/2020 07:42, Seán Coffey wrote:
Hi Max,
I looked at updating the warning string but figured that it might have
been of no interest to end users. How about this edit then ?
+ {"posix.a
