Integrated: 8252204: AArch64: Implement SHA3 accelerator/intrinsic

2020-10-21 Thread Fei Yang
On Wed, 16 Sep 2020 16:36:54 GMT, Fei Yang wrote: > Contributed-by: ard.biesheu...@linaro.org, dong...@huawei.com > > This added an intrinsic for SHA3 using aarch64 v8.2 SHA3 Crypto Extensions. > Reference implementation for core SHA-3 transform using ARMv8.2 Crypto > Extensions: > https://git.

Re: RFR: 8252204: AArch64: Implement SHA3 accelerator/intrinsic [v11]

2020-10-21 Thread Fei Yang
On Thu, 22 Oct 2020 03:59:45 GMT, Vladimir Kozlov wrote: > tier1,2,3 passed. I verified that new SHA3 tests were run and passed. > But because SHA3 is not enabled for now (even on aarch64), it does not test > asm code. > At least testing verified that changes in shared code does not cause any >

Re: RFR: 8252204: AArch64: Implement SHA3 accelerator/intrinsic [v11]

2020-10-21 Thread Vladimir Kozlov
On Wed, 21 Oct 2020 23:42:33 GMT, Fei Yang wrote: >> Contributed-by: ard.biesheu...@linaro.org, dong...@huawei.com >> >> This added an intrinsic for SHA3 using aarch64 v8.2 SHA3 Crypto Extensions. >> Reference implementation for core SHA-3 transform using ARMv8.2 Crypto >> Extensions: >> https:

Re: RFR: 8252204: AArch64: Implement SHA3 accelerator/intrinsic [v10]

2020-10-21 Thread Fei Yang
On Wed, 21 Oct 2020 19:20:28 GMT, Vladimir Kozlov wrote: >> OK. Will update with the following change after Aleksey's PR is integrated: >> >> --- >> a/src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CheckGraalIntrinsics.java >>

Re: RFR: 8252204: AArch64: Implement SHA3 accelerator/intrinsic [v11]

2020-10-21 Thread Fei Yang
> Contributed-by: ard.biesheu...@linaro.org, dong...@huawei.com > > This added an intrinsic for SHA3 using aarch64 v8.2 SHA3 Crypto Extensions. > Reference implementation for core SHA-3 transform using ARMv8.2 Crypto > Extensions: > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git

Integrated: 8199697: FIPS 186-4 RSA Key Generation

2020-10-21 Thread Valerie Peng
On Wed, 30 Sep 2020 03:25:06 GMT, Valerie Peng wrote: > Could someone please help review this RFE? Update existing RSA key pair > generation code following the guidelines from FIPS 186-4 and FIPS 186-5 > (draft). Current proposed changes updates the prime generation code (for P, > Q) based on

Re: RFR CSR: JDK-8254709 (Support for EdDSA signature scheme in JSSE)

2020-10-21 Thread Xuelei Fan
On 10/21/2020 1:01 PM, Jamil Nimeh wrote: I'm not very sure why EdDSA cannot apply to ServerKeyExchange and CertificateVerify in TLS 1.0 and 1.1. ServerKeyExchange and CertificateVerify is used to authenticate the server or the client's possession of the private key of the cert.  So if EdDSA ca

Re: RFR CSR: JDK-8254709 (Support for EdDSA signature scheme in JSSE)

2020-10-21 Thread Jamil Nimeh
Hi Xuelei, thanks for the comments.  I'll respond in-line: On 10/21/2020 11:52 AM, Xuelei Fan wrote: Hi Jamil, Sorry for delay.  It took a few days before I was able to read the CSR. Just a few comments for your consideration. In the specification section, you mentioned how to disable the a

Re: RFR: 8252204: AArch64: Implement SHA3 accelerator/intrinsic [v10]

2020-10-21 Thread Vladimir Kozlov
On Wed, 21 Oct 2020 09:19:57 GMT, Fei Yang wrote: > > Someone in Oracle have to run tier1-tier3 testing with these changes to > > make sure nothing is broken. I don't want to repeat 8254790. > > That's appreciated. > On my side, I run tier1-tier3 both on aarch64 linux and x86_64 linux. > The te

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v7]

2020-10-21 Thread Paul Sandoz
On Tue, 20 Oct 2020 17:23:26 GMT, Maurizio Cimadamore wrote: >> This patch contains the changes associated with the first incubation round >> of the foreign linker access API incubation >> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory >> access support (see JEP 393

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v9]

2020-10-21 Thread Paul Sandoz
On Wed, 21 Oct 2020 11:33:27 GMT, Maurizio Cimadamore wrote: >> This patch contains the changes associated with the first incubation round >> of the foreign linker access API incubation >> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory >> access support (see JEP 393

Re: RFR CSR: JDK-8254709 (Support for EdDSA signature scheme in JSSE)

2020-10-21 Thread Xuelei Fan
Hi Jamil, Sorry for delay. It took a few days before I was able to read the CSR. Just a few comments for your consideration. In the specification section, you mentioned how to disable the algorithms. It might not be necessary. It is just something we need to implement so that it does not b

Re: ldap.mechsAllowedToSendCredentials - only SASL?

2020-10-21 Thread Bernd
And just to add to my confusion, this seems that it only checks when STARTTLS is actually requested but not used? This code really needs revised documentation. +// If current connection is not encrypted, and context seen to be secured with STARTTLS+// or 'mechsAllowedToSendCredenti

Re: ldap.mechsAllowedToSendCredentials - only SASL?

2020-10-21 Thread Bernd
BTW: the security patch looks like "simple" is supposed to be rejected when a principal is set, however this is not the case in my tests. Maybe the method is not called correctly in this case? if ("simple".equalsIgnoreCase(authMechanism) && !envprops.containsKey(SECURITY_PRINCIPAL)) { Gruss Bern

ldap.mechsAllowedToSendCredentials - only SASL?

2020-10-21 Thread Bernd
Hello, I am looking at 11.0.9 PSU (as of Zulu 11.43-sa) about the CVE-2020-14781 / JDK-8237990 fix and try to understand if my customers might be affected. jdk.jndi.ldap.mechsAllowedToSendCredentials It was not obvious to me, how the mechanism restriction works. According to Oracle and Redhat

Integrated: 8242068: Signed JAR support for RSASSA-PSS and EdDSA

2020-10-21 Thread Weijun Wang
On Wed, 23 Sep 2020 14:41:59 GMT, Weijun Wang wrote: > Major points in CSR at https://bugs.openjdk.java.net/browse/JDK-8245274: > > - new sigalg "RSASSA-PSS", "EdDSA", "Ed25519" and "Ed448" can be used in > jarsigner > > - The ".RSA" and ".EC" block extension types (PKCS #7 SignedData inside a

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v4]

2020-10-21 Thread Jorn Vernee
On Mon, 19 Oct 2020 11:24:45 GMT, Jorn Vernee wrote: >> I looked through some Hotspot runtime code and that looks ok. I saw a >> couple of strange things on my way through the code. See comments. > > Hi David, this code somewhat predates me, so I initially kept the JVM_ENTRY > since that was

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v9]

2020-10-21 Thread Maurizio Cimadamore
> This patch contains the changes associated with the first incubation round of > the foreign linker access API incubation > (see JEP 389 [1]). This work is meant to sit on top of the foreign memory > access support (see JEP 393 [2] and associated pull request [3]). > > The main goal of this API

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v8]

2020-10-21 Thread Maurizio Cimadamore
> This patch contains the changes associated with the first incubation round of > the foreign linker access API incubation > (see JEP 389 [1]). This work is meant to sit on top of the foreign memory > access support (see JEP 393 [2] and associated pull request [3]). > > The main goal of this API

Re: RFR: 8252204: AArch64: Implement SHA3 accelerator/intrinsic [v10]

2020-10-21 Thread Fei Yang
On Tue, 20 Oct 2020 23:08:22 GMT, Vladimir Kozlov wrote: > Someone in Oracle have to run tier1-tier3 testing with these changes to make > sure nothing is broken. I don't want to repeat 8254790. That's appreciated. On my side, I run tier1-tier3 both on aarch64 linux and x86_64 linux. The test re

Re: RFR: 8252204: AArch64: Implement SHA3 accelerator/intrinsic [v10]

2020-10-21 Thread Fei Yang
On Tue, 20 Oct 2020 23:06:41 GMT, Vladimir Kozlov wrote: >> Fei Yang has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains 13 commits: >> >> - Fix trailing whitespace issue reported by jcheck >> - Merge master >> - Merge master >> -