Re: RFR: 8255546: Missing coverage for javax.smartcardio.CardPermission and ResponseAPDU

2020-11-09 Thread Fernando Guallini
On Fri, 6 Nov 2020 12:04:20 GMT, Fernando Guallini wrote: > This patch is to add code coverage to the following methods > - javax.smartcardio.CardPermission::**implies** (1) > - javax.smartcardio.ResponseAPDU::**toString** (2) > > Tests are added following the expected implementation given in t

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v15]

2020-11-09 Thread Jorn Vernee
On Mon, 9 Nov 2020 06:07:32 GMT, Nick Gasson wrote: >> Maurizio Cimadamore has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains 64 commits: >> >> - Merge branch '8254162' into 8254231_linker >> - Fix post-merge issues caused by 82190

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v15]

2020-11-09 Thread Jorn Vernee
On Mon, 9 Nov 2020 03:29:05 GMT, David Holmes wrote: >> Maurizio Cimadamore has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains 64 commits: >> >> - Merge branch '8254162' into 8254231_linker >> - Fix post-merge issues caused by 8219

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v15]

2020-11-09 Thread Jorn Vernee
On Mon, 9 Nov 2020 03:31:15 GMT, David Holmes wrote: >> src/hotspot/cpu/aarch64/universalUpcallHandler_aarch64.cpp line 55: >> >>> 53: >>> 54: // FIXME: This should be initialized explicitly instead of lazily/racily >>> 55: static void upcall_init() { >> >> The FIXME is right this should be in

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator) [v22]

2020-11-09 Thread Maurizio Cimadamore
On Sun, 8 Nov 2020 16:28:41 GMT, Alan Bateman wrote: >> Maurizio Cimadamore has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains 29 commits: >> >> - Fix post-merge issues caused by 8219014 >> - Merge branch 'master' into 8254162 >>

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator) [v23]

2020-11-09 Thread Maurizio Cimadamore
> This patch contains the changes associated with the third incubation round of > the foreign memory access API incubation (see JEP 393 [1]). This iteration > focus on improving the usability of the API in 3 main ways: > > * first, by providing a way to obtain truly *shared* segments, which can

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator) [v24]

2020-11-09 Thread Maurizio Cimadamore
> This patch contains the changes associated with the third incubation round of > the foreign memory access API incubation (see JEP 393 [1]). This iteration > focus on improving the usability of the API in 3 main ways: > > * first, by providing a way to obtain truly *shared* segments, which can

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v15]

2020-11-09 Thread David Holmes
Hi Jorn, On 9/11/2020 9:57 pm, Jorn Vernee wrote: On Mon, 9 Nov 2020 03:29:05 GMT, David Holmes wrote: src/hotspot/cpu/aarch64/universalUpcallHandler_aarch64.cpp line 99: 97: if (thread == NULL) { 98: JavaVM_ *vm = (JavaVM *)(&main_vm); 99: vm -> functions -> AttachCurrentThreadAs

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator) [v25]

2020-11-09 Thread Maurizio Cimadamore
> This patch contains the changes associated with the third incubation round of > the foreign memory access API incubation (see JEP 393 [1]). This iteration > focus on improving the usability of the API in 3 main ways: > > * first, by providing a way to obtain truly *shared* segments, which can

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator) [v26]

2020-11-09 Thread Maurizio Cimadamore
> This patch contains the changes associated with the third incubation round of > the foreign memory access API incubation (see JEP 393 [1]). This iteration > focus on improving the usability of the API in 3 main ways: > > * first, by providing a way to obtain truly *shared* segments, which can

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v15]

2020-11-09 Thread Jorn Vernee
On Fri, 6 Nov 2020 22:02:31 GMT, Coleen Phillimore wrote: >> src/hotspot/cpu/aarch64/universalUpcallHandler_aarch64.cpp line 81: >> >>> 79: #endif >>> 80: >>> 81: Method* method = k->lookup_method(mname_sym, mdesc_sym); >> >> This "method" appears unused. > > This should be moved into javaCl

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v15]

2020-11-09 Thread Jorn Vernee
On Mon, 9 Nov 2020 12:11:56 GMT, Jorn Vernee wrote: >> I agree with Coleen. > > I'll give this another try, but I think last time I tried this resolution of > the class failed when trying to build the JDK, seemingly since it exists in > an incubator module, which is not always added to the modu

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v14]

2020-11-09 Thread Jorn Vernee
On Mon, 9 Nov 2020 03:56:38 GMT, David Holmes wrote: >> Maurizio Cimadamore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix typo in upcall helper for aarch64 > > src/java.base/share/classes/java/lang/System.java line 2086: > >> 2084

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v15]

2020-11-09 Thread Jorn Vernee
On Mon, 9 Nov 2020 03:52:27 GMT, David Holmes wrote: >> Maurizio Cimadamore has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains 64 commits: >> >> - Merge branch '8254162' into 8254231_linker >> - Fix post-merge issues caused by 8219

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v15]

2020-11-09 Thread Jorn Vernee
On Fri, 6 Nov 2020 22:07:39 GMT, Coleen Phillimore wrote: >> Maurizio Cimadamore has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains 64 commits: >> >> - Merge branch '8254162' into 8254231_linker >> - Fix post-merge issues caused by

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v15]

2020-11-09 Thread Jorn Vernee
Hi David, On 09/11/2020 14:51, David Holmes wrote: Hi Jorn, On 9/11/2020 9:57 pm, Jorn Vernee wrote: On Mon, 9 Nov 2020 03:29:05 GMT, David Holmes wrote: src/hotspot/cpu/aarch64/universalUpcallHandler_aarch64.cpp line 99: 97:   if (thread == NULL) { 98: JavaVM_ *vm = (JavaVM *)(&main

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v16]

2020-11-09 Thread Maurizio Cimadamore
> This patch contains the changes associated with the first incubation round of > the foreign linker access API incubation > (see JEP 389 [1]). This work is meant to sit on top of the foreign memory > access support (see JEP 393 [2] and associated pull request [3]). > > The main goal of this API

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v16]

2020-11-09 Thread David Holmes
On Mon, 9 Nov 2020 18:25:27 GMT, Maurizio Cimadamore wrote: >> This patch contains the changes associated with the first incubation round >> of the foreign linker access API incubation >> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory >> access support (see JEP 393 [

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v15]

2020-11-09 Thread David Holmes
On 10/11/2020 2:34 am, Jorn Vernee wrote: On Mon, 9 Nov 2020 12:11:56 GMT, Jorn Vernee wrote: I agree with Coleen. I'll give this another try, but I think last time I tried this resolution of the class failed when trying to build the JDK, seemingly since it exists in an incubator module, w