Re: [11u] RFR 8259886: Improve SSL session cache performance and scalability

2021-03-16 Thread Daniel Jeliński
Thanks again Paul. Could you sponsor the change? As far as I can tell, I'd need to add a fix request now, but I don't have access to issue tracker. Thanks, Daniel wt., 16 mar 2021 o 18:59 Hohensee, Paul napisał(a): > > Looks good! :) > > -Original Message- > From: Daniel Jeliński > Dat

Re: RFR: JDK-8263188: JSSE should fail fast if there isn't supported signature algorithm [v2]

2021-03-16 Thread John Jiang
> If signature_algorithms extension is present, but the algorithms are > unreconginzed or unsupported, JSSE peers should send fatal alert immediately. > For example, in this case, it's unnecssary to try to produce ServerHello, > Certificate and ServerKeyExchange messages. John Jiang has updated

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators

2021-03-16 Thread Tommy Ettinger
On Mon, 15 Mar 2021 20:45:30 GMT, Paul Sandoz wrote: >> I still don't like the fact that the factory uses reflection but i don't see >> how to do better > > This is now looking very nicely structured. > > The only thing i am unsure are the details around `RandomGenerator` being a > service pro

Re: RFR: 8260274: Cipher.init(int, key) does not use highest priority provider for random bytes

2021-03-16 Thread Valerie Peng
On Tue, 16 Mar 2021 20:57:48 GMT, Valerie Peng wrote: >>> As this behavior has been a while, I may not update the implementation. >>> Instead, I would like to add an "implNote" tag to state that once the >>> default provider is loaded, an implementation may be changed it any longer. >>> Applic

Re: RFR: 8260274: Cipher.init(int, key) does not use highest priority provider for random bytes

2021-03-16 Thread Valerie Peng
On Tue, 16 Mar 2021 20:53:27 GMT, Valerie Peng wrote: >> I did not get the point that the code path should be unaffected". As there >> are a few update like: >> init(keysize, JCAUtil.getSecureRandom()); >> init(keysize, JCAUtil.getDefSecureRandom()); >> >> I think there are so

Re: RFR: 8260274: Cipher.init(int, key) does not use highest priority provider for random bytes

2021-03-16 Thread Valerie Peng
On Tue, 16 Mar 2021 15:29:51 GMT, Xue-Lei Andrew Fan wrote: >> Doesn't that still incur a JVM-wide lock whenever >> `CachedSecureRandomHolder.getDefSecureRandom()` is called? I recall a >> different JVM-wide lock in the `getInstance` path >> ([JDK-7107615](https://bugs.openjdk.java.net/browse

RE: [11u] RFR 8259886: Improve SSL session cache performance and scalability

2021-03-16 Thread Hohensee, Paul
Looks good! :) -Original Message- From: Daniel Jeliński Date: Tuesday, March 16, 2021 at 9:49 AM To: "Hohensee, Paul" Cc: "[email protected]" , "[email protected]" Subject: RE: [11u] RFR 8259886: Improve SSL session cache performance and scalability Thanks

Re: [11u] RFR 8259886: Improve SSL session cache performance and scalability

2021-03-16 Thread Daniel Jeliński
Thanks Paul for your review and for the hint. Updated webrev: https://djelinski.github.io/8259886-11u/webrev2/index.html compared to original, changes to make/test/BuildMicrobenchmark.gmk were dropped because file does not exist in jdk11 compared to previous webrev, CacheBench was re-added. Test

Re: RFR: 8260274: Cipher.init(int, key) does not use highest priority provider for random bytes

2021-03-16 Thread Xue-Lei Andrew Fan
On Tue, 16 Mar 2021 00:10:00 GMT, SalusaSecondus wrote: >> Or, I can also separate out the instance returned by getSecureRandom() so >> that code path should be unaffected, e.g.: >> // cached SecureRandom instance >> private static class CachedSecureRandomHolder { >> public stat

Re: [11u] RFR: 8243559: Remove root certificates with 1024-bit keys

2021-03-16 Thread Severin Gehwolf
On Tue, 2021-03-16 at 10:39 +, Doerr, Martin wrote: > http://cr.openjdk.java.net/~mdoerr/8243559_root_ca_11u/webrev.00/ This looks good to me. Thanks, Severin

Re: [11u] RFR: 8243559: Remove root certificates with 1024-bit keys

2021-03-16 Thread Severin Gehwolf
Hi Martin, On Mon, 2021-03-15 at 17:10 +, Doerr, Martin wrote: > 11u backport: > http://cr.openjdk.java.net/~mdoerr/8261209_xml_11u/webrev.00/ This doesn't look like the right webrev to me. Could you please double- check? Thanks, Severin

Integrated: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy

2021-03-16 Thread Andrey Turbanov
On Sun, 20 Dec 2020 17:05:21 GMT, Andrey Turbanov wrote: > 8080272 Refactor I/O stream copying to use > InputStream.transferTo/readAllBytes and Files.copy This pull request has now been integrated. Changeset: 68deb24b Author:Andrey Turbanov Committer: Julia Boes URL: https://git.