Re: RFR: 8262316: Reducing locks in RSA Blinding [v2]

2021-04-02 Thread djelinski
On Sat, 3 Apr 2021 01:06:50 GMT, Florent Guillaume wrote: >> Ok, thanks for pointing that out, I didn't realize that limitation. However >> using synchronizedMap is overkill as it locks every operation. As I read >> it, only structural changes like adding and removing keys from the map >>

Re: RFR: 8262316: Reducing locks in RSA Blinding [v2]

2021-04-02 Thread Florent Guillaume
On Fri, 2 Apr 2021 23:12:21 GMT, Anthony Scarpino wrote: >> According to SO, unsynchronized writes to a map can lead to lock up, see >> here: >> https://stackoverflow.com/a/1003237 >> Or here: >> https://mailinator.blogspot.com/2009/06/beautiful-race-condition.html?m=1 >> What's the performance

Re: RFR: 8262316: Reducing locks in RSA Blinding [v2]

2021-04-02 Thread Anthony Scarpino
On Fri, 2 Apr 2021 20:52:42 GMT, djelinski wrote: >> Using a synchronizedMap would only let one thread access the hashmap at a >> time, which is what I'm trying to reduce. Get ops do not need to be locked >> and put ops don't either because the values are objects of random data, >> losing

Withdrawn: 8241306: Add SignatureMethodParameterSpec subclass for RSASSA-PSS params

2021-04-02 Thread Weijun Wang
On Wed, 24 Mar 2021 21:36:21 GMT, Weijun Wang wrote: > This enhancement contains the following code changes: > > 1. Create a new public API `javax/xml/crypto/dsig/spec/RSAPSSParameterSpec` > and remove the internal one. > 2. Update marshaling and unmarshaling code inside

Re: Defer disabling TLS 1.0/1.1 by default?

2021-04-02 Thread Colm MacCárthaigh
I'm a mere Java user and developer, I'm not a JDK person. I'm also only on jdk-updates-dev, so if this message ended up in mod-queues, apologies! I'm replying as a TLS person. I work at AWS too, leading our TLS work, and we took a look at this as part of the upcoming changes for Amazon Corretto.

Defer disabling TLS 1.0/1.1 by default?

2021-04-02 Thread Mathiske, Bernd
We have recently been made aware of increasing concerns by customers that disabling TLS 1.0/1.1 in the upcoming round of OpenJDK updates on April 20, as is the plan of record, could still cause outages. So we are considering keeping TLS 1.0/1.1 enabled by default in Amazon Corretto for now.

Re: RFR: 8262316: Reducing locks in RSA Blinding [v2]

2021-04-02 Thread djelinski
On Fri, 2 Apr 2021 17:45:45 GMT, Anthony Scarpino wrote: >> src/java.base/share/classes/sun/security/rsa/RSACore.java line 66: >> >>> 64: // like performance testing. >>> 65: private static final Map>> ConcurrentLinkedQueue> >>> 66: blindingCache = new WeakHashMap<>();

Re: RFR: 8262316: Reducing locks in RSA Blinding [v2]

2021-04-02 Thread Anthony Scarpino
> Hi, > > I need a review of the locking change to the RSA blinding code. The problem > was reported that multithreaded performance suffered because there was one > global lock on the many blindings operation. The change reduces locking by > using a ConcurrentLinkedQueue to store the

Re: Integrated: 8264656: ProblemList sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java on linux-x64

2021-04-02 Thread Daniel D . Daugherty
On Fri, 2 Apr 2021 18:09:48 GMT, Roger Riggs wrote: >> A trivial fix to ProblemList >> sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java >> on linux-x64 > > Marked as reviewed by rriggs (Reviewer). @RogerRiggs - Thanks for the blazingly fast review! - PR:

Integrated: 8264656: ProblemList sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java on linux-x64

2021-04-02 Thread Daniel D . Daugherty
On Fri, 2 Apr 2021 18:04:26 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java > on linux-x64 This pull request has now been integrated. Changeset: d0f3cc92 Author:Daniel D. Daugherty URL:

Re: Integrated: 8264656: ProblemList sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java on linux-x64

2021-04-02 Thread Roger Riggs
On Fri, 2 Apr 2021 18:04:26 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java > on linux-x64 Marked as reviewed by rriggs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3328

Integrated: 8264656: ProblemList sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java on linux-x64

2021-04-02 Thread Daniel D . Daugherty
A trivial fix to ProblemList sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java on linux-x64 - Commit messages: - 8264656: ProblemList sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java on linux-x64 Changes:

Re: RFR: 8262316: Reducing locks in RSA Blinding

2021-04-02 Thread Anthony Scarpino
On Fri, 2 Apr 2021 06:36:57 GMT, djelinski wrote: >> Hi, >> >> I need a review of the locking change to the RSA blinding code. The problem >> was reported that multithreaded performance suffered because there was one >> global lock on the many blindings operation. The change reduces locking

Re: RFR: 8262316: Reducing locks in RSA Blinding

2021-04-02 Thread Anthony Scarpino
On Thu, 1 Apr 2021 15:51:55 GMT, Jamil Nimeh wrote: >> Hi, >> >> I need a review of the locking change to the RSA blinding code. The problem >> was reported that multithreaded performance suffered because there was one >> global lock on the many blindings operation. The change reduces

Re: RFR: 8264148: Update spec for exceptions retrofitted for exception chaining

2021-04-02 Thread Serguei Spitsyn
On Wed, 24 Mar 2021 23:17:46 GMT, Joe Darcy wrote: > 8264148: Update spec for exceptions retrofitted for exception chaining Joe, The Serviceability part looks good. Thanks, Serguei - PR: https://git.openjdk.java.net/jdk/pull/3182

RFR: 8264554: X509KeyManagerImpl calls getProtectionParameter with incorrect alias

2021-04-02 Thread Xue-Lei Andrew Fan
In X509KeyManagerImpl.java, a composited entry alias consists three parts: an UID counter, a builder index and the real entry alias (See the makeAlias() method). While calling the KeyStore.Builder.getProtectionParameter(String alias) method, the real entry alias should be used instead, rather

Integrated: 8264606: More comment for ECDH public key validation

2021-04-02 Thread Xue-Lei Andrew Fan
On Thu, 1 Apr 2021 17:53:47 GMT, Xue-Lei Andrew Fan wrote: > Improve the readability by adding more comments in the ECDH public key > validation implementation in JDK. This pull request has now been integrated. Changeset: 177bc84f Author:Xue-Lei Andrew Fan URL:

Re: RFR: 8264606: More comment for ECDH public key validation [v2]

2021-04-02 Thread Bradford Wetmore
On Fri, 2 Apr 2021 04:14:44 GMT, Xue-Lei Andrew Fan wrote: >> Improve the readability by adding more comments in the ECDH public key >> validation implementation in JDK. > > Xue-Lei Andrew Fan has updated the pull request incrementally with one > additional commit since the last revision: > >

Re: RFR: 8264277: java.xml.crypto module should be granted FilePermission and SocketPermission

2021-04-02 Thread Sean Mullan
On Tue, 30 Mar 2021 13:02:33 GMT, Weijun Wang wrote: > These permissions are needed so that the URIDereferencer is able to read data > from a file system or a network. As the test shows, you still have to grant > the same type of permission to your application. Marked as reviewed by mullan

Re: RFR: 8260693: Provide the support for specifying a signer in keytool -genkeypair [v4]

2021-04-02 Thread Weijun Wang
On Fri, 2 Apr 2021 04:03:50 GMT, Xue-Lei Andrew Fan wrote: >> Maybe we don't need to resolve it in this code change. If we look carefully >> at RFC 8410 Sections 10.1 and 10.2, it shows the X25519 certificate in 10.2 >> is using the signer's SKID in 10.1 as its own SKID and it has no AKID. >>

Re: RFR: 8262316: Reducing locks in RSA Blinding

2021-04-02 Thread djelinski
On Wed, 31 Mar 2021 21:47:24 GMT, Anthony Scarpino wrote: > Hi, > > I need a review of the locking change to the RSA blinding code. The problem > was reported that multithreaded performance suffered because there was one > global lock on the many blindings operation. The change reduces