Re: JEP411: Missing use-case: Monitoring / restricting libraries

2021-05-14 Thread Peter Firmstone
On 13/05/2021 10:59 pm, Sean Mullan wrote: The JEP does have a section on this: "In future JDK releases, we may degrade the Security Manager APIs so that they remain in place but have limited or no functionality. For example, we may revise AccessController::doPrivileged simply to run the g

Integrated: JDK-6676643: Improve current C_GetAttributeValue native implementation

2021-05-14 Thread Valerie Peng
On Tue, 27 Apr 2021 02:41:12 GMT, Valerie Peng wrote: > Anyone can help review this somewhat trivial fix? The main change is inside > src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_objmgmt.c. This is to > help better troubleshooting by reporting the type of unavailable attributes > in PK

Re: RFR: JDK-6676643: Improve current C_GetAttributeValue native implementation [v3]

2021-05-14 Thread Xue-Lei Andrew Fan
On Fri, 14 May 2021 19:42:26 GMT, Valerie Peng wrote: >> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/PKCS11Exception.java >> line 212: >> >>> 210: long value() { >>> 211: return value; >>> 212: } >> >> I guess it is safe to use the 'value' vari

Re: RFR: JDK-6676643: Improve current C_GetAttributeValue native implementation [v4]

2021-05-14 Thread Valerie Peng
> Anyone can help review this somewhat trivial fix? The main change is inside > src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_objmgmt.c. This is to > help better troubleshooting by reporting the type of unavailable attributes > in PKCS11 exception message when C_GetAttributeValue(...) cal

Re: RFR: JDK-6676643: Improve current C_GetAttributeValue native implementation [v3]

2021-05-14 Thread Valerie Peng
On Fri, 14 May 2021 00:15:09 GMT, Xue-Lei Andrew Fan wrote: >> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> PKCS11Exception class refactoring - use enum instead of HashMap > > src/jdk.crypto.cryptoki/share/classes/sun/sec

Re: JEP411: Missing use-case: Monitoring / restricting libraries

2021-05-14 Thread Peter Firmstone
Thanks for confirming. Cheers, Peter. On 13/05/2021 10:59 pm, Sean Mullan wrote: On 5/13/21 6:00 AM, Ron Pressler wrote: On 13 May 2021, at 10:32, Peter Firmstone wrote: So it targets 17. I don’t know. I think that’s still TBD, but perhaps others know more. At this point, yes, we