Integrated: 8272708: [Test]: Cleanup: test/jdk/security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java no longer needs ocspEnabled

2021-08-19 Thread Thejasvi Voniadka
On Thu, 19 Aug 2021 12:11:21 GMT, Thejasvi Voniadka wrote: > Hi, > > Please review this simple clean-up fix to remove an unused variable. The test > passed on all platforms after this clean-up. This pull request has now been integrated. Changeset: 4bd37c31 Author:Thejasvi Voniadka Commi

Re: RFR: 8271566: DSA signature length value is not accurate in P11Signature [v2]

2021-08-19 Thread Valerie Peng
On Fri, 13 Aug 2021 17:11:45 GMT, Martin Balao wrote: >> As described in JDK-8271566 [1], this patch proposal is intended to fix a >> problem that arises when using DSA keys that have a 256-bits (or larger) G >> parameter for signatures (either signing or verifying). There were some >> incorre

Re: RFR: 8267125: AES Galois CounterMode (GCM) interleaved implementation using AVX512 + VAES instructions [v11]

2021-08-19 Thread Smita Kamath
> I would like to submit AES-GCM optimization for x86_64 architectures > supporting AVX3+VAES (Evex encoded AES). This optimization interleaves AES > and GHASH operations. > Performance gain of ~1.5x - 2x for message sizes 8k and above. Smita Kamath has updated the pull request with a new target

Re: RFR: 8270344: Session resumption errors [v4]

2021-08-19 Thread Xue-Lei Andrew Fan
On Thu, 19 Aug 2021 13:07:59 GMT, Sean Coffey wrote: >> Corner case where a session resumption can fail if the TLS server changes >> supported protocol versions in relation to a cached SSLSession. This is >> primarily an issue where the legacy TLS version is used in place of the >> newer "supp

Re: RFR: 8272708: [Test]: Cleanup: test/jdk/security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java no longer needs ocspEnabled

2021-08-19 Thread Rajan Halade
On Thu, 19 Aug 2021 12:11:21 GMT, Thejasvi Voniadka wrote: > Hi, > > Please review this simple clean-up fix to remove an unused variable. The test > passed on all platforms after this clean-up. Marked as reviewed by rhalade (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull

Integrated: 8272674: Logging missing keytab file in Krb5LoginModule

2021-08-19 Thread Weijun Wang
On Wed, 18 Aug 2021 22:33:42 GMT, Weijun Wang wrote: > The "Key for the principal foo...@acme.com not available in > /home/foobar/foobar.keytab" debug output does not contain enough information. > The keytab file might be missing, or not readable, or does not contain the > required key(s). >

Re: RFR: 8271560: sun/security/ssl/DHKeyExchange/LegacyDHEKeyExchange.java still fails due to "An established connection was aborted by the software in your host machine" [v2]

2021-08-19 Thread Xue-Lei Andrew Fan
On Wed, 4 Aug 2021 14:16:55 GMT, Fernando Guallini wrote: >> The following test has been seen to fail intermittently on Windows platform: >> sun/security/ssl/DHKeyExchange/LegacyDHEKeyExchange.java >> with the exception: >> java.net.SocketException: An established connection was aborted by the

Re: Add CBC and DHE to legacy ciphers (avoid cipher order)?

2021-08-19 Thread Sean Mullan
Hi Bernd, On 8/19/21 6:43 AM, Bernd wrote: Hello, while researching some TLS hardening (of JAva Implementations) I was wondering the following: - not requiring the preferred server cipher order has advantages, because it is easier to configure, is the OpenJDK default, allows clients some f

Re: RFR: 8270344: Session resumption errors [v4]

2021-08-19 Thread Sean Coffey
> Corner case where a session resumption can fail if the TLS server changes > supported protocol versions in relation to a cached SSLSession. This is > primarily an issue where the legacy TLS version is used in place of the newer > "supported_versions" TLS extension. Sean Coffey has updated the

RFR: 8272708: [Test]: Cleanup: test/jdk/security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java no longer needs ocspEnabled

2021-08-19 Thread Thejasvi Voniadka
Hi, Please review this simple clean-up fix to remove an unused variable. The test passed on all platforms after this clean-up. - Commit messages: - 8272708: [Test]: Cleanup: test/jdk/security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java no longer needs

Re: RFR: 8270344: Session resumption errors [v3]

2021-08-19 Thread Sean Coffey
> Corner case where a session resumption can fail if the TLS server changes > supported protocol versions in relation to a cached SSLSession. This is > primarily an issue where the legacy TLS version is used in place of the newer > "supported_versions" TLS extension. Sean Coffey has updated the

Re: RFR: 8268764: Use Long.hashCode() instead of int-cast where applicable [v4]

2021-08-19 Thread Сергей Цыпанов
On Thu, 1 Jul 2021 12:19:53 GMT, Сергей Цыпанов wrote: >> In some JDK classes there's still the following hashCode() implementation: >> >> long objNum; >> >> public int hashCode() { >> return (int) objNum; >> } >> >> This outdated expression should be replaced with Long.hashCode(long) as

Re: RFR: 8271560: sun/security/ssl/DHKeyExchange/LegacyDHEKeyExchange.java still fails due to "An established connection was aborted by the software in your host machine" [v2]

2021-08-19 Thread Fernando Guallini
On Wed, 4 Aug 2021 14:16:55 GMT, Fernando Guallini wrote: >> The following test has been seen to fail intermittently on Windows platform: >> sun/security/ssl/DHKeyExchange/LegacyDHEKeyExchange.java >> with the exception: >> java.net.SocketException: An established connection was aborted by the

Add CBC and DHE to legacy ciphers (avoid cipher order)?

2021-08-19 Thread Bernd
Hello, while researching some TLS hardening (of JAva Implementations) I was wondering the following: - not requiring the preferred server cipher order has advantages, because it is easier to configure, is the OpenJDK default, allows clients some freedom to chose performance over strength and it a

Re: RFR: 8272674: Logging missing keytab file in Krb5LoginModule

2021-08-19 Thread Sean Coffey
On Wed, 18 Aug 2021 22:33:42 GMT, Weijun Wang wrote: > The "Key for the principal foo...@acme.com not available in > /home/foobar/foobar.keytab" debug output does not contain enough information. > The keytab file might be missing, or not readable, or does not contain the > required key(s). >

Re: RFR: 8270344: Session resumption errors

2021-08-19 Thread Sean Coffey
On Wed, 18 Aug 2021 19:03:10 GMT, djelinski wrote: >> Corner case where a session resumption can fail if the TLS server changes >> supported protocol versions in relation to a cached SSLSession. This is >> primarily an issue where the legacy TLS version is used in place of the >> newer "suppo

Re: RFR: 8270344: Session resumption errors [v2]

2021-08-19 Thread Sean Coffey
> Corner case where a session resumption can fail if the TLS server changes > supported protocol versions in relation to a cached SSLSession. This is > primarily an issue where the legacy TLS version is used in place of the newer > "supported_versions" TLS extension. Sean Coffey has updated the