Integrated: 8274736: Concurrent read/close of SSLSockets causes SSLSessions to be invalidated unnecessarily

2021-11-09 Thread Jamil Nimeh
On Mon, 1 Nov 2021 18:28:54 GMT, Jamil Nimeh wrote: > This fix handles cases where two or more threads may be acting on a single > SSLSocket instance. In cases where one thread closes the socket while the > other is in the middle of a read, a SocketException is appropriately thrown, > but it

Re: RFR: 8274736: Concurrent read/close of SSLSockets causes SSLSessions to be invalidated unnecessarily [v5]

2021-11-09 Thread Bradford Wetmore
On Fri, 5 Nov 2021 22:55:16 GMT, Jamil Nimeh wrote: >> This fix handles cases where two or more threads may be acting on a single >> SSLSocket instance. In cases where one thread closes the socket while the >> other is in the middle of a read, a SocketException is appropriately thrown, >> but

Re: RFR: 8274308: Improve efficiency for HandshakeContext initialization. [v2]

2021-11-09 Thread Clive Verghese
On Sat, 6 Nov 2021 08:54:33 GMT, Daniel Jeliński wrote: >>> Hi @XueleiFan, >>> >>> Thank you for the feedback, though it’s not recommended to set the >>> protocols and cipher suites, various frameworks often do set these values, >>> [Some references below]. Would it still make sense to only op

Re: RFR: 8274308: Improve efficiency for HandshakeContext initialization. [v2]

2021-11-09 Thread Xue-Lei Andrew Fan
On Sat, 6 Nov 2021 08:54:33 GMT, Daniel Jeliński wrote: >>> Hi @XueleiFan, >>> >>> Thank you for the feedback, though it’s not recommended to set the >>> protocols and cipher suites, various frameworks often do set these values, >>> [Some references below]. Would it still make sense to only op

Re: RFR: 8274308: Improve efficiency for HandshakeContext initialization. [v2]

2021-11-09 Thread Clive Verghese
On Sat, 6 Nov 2021 08:54:33 GMT, Daniel Jeliński wrote: >>> Hi @XueleiFan, >>> >>> Thank you for the feedback, though it’s not recommended to set the >>> protocols and cipher suites, various frameworks often do set these values, >>> [Some references below]. Would it still make sense to only op

Re: RFR: 8276863: Remove test/jdk/sun/security/ec/ECDSAJavaVerify.java

2021-11-09 Thread Anthony Scarpino
On Tue, 9 Nov 2021 14:23:54 GMT, Weijun Wang wrote: > The test was added in JDK-8237218 to confirm that Java impl is used when > verifying a signature. It is useless now since the native implementation is > completely removed. Look good - Marked as reviewed by ascarpino (Reviewer

Integrated: 8276863: Remove test/jdk/sun/security/ec/ECDSAJavaVerify.java

2021-11-09 Thread Weijun Wang
On Tue, 9 Nov 2021 14:23:54 GMT, Weijun Wang wrote: > The test was added in JDK-8237218 to confirm that Java impl is used when > verifying a signature. It is useless now since the native implementation is > completely removed. This pull request has now been integrated. Changeset: c27afb31 Aut

RFR: 8276863: Remove test/jdk/sun/security/ec/ECDSAJavaVerify.java

2021-11-09 Thread Weijun Wang
The test was added in JDK-8237218 to confirm that Java impl is used when verifying a signature. It is useless now since the native implementation is completely removed. - Commit messages: - 8276863: Remove test/jdk/sun/security/ec/ECDSAJavaVerify.java Changes: https://git.openjdk.