Re: [jdk18] RFR: JDK-8278967 rmiregistry fails to start because SecurityManager is disabled [v2]

2021-12-21 Thread Stuart Marks
On Wed, 22 Dec 2021 01:18:58 GMT, Stuart Marks wrote: >> Enable the security manager in rmiregistry's launcher arguments. > > Stuart Marks has updated the pull request incrementally with one additional > commit since the last revision: > > Change java.security.manager to "allow"; filter warni

Re: [jdk18] RFR: JDK-8278967 rmiregistry fails to start because SecurityManager is disabled [v2]

2021-12-21 Thread Stuart Marks
> Enable the security manager in rmiregistry's launcher arguments. Stuart Marks has updated the pull request incrementally with one additional commit since the last revision: Change java.security.manager to "allow"; filter warning lines from VersionCheck - Changes: - all: http

Re: RFR: 8209398: sun/security/pkcs11/KeyStore/SecretKeysBasic.sh failed with "PKCS11Exception: CKR_ATTRIBUTE_SENSITIVE"

2021-12-21 Thread Weijun Wang
On Tue, 14 Dec 2021 18:33:47 GMT, Valerie Peng wrote: > Can someone help review this small fix? NSS returns PKCS11 > CKR_ATTRIBUTE_SENSITIVE error when trying to retrieve CKA_VALUE out of its > token keys. So this fix is to add special handling for NSS token secret keys. > There is already an

Re: RFR: 8209398: sun/security/pkcs11/KeyStore/SecretKeysBasic.sh failed with "PKCS11Exception: CKR_ATTRIBUTE_SENSITIVE"

2021-12-21 Thread Weijun Wang
On Tue, 14 Dec 2021 18:33:47 GMT, Valerie Peng wrote: > Can someone help review this small fix? NSS returns PKCS11 > CKR_ATTRIBUTE_SENSITIVE error when trying to retrieve CKA_VALUE out of its > token keys. So this fix is to add special handling for NSS token secret keys. > There is already an

Re: RFR: 8209398: sun/security/pkcs11/KeyStore/SecretKeysBasic.sh failed with "PKCS11Exception: CKR_ATTRIBUTE_SENSITIVE"

2021-12-21 Thread Hai-May Chao
On Tue, 14 Dec 2021 18:33:47 GMT, Valerie Peng wrote: > Can someone help review this small fix? NSS returns PKCS11 > CKR_ATTRIBUTE_SENSITIVE error when trying to retrieve CKA_VALUE out of its > token keys. So this fix is to add special handling for NSS token secret keys. > There is already an

Re: RFR: 8279066: Still see private key entries without certificates in a PKCS12 keystore

2021-12-21 Thread Michael StJohns
On 12/21/2021 1:26 PM, Sean Mullan wrote: On Tue, 21 Dec 2021 16:31:57 GMT, Weijun Wang wrote: Before password-less PKCS12 keystores are supported, certificates in a PKCS12 file are always encrypted. Therefore if one loads the keystore with a null pass, it contains `PrivateKeyEntry`s without

Integrated: 8279066: entries.remove(entry) is useless in PKCS12KeyStore

2021-12-21 Thread Weijun Wang
On Tue, 21 Dec 2021 16:31:57 GMT, Weijun Wang wrote: > Before password-less PKCS12 keystores are supported, certificates in a PKCS12 > file are always encrypted. Therefore if one loads the keystore with a null > pass, it contains `PrivateKeyEntry`s without certificates. This has always > been

Re: [jdk18] RFR: JDK-8278967 rmiregistry fails to start because SecurityManager is disabled

2021-12-21 Thread David Holmes
On Sun, 19 Dec 2021 07:37:19 GMT, Alan Bateman wrote: >> Enable the security manager in rmiregistry's launcher arguments. > > As things stand, `rmiregsitry -J-Djava.security.manager` and `rmiregistry > -J-Djava.security.manager=allow` are equivalent because rmiregistry sets the > default SM. So

Re: RFR: 8279066: entries.remove(entry) is useless in PKCS12KeyStore [v2]

2021-12-21 Thread Sean Mullan
On Tue, 21 Dec 2021 21:39:23 GMT, Weijun Wang wrote: >> Before password-less PKCS12 keystores are supported, certificates in a >> PKCS12 file are always encrypted. Therefore if one loads the keystore with a >> null pass, it contains `PrivateKeyEntry`s without certificates. This has >> always b

Re: RFR: 8279066: entries.remove(entry) is useless in PKCS12KeyStore

2021-12-21 Thread Weijun Wang
On Tue, 21 Dec 2021 16:31:57 GMT, Weijun Wang wrote: > Before password-less PKCS12 keystores are supported, certificates in a PKCS12 > file are always encrypted. Therefore if one loads the keystore with a null > pass, it contains `PrivateKeyEntry`s without certificates. This has always > been

Re: RFR: 8279066: entries.remove(entry) is useless in PKCS12KeyStore [v2]

2021-12-21 Thread Weijun Wang
> Before password-less PKCS12 keystores are supported, certificates in a PKCS12 > file are always encrypted. Therefore if one loads the keystore with a null > pass, it contains `PrivateKeyEntry`s without certificates. This has always > been awkward (and most likely useless) so when JDK-8076190 i

Re: RFR: 8277881 Missing SessionID in TLS1.3 resumption in compatibility mode

2021-12-21 Thread Anthony Scarpino
On Mon, 29 Nov 2021 08:42:22 GMT, Daniel Jeliński wrote: > All TLS 1.3 handshakes in compatibility mode must send a non-empty SessionID > field. Currently TLS1.3 session resumptions are sending empty session ID. > This patch fixes that problem. > > All jdk_core tests passed. The newly added ch

Integrated: 8279043: Some Security Exception Messages Miss Spaces

2021-12-21 Thread Daniel Jeliński
On Mon, 20 Dec 2021 14:50:08 GMT, Daniel Jeliński wrote: > Trivial change. Issue reported by > [lgtm.com](https://lgtm.com/projects/g/openjdk/jdk/alerts/?mode=tree&lang=java&ruleFocus=1952840153). This pull request has now been integrated. Changeset: f31dead6 Author:Daniel Jelinski Commit

Re: RFR: 8279066: Still see private key entries without certificates in a PKCS12 keystore

2021-12-21 Thread Sean Mullan
On Tue, 21 Dec 2021 16:31:57 GMT, Weijun Wang wrote: > Before password-less PKCS12 keystores are supported, certificates in a PKCS12 > file are always encrypted. Therefore if one loads the keystore with a null > pass, it contains `PrivateKeyEntry`s without certificates. This has always > been

Re: RFR: 8279043: Some Security Exception Messages Miss Spaces

2021-12-21 Thread Weijun Wang
On Mon, 20 Dec 2021 14:50:08 GMT, Daniel Jeliński wrote: > Trivial change. Issue reported by > [lgtm.com](https://lgtm.com/projects/g/openjdk/jdk/alerts/?mode=tree&lang=java&ruleFocus=1952840153). Thanks. I'll run some tests before sponsoring it. Hopefully no one uses the exact exception messa

Re: RFR: 8279043: Some Security Exception Messages Miss Spaces

2021-12-21 Thread Daniel Jeliński
On Mon, 20 Dec 2021 14:50:08 GMT, Daniel Jeliński wrote: > Trivial change. Issue reported by > [lgtm.com](https://lgtm.com/projects/g/openjdk/jdk/alerts/?mode=tree&lang=java&ruleFocus=1952840153). Thanks! bug title fixed. - PR: https://git.openjdk.java.net/jdk/pull/6894

Re: RFR: 8279043 Some Security Exception Messages Miss Spaces

2021-12-21 Thread Weijun Wang
On Mon, 20 Dec 2021 14:50:08 GMT, Daniel Jeliński wrote: > Trivial change. Issue reported by > [lgtm.com](https://lgtm.com/projects/g/openjdk/jdk/alerts/?mode=tree&lang=java&ruleFocus=1952840153). Change looks good. Please add a colon after the bug ID in the title. Otherwise Skara might not in

Re: Incorrect exception strings

2021-12-21 Thread Daniel Jeliński
Great, thanks for confirming! Daniel wt., 21 gru 2021 o 17:22 Wei-Jun Wang napisał(a): > > Hi Daniel, > > Yes, http://openjdk.java.net/projects/#project-author page contains a > template. You mainly need to talk about your previous contributions to > OpenJDK. > > And yes, the Project Lead is Ma

RFR: 8279066: Still see private key entries without certificates in a PKCS12 keystore

2021-12-21 Thread Weijun Wang
Before password-less PKCS12 keystores are supported, certificates in a PKCS12 file are always encrypted. Therefore if one loads the keystore with a null pass, it contains `PrivateKeyEntry`s without certificates. This has always been awkward (and most likely useless) so when JDK-8076190 introduce

Re: Incorrect exception strings

2021-12-21 Thread Wei-Jun Wang
Hi Daniel, Yes, http://openjdk.java.net/projects/#project-author page contains a template. You mainly need to talk about your previous contributions to OpenJDK. And yes, the Project Lead is Mark Reinhold, mark dot reinhold at oracle dot com. Good luck! --Weijun > On Dec 21, 2021, at 5:29 AM,

Re: Incorrect exception strings

2021-12-21 Thread Daniel Jeliński
Hi Weijun, > The "Account Help" link on https://id.openjdk.java.net/console/login leads to > https://wiki.openjdk.java.net/display/general/FAQ. It seems you need to > become an OpenJDK author first to get an account. Right. This page then leads to http://openjdk.java.net/projects/#project-autho

Re: Incorrect exception strings

2021-12-21 Thread Daniel Jeliński
Thank you Valerie. Without a JBS account I'd have to get a review on the bug report first, and given that this is a trivial fix I wanted to avoid going through that. Thanks again, Daniel pon., 20 gru 2021 o 22:36 Valerie Peng napisał(a): > > I filed https://bugs.openjdk.java.net/browse/JDK-82790

RFR: 8279043 Some Security Exception Messages Miss Spaces

2021-12-21 Thread Daniel Jeliński
Trivial change. Issue reported by [lgtm.com](https://lgtm.com/projects/g/openjdk/jdk/alerts/?mode=tree&lang=java&ruleFocus=1952840153). - Commit messages: - Add missing spaces Changes: https://git.openjdk.java.net/jdk/pull/6894/files Webrev: https://webrevs.openjdk.java.net/?repo=