Integrated: 8280122: SupportedGroupsExtension should output "named groups" rather than "versions"

2022-01-18 Thread John Jiang
On Tue, 18 Jan 2022 11:11:49 GMT, John Jiang wrote: > MessageFormat messageFormat = new MessageFormat( > ""versions": '['{0}']'", Locale.ENGLISH); > > In class SupportedGroupsExtension, the above "versions" should be "named > groups". This pull request has now been integrated. Changeset:

Re: RFR: 8280122: SupportedGroupsExtension should output "named groups" rather than "versions"

2022-01-18 Thread John Jiang
On Tue, 18 Jan 2022 19:52:27 GMT, Weijun Wang wrote: >>> If so, should the `SupportedVersionsExtension` get a more precise >>> description as well? >> >> I did not get the point. Did you mean to update the comment on the >> SupportedVersionsExtension, by adding RFC 8446? > > No, I just meant

Re: RFR: 8255739: x509Certificate returns � for invalid subjectAlternativeNames

2022-01-18 Thread Sean Mullan
On Thu, 6 Jan 2022 20:28:22 GMT, Sean Mullan wrote: >> Could you please review the JDK-8255739 bug fix? >> >> I think sun.security.x509.SubjectAlternativeNameExtension() should throw an >> exception for incorrect SubjectAlternativeNames instead of returning the >> substituted characters, which

Re: RFR: 8280122: SupportedGroupsExtension should output "named groups" rather than "versions"

2022-01-18 Thread Weijun Wang
On Tue, 18 Jan 2022 19:33:19 GMT, Xue-Lei Andrew Fan wrote: >> If so, should the `SupportedVersionsExtension` get a more precise >> description as well? > >> If so, should the `SupportedVersionsExtension` get a more precise >> description as well? > > I did not get the point. Did you mean to

Re: RFR: 8280122: SupportedGroupsExtension should output "named groups" rather than "versions"

2022-01-18 Thread Xue-Lei Andrew Fan
On Tue, 18 Jan 2022 16:27:26 GMT, Weijun Wang wrote: > If so, should the `SupportedVersionsExtension` get a more precise description > as well? I did not get the point. Did you mean to update the comment on the SupportedVersionsExtension, by adding RFC 8446? - PR: https://git.op

Re: RFR: 8280122: SupportedGroupsExtension should output "named groups" rather than "versions"

2022-01-18 Thread Weijun Wang
On Tue, 18 Jan 2022 16:13:42 GMT, Xue-Lei Andrew Fan wrote: >> MessageFormat messageFormat = new MessageFormat( >> ""versions": '['{0}']'", Locale.ENGLISH); >> >> In class SupportedGroupsExtension, the above "versions" should be "named >> groups". > > src/java.base/share/classes/sun/securit

Re: RFR: 8280122: SupportedGroupsExtension should output "named groups" rather than "versions"

2022-01-18 Thread Xue-Lei Andrew Fan
On Tue, 18 Jan 2022 11:11:49 GMT, John Jiang wrote: > MessageFormat messageFormat = new MessageFormat( > ""versions": '['{0}']'", Locale.ENGLISH); > > In class SupportedGroupsExtension, the above "versions" should be "named > groups". Nice catching! src/java.base/share/classes/sun/securit

Integrated: 8280010: Remove double buffering of InputStream for Properties.load

2022-01-18 Thread Andrey Turbanov
On Mon, 10 Jan 2022 20:46:36 GMT, Andrey Turbanov wrote: > `Properties.load` uses `java.util.Properties.LineReader`. LineReader already > buffers input stream. Hence wrapping InputStream in BufferedInputStream is > redundant. This pull request has now been integrated. Changeset: 9eb50a5e Auth

Re: RFR: 8280122: SupportedGroupsExtension should output "named groups" rather than "versions"

2022-01-18 Thread Weijun Wang
On Tue, 18 Jan 2022 11:11:49 GMT, John Jiang wrote: > MessageFormat messageFormat = new MessageFormat( > ""versions": '['{0}']'", Locale.ENGLISH); > > In class SupportedGroupsExtension, the above "versions" should be "named > groups". Marked as reviewed by weijun (Reviewer). -

Re: JEP 411: sandboxing use case

2022-01-18 Thread Olivier Cailloux
Thanks to Sean and Peter for your answers (sorry, I did not manage to answer your messages because of issues with my e-mail provider so I answer mine instead). As Peter observes, putting student code in a restricted VM or container (while the grading code would be more priviledged) does not seem l

RFR: 8280122: SupportedGroupsExtension should output "named groups" rather than "versions"

2022-01-18 Thread John Jiang
MessageFormat messageFormat = new MessageFormat( ""versions": '['{0}']'", Locale.ENGLISH); In class SupportedGroupsExtension, the above "versions" should be "named groups". - Commit messages: - 8280122: SupportedGroupsExtension should output "named groups" rather than "version