On Mon, 7 Feb 2022 22:56:45 GMT, Xue-Lei Andrew Fan wrote:
>> Sorry, you will have to bear with me as I am still not sure how it works - I
>> want to know who wins, the API or the properties, if both are set and I
>> can't find where it answers that above. Maybe I need to read the code. Are
>>
On Mon, 7 Feb 2022 20:16:43 GMT, Lance Andersen wrote:
>> If you are pretty sure the only other case are as above, I wonder if a
>> simpler fix would be to change `verifiableEntry()` to check for these null
>> cases and throw a `ZipException` which will get directly propagated by
>> `getInputS
> Hi all,
>
> Please review the attached patch to address
>
> - That JarFile::getInputStream did not check for a null ZipEntry passed as a
> parameter
> - Have Zip/JarFile::getInputStream throw a ZipException in the event that an
> unexpected exception occurs
>
> Mach5 tiers1-3 runs are clean
On Mon, 7 Feb 2022 22:18:03 GMT, Sean Mullan wrote:
>> I think lines 714-816/723-725 describe the behavior already.
>>
>> I was hesitate to use "override", as the System Property values and the
>> default signature schemes are not actually overrode. The default signature
>> schemes are still
On Mon, 7 Feb 2022 22:00:21 GMT, Xue-Lei Andrew Fan wrote:
>> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 744:
>>
>>> 742: * the {@systemProperty jdk.tls.client.SignatureSchemes} and/or
>>> 743: * {@systemProperty jdk.tls.server.SignatureSchemes} system
>>> prope
On Mon, 7 Feb 2022 19:59:32 GMT, Sean Mullan wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> correct null tags
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 47:
>
>> 45: *
>> 46: *
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
> Release-note: https://bugs.openjdk.java.net/browse/JDK-8
On Mon, 7 Feb 2022 19:51:28 GMT, Sean Mullan wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> correct null tags
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 744:
>
>> 742: * the
On Mon, 7 Feb 2022 18:44:10 GMT, Sean Mullan wrote:
>> Looking at this a bit more, it looks like `JariFile::initializeVerifier` is
>> the only place currently in `JarFile` that could throw a `JarException` and
>> that method could be called from `JarFile::getInputStream`
>>
>> As `verifiableE
On Fri, 4 Feb 2022 20:58:46 GMT, Xue-Lei Andrew Fan wrote:
>> This update is to support signature schemes customization for individual
>> (D)TLS connection. Please review the CSR as well:
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
>> RFE: https://bugs.openjdk.java.net/browse/JDK-8
On Mon, 7 Feb 2022 16:52:07 GMT, Lance Andersen wrote:
>> `JarException` is a subclass of `ZipException` though, so I think this would
>> be ok to throw and still be compliant with the specification.
>
> Looking at this a bit more, it looks like `JariFile::initializeVerifier` is
> the only pla
On Mon, 7 Feb 2022 15:16:43 GMT, Sean Mullan wrote:
>> JarFile::getInputStream. mentions ZipException but not JarException which is
>> why I chose this. If we change this to JarException, I would need to update
>> the javadoc and create a CSR.
>>
>> Please let me know your preference
>
> `Jar
On Fri, 4 Feb 2022 15:19:11 GMT, Lance Andersen wrote:
>> src/java.base/share/classes/java/util/jar/JarFile.java line 866:
>>
>>> 864: } catch (Exception e2) {
>>> 865: // Any other Exception should be a ZipException
>>> 866: throw (ZipException) new ZipException(
On Thu, 3 Feb 2022 17:12:05 GMT, Weijun Wang wrote:
> Add the `-providerPath` option to jarsigner to be consistent with keytool.
This pull request has now been integrated.
Changeset: 2ed1f4cf
Author:Weijun Wang
URL:
https://git.openjdk.java.net/jdk/commit/2ed1f4cf32b1cef4ccb129d622f
On Tue, 1 Feb 2022 21:54:29 GMT, Sean Mullan wrote:
> This fixes a bootstrapping issue if a custom system class loader is set with
> the `-Djava.system.class.loader` option and the custom class loader is inside
> a signed JAR. In order to load the custom class loader, the runtime must
> verif
15 matches
Mail list logo
