On Thu, 10 Feb 2022 18:19:41 GMT, Alexey Bakhtin wrote:
> Please review the patch for the JDK-8274524
>
> SSLSocket.close() could cause an intermittent hang of the socket read
> operation. It happens in case of SO_TIMEOUT is set to 0 (infinite timeout).
> SSLSocket.close() reads from the
On Thu, 10 Feb 2022 15:39:53 GMT, Leo Korinth wrote:
> Remove unused imports under test/lib and jtreg/gc. They create lots of
> warnings if editing using an IDE. Tests in hotspot_gc passed.
Forgot to mention copyright years need updating before integrating! Thanks.
-
PR:
On Thu, 10 Feb 2022 15:39:53 GMT, Leo Korinth wrote:
> Remove unused imports under test/lib and jtreg/gc. They create lots of
> warnings if editing using an IDE. Tests in hotspot_gc passed.
Looks fine. The proof of these changes is in compiling the files - how did you
test the non-gc-test
On Thu, 10 Feb 2022 20:37:50 GMT, Sean Mullan wrote:
>> Agree on returning null to maintain current behavior. I would also lean
>> towards amending the specification to specify what has been long-standing
>> behavior.
>
> If we had to do it over again, I do think throwing IAE is more
> Hi all,
>
> Please review the attached patch to address
>
> - That JarFile::getInputStream did not check for a null ZipEntry passed as a
> parameter
> - Have Zip/JarFile::getInputStream throw a ZipException in the event that an
> unexpected exception occurs
>
> Mach5 tiers1-3 runs are clean
On Thu, 10 Feb 2022 16:47:55 GMT, Weijun Wang wrote:
>> The enhancement adds two extra items in the `getSubjectAlternativeNames()`
>> output for an OtherName.
>>
>> It also fix several errors:
>> 1. In `OtherName.java`, `nameValue` should be the value inside `CONTEXT [0]`
>> without the tag
> The enhancement adds two extra items in the `getSubjectAlternativeNames()`
> output for an OtherName.
>
> It also fix several errors:
> 1. In `OtherName.java`, `nameValue` should be the value inside `CONTEXT [0]`
> without the tag and length bytes.
> 2. The argument in constructor
On Thu, 10 Feb 2022 20:35:19 GMT, Sean Mullan wrote:
>> So a bit more on this. If the ZipEntry passed to `ZipFile::getInputStream`
>> does not represent an entry within the current Zip/Jar,
>> `ZipFile::getInputStream` will return a null for the InputStream:
>>
>>
>> @Test
>>
On Wed, 9 Feb 2022 21:16:08 GMT, Lance Andersen wrote:
>>> Nit, add space after "if"
>>
>> will fix
>
> So a bit more on this. If the ZipEntry passed to `ZipFile::getInputStream`
> does not represent an entry within the current Zip/Jar,
> `ZipFile::getInputStream` will return a null for the
On Thu, 10 Feb 2022 16:47:55 GMT, Weijun Wang wrote:
>> The enhancement adds two extra items in the `getSubjectAlternativeNames()`
>> output for an OtherName.
>>
>> It also fix several errors:
>> 1. In `OtherName.java`, `nameValue` should be the value inside `CONTEXT [0]`
>> without the tag
Please review the patch for the JDK-8274524
SSLSocket.close() could cause an intermittent hang of the socket read
operation. It happens in case of SO_TIMEOUT is set to 0 (infinite timeout).
SSLSocket.close() reads from the socket as part of the skip() operation to
prevent TCP Connection reset
On Wed, 9 Feb 2022 22:09:40 GMT, Xue-Lei Andrew Fan wrote:
>> Alexey Bakhtin has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix jcheck issues
>
> With the patch, the readLock is placed in handshakeLock, and the handshake
> may require
On Thu, 20 Jan 2022 19:42:22 GMT, Weijun Wang wrote:
> The enhancement adds two extra items in the `getSubjectAlternativeNames()`
> output for an OtherName.
>
> It also fix several errors:
> 1. In `OtherName.java`, `nameValue` should be the value inside `CONTEXT [0]`
> without the tag and
> The enhancement adds two extra items in the `getSubjectAlternativeNames()`
> output for an OtherName.
>
> It also fix several errors:
> 1. In `OtherName.java`, `nameValue` should be the value inside `CONTEXT [0]`
> without the tag and length bytes.
> 2. The argument in constructor
On Thu, 10 Feb 2022 13:45:16 GMT, Sean Mullan wrote:
> Looks good, but I think a CSR should also be filed.
Sure, I'll write one now. I've added the `csr` label so that I will not forget
about it. Just want to delay the writing after we agree on the text.
>
Remove unused imports under test/lib and jtreg/gc. They create lots of warnings
if editing using an IDE. Tests in hotspot_gc passed.
-
Commit messages:
- 8281585: Remove unused imports under test/lib and jtreg/gc
Changes: https://git.openjdk.java.net/jdk/pull/7426/files
Webrev:
On Fri, 22 Oct 2021 18:45:31 GMT, Alexey Bakhtin wrote:
>> Hello,
>>
>> Could you please review the small patch for the issue described in
>> JDK-8271199: Mutual TLS handshake fails signing client certificate with
>> custom sensitive PKCS11 key
>>
>> I suggest updating the
On Thu, 20 Jan 2022 19:42:22 GMT, Weijun Wang wrote:
> The enhancement adds two extra items in the `getSubjectAlternativeNames()`
> output for an OtherName.
>
> It also fix several errors:
> 1. In `OtherName.java`, `nameValue` should be the value inside `CONTEXT [0]`
> without the tag and
On Thu, 10 Feb 2022 06:18:28 GMT, John Jiang wrote:
> In class sun.security.x509.X509CRLImpl, method getExtension(ObjectIdentifier)
> doesn't declare that IOException would be thrown, so the @throws IOException
> doc should be removed.
This pull request has now been integrated.
Changeset:
19 matches
Mail list logo
