Re: [JDK 15] RFR 8239979: sun/security/tools/keytool/ExtOptionCamelCase.java is not run

2020-02-25 Thread Amy Lu
Removed othervm: http://cr.openjdk.java.net/~amlu/8239979/webrev.01/index.html Thanks, Amy On 2/26/20 11:02 AM, Rajan Halade wrote: Thanks Amy for the fix! Any reason for using othervm to run this test? Otherwise your fix looks good to me. Thanks, Rajan On Feb 25, 2020, at 6:48 PM, Amy

[JDK 15] RFR 8239979: sun/security/tools/keytool/ExtOptionCamelCase.java is not run

2020-02-25 Thread Amy Lu
sun/security/tools/keytool/ExtOptionCamelCase.java This is not a compile-only test, but due to the missed @run tag, test is not run. Please review the patch to fix this issue. The patch also fixed @modules. Test performs deep reflection setAccessible(true) on a non-public member, `open` adde

[11] RFR 8205673: Problem list RmiRegistrySslTest.java and RmiSslBootstrapTest.sh

2018-06-26 Thread Amy Lu
sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java Above two tests have been failing on all platforms (JDK-8205653) since JDK-8196584. Please review the patch to add these tests to ProblemList.txt until a full fix is developed.

Re: [10] RFR 8194959: Correct test tag to move bugid from @test to @bug

2018-01-12 Thread Amy Lu
Thank you Alan and Sundar for your quick review. Changes pushed. Thanks, Amy On 12/01/2018 4:51 PM, Alan Bateman wrote: On 12/01/2018 04:51, Amy Lu wrote: Please review this minor test-tag-only change to move bugid from @test to @bug bug: https://bugs.openjdk.java.net/browse/JDK-8194959

[10] RFR 8194959: Correct test tag to move bugid from @test to @bug

2018-01-11 Thread Amy Lu
Please review this minor test-tag-only change to move bugid from @test to @bug bug: https://bugs.openjdk.java.net/browse/JDK-8194959 webrev: http://cr.openjdk.java.net/~amlu/8194959/webrev.00/ Thanks, Amy

[10] RFR 8194666: ProblemList update for bugid associated with PreferredKey.java, ConcurrentHashMapTest and SSLSocketParametersTest.sh

2018-01-04 Thread Amy Lu
Please review this minor cleanup for test/jdk/ProblemList.txt on bugid that associated with tests. bug: https://bugs.openjdk.java.net/browse/JDK-8194666 webrev: http://cr.openjdk.java.net/~amlu/8194666/webrev.00/ Thanks, Amy --- old/test/jdk/ProblemList.txt2018-01-05 11:41:00.0

JDK 10 RFR of JDK-8183531: Wrong @modules in test/javax/net/ssl/ciphersuites/ECCurvesconstraints.java

2017-07-04 Thread Amy Lu
Please review the patch to fix the typo in @modules for test javax/net/ssl/ciphersuites/ECCurvesconstraints.java bug: https://bugs.openjdk.java.net/browse/JDK-8183531 webrev: http://cr.openjdk.java.net/~amlu/8183531/webrev.00/ Thanks, Amy --- old/test/javax/net/ssl/ciphersuites/ECCurvesconstrai

Re: JDK 9 RFR of JDK-8177638: com/sun/jarsigner, jdk/internal/loader (and more) are missed in TEST.group

2017-03-28 Thread Amy Lu
Ping ~ On 3/27/17 1:12 PM, Amy Lu wrote: Sure. Moved to jdk_security3. webrev updated: http://cr.openjdk.java.net/~amlu/8177638/webrev.00/ Thanks, Amy On 3/27/17 11:25 AM, Weijun Wang wrote: The com/sun/jarsigner line should be added to jdk_security3. Roughly, the categories mean: 1

Re: JDK 9 RFR of JDK-8177638: com/sun/jarsigner, jdk/internal/loader (and more) are missed in TEST.group

2017-03-26 Thread Amy Lu
private APIs 4: JGSS/krb5 Thanks Max On 03/27/2017 11:06 AM, Amy Lu wrote: jdk/internal/loader jdk/internal/util com/sun/jarsigner jdk/internal/agent Somehow these are missed in TEST.group. Please review this patch to update TEST.group Tested on all platforms, TestVersionedStream.java fails on

JDK 9 RFR of JDK-8177638: com/sun/jarsigner, jdk/internal/loader (and more) are missed in TEST.group

2017-03-26 Thread Amy Lu
jdk/internal/loader jdk/internal/util com/sun/jarsigner jdk/internal/agent Somehow these are missed in TEST.group. Please review this patch to update TEST.group Tested on all platforms, TestVersionedStream.java fails on Windows, put it in ProblemList.txt for now. bug: https://bugs.openjdk.ja

Re: RFR 8176296: Test sun/security/krb5/auto/Basic.java faling after adding module declaration into TEST.properties.

2017-03-14 Thread Amy Lu
u won't be able to manipulate it from outside. Thanks Max On 03/14/2017 12:02 PM, Amy Lu wrote: I looked at the new test: BasicLimited.java This test will fail if "jdk.security.jgss" is specified from jtreg javaoptions: jtreg ... -javaoptions:"--limit-modules java.s

Re: RFR 8176296: Test sun/security/krb5/auto/Basic.java faling after adding module declaration into TEST.properties.

2017-03-13 Thread Amy Lu
I looked at the new test: BasicLimited.java This test will fail if "jdk.security.jgss" is specified from jtreg javaoptions: jtreg ... -javaoptions:"--limit-modules java.security.jgss,jdk.security.auth,jdk.security.jgss" jdk9/test/sun/security/krb5/auto/BasicLimited.java Thanks, Amy On 3/14/

Re: RFR 8176715: sun/security/krb5/auto/HttpNegotiateServer.java does not compile

2017-03-13 Thread Amy Lu
Looks good. (I'm not a reviewer) Thanks, Amy On 3/14/17 11:38 AM, Weijun Wang wrote: Please review the patch below: diff --git a/test/sun/security/krb5/auto/HttpNegotiateServer.java b/test/sun/security/krb5/auto/HttpNegotiateServer.java --- a/test/sun/security/krb5/auto/HttpNegotiateServer.

Re: JDK 9 RFR of JDK-8176182: 4 security tests are not run

2017-03-05 Thread Amy Lu
wrote: Hi Amy Change looks good. BTW, how did you notice this? Thanks Max On 03/06/2017 10:48 AM, Amy Lu wrote: sun/security/ec/SignedObjectChain.java sun/security/mscapi/SignedObjectChain.java sun/security/rsa/SignedObjectChain.java sun/security/ssl/rsa/SignedObjectChain.java These tests are

JDK 9 RFR of JDK-8176182: 4 security tests are not run

2017-03-05 Thread Amy Lu
sun/security/ec/SignedObjectChain.java sun/security/mscapi/SignedObjectChain.java sun/security/rsa/SignedObjectChain.java sun/security/ssl/rsa/SignedObjectChain.java These tests are not compile-only tests, but due to the missed @run tag, tests are not run. Please review the patch to add @run t

JDK 9 RFR of JDK-8174887: Problem list javax/net/ssl/DTLS/RespondToRetransmit.java

2017-02-13 Thread Amy Lu
javax/net/ssl/DTLS/RespondToRetransmit.java This test has been observed to fail intermittently with relatively high frequency at macosx (JDK-8169086). Until issue resolved, test should be problem listed for this platform. Also please note that issue originally reported in JDK-8170492. JDK-81

Re: RFR 8168374: TsacertOptionTest.java fails on all platforms

2016-10-19 Thread Amy Lu
Looks good. Thank you for the quick fix! (I'm not an official reviewer.) Thanks, Amy On 10/20/16 12:21 PM, Wang Weijun wrote: Please review this test change: diff --git a/test/sun/security/tools/jarsigner/TsacertOptionTest.java b/test/sun/security/tools/jarsigner/TsacertOptionTest.java --- a

JDK 9 RFR of JDK-8160658: sun/security/tools/keytool/standard.sh fails on all platforms after JDK-8160415

2016-06-30 Thread Amy Lu
Please review this simple and urgent fix for the regression introduced by JDK-8160415. In this patch, an empty line added after the @key line (that introduced in JDK-8160415) and before the comment lines to avoid comments to be read as "key" values. bug: https://bugs.openjdk.java.net/browse/

JDK 9 RFR of JDK-8153695: Problem list sun/security/pkcs11/Provider/Login.sh for linux-all

2016-04-06 Thread Amy Lu
sun/security/pkcs11/Provider/Login.sh This test is known to fail at Linux platform (JDK-8153545). Please review the patch to put the test to ProblemList.txt for linux-all until mentioned issue (JDK-8153545) is resolved. Tested with jtreg -listtests bug: https://bugs.openjdk.java.net/browse/JDK

JDK 9 RFR of JDK-8149922: Remove intermittent key from security tests

2016-02-17 Thread Amy Lu
sun/security/mscapi/ShortRSAKey1024.sh sun/security/mscapi/SignUsingSHA2withRSA.sh javax/net/ssl/SSLSession/SessionCacheSizeTests.java For above tests, previous intermittent test failure issues are fixed, no open bug (no failure reported). This patch is to remove @key intermittent from tests.

Re: Code Review Request, 8136410 AlgorithmDecomposer is not parsing padding correctly

2015-12-07 Thread Amy Lu
On 12/7/15 8:35 PM, Xuelei Fan wrote: On 12/7/2015 8:23 PM, Amy Lu wrote: Hi, Xuelei test/sun/security/util/AlgorithmConstraints/Decomposealgorithms.java line36 private final static String PATH = System.getProperty("test.src", "."); It seems that this line coul

Re: Code Review Request, 8136410 AlgorithmDecomposer is not parsing padding correctly

2015-12-07 Thread Amy Lu
Hi, Xuelei test/sun/security/util/AlgorithmConstraints/Decomposealgorithms.java line36 private final static String PATH = System.getProperty("test.src", "."); It seems that this line could be removed. Thanks, Amy On 12/7/15 7:08 PM, Xuelei Fan wrote: Hi Brad, Please review this fix

Re: RFR [9] 8144480: Remove test dependencies on sun.misc.BASE64Encoder and BASE64Decoder

2015-12-02 Thread Amy Lu
(I'm not a reviewer) Just a minor question. jdk/test/sun/misc/Encode/GetBytes.java also use sun.misc.BASE64Encoder and BASE64Decoder, but is not included in this fix. Missed? or justbecause this test will be totally removed soon in a separate bugid? Thanks, Amy On 12/2/15 11:03 PM, Chris He

Re: JDK 9 RFR of JDK-8078334: Mark regression tests using randomness

2015-04-22 Thread Amy Lu
On 4/22/15 4:31 PM, Daniel Fuchs wrote: On 22/04/15 04:13, Joseph D. Darcy wrote: One goal of marking the tests using randomness is to help root out some remaining intermittent test failures. If one of the randomness tests is observed to fail intermittently, if it has not already been updated to