Re: RFR: JDK-6676643: Improve current C_GetAttributeValue native implementation

2021-04-27 Thread Greg Rubin
On Tue, 27 Apr 2021 02:41:12 GMT, Valerie Peng wrote: > Anyone can help review this somewhat trivial fix? The main change is inside > src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_objmgmt.c. This is to > help better troubleshooting by reporting the type of unavailable attributes > in

Re: RFR: JDK-6676643: Improve current C_GetAttributeValue native implementation

2021-04-27 Thread Greg Rubin
On Tue, 27 Apr 2021 18:36:28 GMT, Valerie Peng wrote: >> src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_objmgmt.c line 252: >> >>> 250: >>> 251: if (rv != CKR_OK) { >>> 252: if (rv == CKR_ATTRIBUTE_SENSITIVE || rv == >>> CKR_ATTRIBUTE_TYPE_INVALID) { >> >> According to the

Re: RFR: JDK-6676643: Improve current C_GetAttributeValue native implementation

2021-04-27 Thread Greg Rubin
On Tue, 27 Apr 2021 04:28:26 GMT, Greg Rubin wrote: >> Anyone can help review this somewhat trivial fix? The main change is inside >> src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_objmgmt.c. This is to >> help better troubleshooting by reporting the type of unav

Re: RFR: JDK-6676643: Improve current C_GetAttributeValue native implementation

2021-04-26 Thread Greg Rubin
On Tue, 27 Apr 2021 02:41:12 GMT, Valerie Peng wrote: > Anyone can help review this somewhat trivial fix? The main change is inside > src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_objmgmt.c. This is to > help better troubleshooting by reporting the type of unavailable attributes > in

Re: RFR: 8248268: Support KWP in addition to KW [v4]

2021-04-07 Thread Greg Rubin
ies the default encodings for keys wrapped by this algorithm.") Greg On Wed, Apr 7, 2021 at 11:51 AM Michael StJohns wrote: > *sigh* Minor correction in line. > > On 4/7/2021 2:49 PM, Michael StJohns wrote: > > On 4/7/2021 1:28 PM, Greg Rubin wrote: > > Mike, > > Yes

Re: RFR: 8248268: Support KWP in addition to KW [v4]

2021-04-07 Thread Greg Rubin
than a strong objection based on specific concerns or risks. Thank you, Greg On Sat, Apr 3, 2021 at 4:38 PM Michael StJohns wrote: > On 4/3/2021 11:35 AM, Greg Rubin wrote: > > I'd advise against the AutoPadding scheme without more careful analysis > and discussion. Have we

Re: RFR: 8248268: Support KWP in addition to KW [v4]

2021-04-03 Thread Greg Rubin
On Sat, 27 Mar 2021 00:25:09 GMT, Valerie Peng wrote: >> This change updates SunJCE provider as below: >> - updated existing AESWrap support with AES/KW/NoPadding cipher >> transformation. >> - added support for AES/KWP/NoPadding and AES/KW/PKCS5Padding. >> >> Existing AESWrap impl, i.e.

Re: RFR: 8263404: RsaPrivateKeySpec is always recognized as RSAPrivateCrtKeySpec in RSAKeyFactory.engineGetKeySpec [v6]

2021-03-24 Thread Greg Rubin
On Wed, 24 Mar 2021 22:35:13 GMT, Valerie Peng wrote: >> Ziyi Luo has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Remove trailing whitespace >> - Refactor P11RSAKeyFactory and improve tests > >

Re: RFR: 8263404: RsaPrivateKeySpec is always recognized as RSAPrivateCrtKeySpec in RSAKeyFactory.engineGetKeySpec [v6]

2021-03-24 Thread Greg Rubin
On Wed, 24 Mar 2021 22:17:56 GMT, Valerie Peng wrote: >> Ziyi Luo has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Remove trailing whitespace >> - Refactor P11RSAKeyFactory and improve tests > >

Re: RFR: 8248268: Support KWP in addition to KW [v3]

2021-03-23 Thread Greg Rubin
On Mon, 22 Mar 2021 21:43:31 GMT, Valerie Peng wrote: >> This change updates SunJCE provider as below: >> - updated existing AESWrap support with AES/KW/NoPadding cipher >> transformation. >> - added support for AES/KWP/NoPadding and AES/KW/PKCS5Padding. >> >> Existing AESWrap impl, i.e.