On Wed, 24 Mar 2021 22:17:56 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Ziyi Luo has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Remove trailing whitespace >> - Refactor P11RSAKeyFactory and improve tests > > test/jdk/sun/security/pkcs11/rsa/TestP11KeyFactoryGetRSAKeySpec.java line 91: > >> 89: if (testingSensitiveKeys) { >> 90: // Expected exception so swallow it >> 91: ex.printStackTrace(); > > Add a System.out.println() to clarify that this exception stack trace is > expected? Putting it in `System.err.println()` so that it goes to the same output as the stack trace. ------------- PR: https://git.openjdk.java.net/jdk/pull/2949