Re: RFR: 8282077: PKCS11 provider C_sign() impl should handle CKR_BUFFER_TOO_SMALL error [v2]

On Sat, 19 Feb 2022 00:07:34 GMT, Valerie Peng wrote: >> Could someone please help review this trivial change? This is to add an >> error handling for the potential CKR_BUFFER_TOO_SMALL error when calling >> C_Sign(). Since none of the supported signature algorithms trigger this >> error as

Re: RFR: 8282077: PKCS11 provider C_sign() impl should handle CKR_BUFFER_TOO_SMALL error

On Fri, 18 Feb 2022 21:52:59 GMT, Valerie Peng wrote: > Could someone please help review this trivial change? This is to add an error > handling for the potential CKR_BUFFER_TOO_SMALL error when calling C_Sign(). > Since none of the supported signature algorithms trigger this error as the >

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

On Wed, 3 Feb 2021 20:08:28 GMT, Mikael Vidstedt wrote: >>> I wonder if this is the right choice >>> ... >>> ``` >>> OopStorageParIterPerf::~OopStorageParIterPerf() { >>> ... >>> ``` >>> >> >> The transition in OopSt

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

On Wed, 3 Feb 2021 20:05:29 GMT, Anton Kozlov wrote: >> Thank you all for your comments regarding W^X implementation. I've made a >> change that reduces the footprint of the implementation, also addressing >> most of the comments. I'll revisit them individually to make sure nothing is >>

RFR(T): 8248044: Backout ProblemList-ed tests introduced by JDK-8247876

Please review this trivial change which reenables the tests which were problem listed because of a linux-aarch64 machine configuration issue which has since been fixed: Note: I intend to push this to jdk15. JBS: https://bugs.openjdk.java.net/browse/JDK-8248044 webrev:

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (security)

t 8:54 PM, Mikael Vidstedt > wrote: > > > New webrev: > > webrev: > http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.02/security/open/webrev/ > incremental: > http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.02/security.incr/open/webrev/ > &g

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (security)

/share/classes/sun/security/pkcs11/Config.java Cheers, Mikael > On May 6, 2020, at 10:05 PM, Mikael Vidstedt > wrote: > > > New webrev here: > > webrev: > http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.01/security/open/webrev/ > incremental: > http

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (security)

for verifying! I’ll revert the removal of the test/jdk/sun/security/pkcs11/Config/ files and send out a new webrev in a minute! Cheers, Mikael > > Thanks, > Valerie > On 5/5/2020 4:17 PM, Mikael Vidstedt wrote: >> John, >> >> Thanks for the review! Comments/qu

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (security)

Will generate a new webrev shortly, meanwhile some comments inline.. > On May 7, 2020, at 1:02 AM, Weijun Wang wrote: > > > >> On May 7, 2020, at 1:05 PM, Mikael Vidstedt >> wrote: >> >> >> New webrev here: >> >> webrev: >>

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (security)

/PrincipalExpansionError.java * Get confirmation on what to do about the "(secret == null)” block in test/jdk/sun/security/pkcs11/tls/TestPRF.java Cheers, Mikael > On May 3, 2020, at 10:12 PM, Mikael Vidstedt > wrote: > > > Please review this change which implements part

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (security)

> On May 5, 2020, at 7:29 PM, Weijun Wang wrote: > > > >> On May 6, 2020, at 6:51 AM, Mikael Vidstedt >> wrote: >> >> >> Max, >> >> Thank you so much for the thorough review! I’m working on an incremental >> webrev but could

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (security)

continue; > 121 } > Could remove this block? Good question - the comment certainly makes it sound Solaris specific, but could be a stale comment.. Cheers, Mikael > > On 2020/5/4 13:12, Mikael Vidstedt wrote: >> Please review this change which imple

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (security)

> test/jdk/sun/security/tools/keytool/fakegen/PSS.java: > > Please also remove the comment on lines 35-37. Fixed. > test/jdk/sun/security/tools/keytool/fakegen/DefaultSignatureAlgorithm.java: > > Please also remove the comment on lines 36-38. Fixed. Cheers, Mikael > >

RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (security)

Please review this change which implements part of JEP 381: JBS: https://bugs.openjdk.java.net/browse/JDK-8244224 webrev: http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.00/security/open/webrev/ JEP: https://bugs.openjdk.java.net/browse/JDK-8241787 Note: When reviewing this, please

Re: RFR(XS): 8210912: Build error in src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_convert.c after JDK-8029661

Thank you! Change pushed and noreg-build label added. Cheers, Mikael > On Sep 19, 2018, at 9:13 AM, Sean Mullan wrote: > > Looks ok to me. The bug needs an appropriate noreg label. > > --Sean > > On 9/19/18 12:05 PM, Mikael Vidstedt wrote: >> Please review this c

RFR(XS): 8210912: Build error in src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_convert.c after JDK-8029661

Please review this change which fixes a Solaris/SPARC build issue: bug: https://bugs.openjdk.java.net/browse/JDK-8210912 webrev: http://cr.openjdk.java.net/~mikael/webrevs/8210912/webrev.00/open/webrev/

RFR JDK-8202060: Add javax/net/ssl/DTLS/CipherSuite.java to ProblemList

Please review this change which adds javax/net/ssl/DTLS/CipherSuite.java to the ProblemList until https://bugs.openjdk.java.net/browse/JDK-8202059 is fixed. Bug: https://bugs.openjdk.java.net/browse/JDK-8202060

Re: 8034856/8034857: More gcc warnings

Alan, I made the change to JarFacade.c myself last week, only to then see the comment a few lines above where you added the new include. It seems to indicate that including ctype.h on Solaris/SPARC is a bad idea. I have no idea if the comment is still relevant, but that may be worth

Re: 8034856/8034857: More gcc warnings

On 2014-02-13 10:23, Alan Bateman wrote: On 13/02/2014 17:56, Mikael Vidstedt wrote: Alan, I made the change to JarFacade.c myself last week, only to then see the comment a few lines above where you added the new include. It seems to indicate that including ctype.h on Solaris/SPARC is a bad