On Tue, 22 Jun 2021 10:56:00 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the
> `java.security` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
This pull request has now been integrated.
> Hi,
>
> Could someone please review my code for updating the code in the
> `java.security` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a rebase. T
Hi,
Could someone please review my code for updating the code in the
`java.security` packages to make use of the switch expressions?
Kind regards,
Patrick
-
Commit messages:
- Merge remote-tracking branch 'origin/master' into JDK-8268967
- 8268967: Update java.security to use
On Tue, 25 May 2021 06:01:49 GMT, Tagir F. Valeev wrote:
>> Inspired by PR#4088. Most of the changes are done automatically using
>> IntelliJ IDEA refactoring. Some manual adjustments are also performed,
>> including indentations, moving comments, extracting common cast out of
>> switch
On Tue, 18 May 2021 10:37:21 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.util`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
This pull request has now been i
> Hi,
>
> Could someone please review my code for updating the code in the `java.util`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a re
> Hi,
>
> Could someone please review my code for updating the code in the `java.util`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request incrementally with one
additional commit si
> Hi,
>
> Could someone please review my code for updating the code in the `java.util`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a re
> Hi,
>
> Could someone please review my code for updating the code in the `java.util`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a re
Hi,
Could someone please review my code for updating the code in the `java.util`
package to make use of the `instanceof` pattern variable?
Kind regards,
Patrick
-
Commit messages:
- 8267110: Update java.util to use instanceof pattern variable
Changes:
On Mon, 26 Apr 2021 08:50:36 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the
> `java.security` package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
This pull request has now been i
On Mon, 26 Apr 2021 17:52:05 GMT, Jesper Steen Møller
wrote:
> Changes look good, except for the unneeded parenthesis?
>
> (but I'm not a committer, so it's less useful)
Hi Jesper, thanks for your suggestions and well spotted. I've addressed the
issues and responded to your comments with the
On Tue, 27 Apr 2021 04:38:32 GMT, Punikekk
wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8265426: changed order of equals check; refactored Identity.equals method
>
> sr
On Thu, 6 May 2021 13:41:04 GMT, Weijun Wang wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8265426: Reverted parameter names; removed redundant parenthesis
>
> src/java.base/sh
> Hi,
>
> Could someone please review my code for updating the code in the
> `java.security` package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request incrementally with one
additional commit si
> Hi,
>
> Could someone please review my code for updating the code in the
> `java.security` package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a re
On Mon, 26 Apr 2021 23:24:41 GMT, Weijun Wang wrote:
> Two comments:
>
> 1. Why not reuse the existing variable name (Ex: `t` in `Type t =
> (Type)obj`) as much as possible to avoid unnecessary renames?
>
> 2. I'm not sure if modifying argument name in a public API is a good
> idea.
On Mon, 26 Apr 2021 17:03:52 GMT, Jesper Steen Møller
wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8265426: Reverted parameter names; removed redundant parenthesis
>
> sr
On Mon, 26 Apr 2021 18:14:21 GMT, Roger Riggs wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8265426: Reverted parameter names; removed redundant parenthesis
>
> src/java.ba
> Hi,
>
> Could someone please review my code for updating the code in the
> `java.security` package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request incrementally with one
additional commit si
> Hi,
>
> Could someone please review my code for updating the code in the
> `java.security` package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a re
Hi,
Could someone please review my code for updating the code in the
`java.security` package to make use of the `instanceof` pattern variable?
Kind regards,
Patrick
-
Commit messages:
- 8265426: Update java.security to use instanceof pattern variable
Changes:
On Mon, 8 Mar 2021 18:48:30 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.io`,
> `java.math`, and `java.text` packages to make use of the `instanceof` pattern
> variable?
>
> Kind regards,
> Patrick
T
Hi,
Could someone please review my code for updating the code in the `java.io`,
`java.math`, and `java.text` packages to make use of the `instanceof` pattern
variable?
Kind regards,
Patrick
-
Commit messages:
- 8263190: Update java.io, java.math, and java.text to use instanceof
On Fri, 4 Dec 2020 11:22:34 GMT, Kartik Ohri
wrote:
> @pconcannon, If everything is in order, can you please approve the changes on
> Github. I'll then issue the integrate command. Thanks.
Hi @amCap1712, you will have to /integrate first, and then afterwards I will
sponsor
-
On Wed, 2 Dec 2020 16:28:44 GMT, Kartik Ohri
wrote:
>> src/java.net.http/share/classes/jdk/internal/net/http/Http1HeaderParser.java
>> line 119:
>>
>>> 117: while (canContinueParsing(input)) {
>>> 118: switch (state) {
>>> 119: case INITIAL ->
On Wed, 2 Dec 2020 09:42:09 GMT, Kartik Ohri
wrote:
>> Hi!
>> Kindly review this patch to replace switch statements with switch
>> expressions (where it makes sense) in the http client modules. The rationale
>> is to improve readability of the code.
>> Regards,
>> Kartik
>
> Kartik Ohri has
On Mon, 30 Nov 2020 13:04:11 GMT, Kartik Ohri
wrote:
>> Hi!
>> Kindly review this patch to replace switch statements with switch
>> expressions (where it makes sense) in the http client modules. The rationale
>> is to improve readability of the code.
>> Regards,
>> Kartik
>
> Kartik Ohri has
28 matches
Mail list logo
