[security-dev 01757]: hg: jdk7/tl/jdk: 6921111: NullPointerException in PlainDatagramSocketImpl.socketSetOption

2010-04-06 Thread christopher . hegarty
Changeset: 495ba30cf02f Author:chegar Date: 2010-04-06 15:44 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/495ba30cf02f 692: NullPointerException in PlainDatagramSocketImpl.socketSetOption Reviewed-by: alanb ! src/solaris/native/java/net/PlainDatagramSocketImpl.c !

[security-dev 01739]: hg: jdk7/tl/jdk: 6937703: java/net regression test issues with samevm

2010-03-25 Thread christopher . hegarty
Changeset: 6109b166bf68 Author:chegar Date: 2010-03-25 09:38 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6109b166bf68 6937703: java/net regression test issues with samevm Reviewed-by: alanb ! test/ProblemList.txt ! test/java/net/ProxySelector/B6737819.java !

[security-dev 01733]: hg: jdk7/tl/jdk: 6614957: HttpsURLConnection not using the set SSLSocketFactory for creating all its Sockets; ...

2010-03-23 Thread christopher . hegarty
Changeset: 8a9ebdc27045 Author:chegar Date: 2010-03-23 13:54 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8a9ebdc27045 6614957: HttpsURLConnection not using the set SSLSocketFactory for creating all its Sockets 6771432: createSocket() - smpatch fails using 1.6.0_10

[security-dev 01722]: hg: jdk7/tl/jdk: 6935233: java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java fails with modules build

2010-03-19 Thread christopher . hegarty
Changeset: 3bb93c410f41 Author:chegar Date: 2010-03-19 13:07 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3bb93c410f41 6935233: java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java fails with modules build Reviewed-by: alanb ! test/ProblemList.txt !

[security-dev 01695]: Re: Please review new regression test for java.net.* API

2010-03-18 Thread Christopher Hegarty -Sun Microsystems Ireland
Alan Bateman wrote: Pavel Tisnovsky wrote: Hi, please review new regression test for java.net.* API. This test check if the cacerts keytool database is configured properly and SSL is really working. The test should not fail if SSL is working (in other case it simply throws IOException).

[security-dev 01699]: Re: Please review new regression test for java.net.* API

2010-03-18 Thread Christopher Hegarty -Sun Microsystems Ireland
Pavel Tisnovsky wrote: Christopher Hegarty -Sun Microsystems Ireland wrote: Alan Bateman wrote: Pavel Tisnovsky wrote: Hi, please review new regression test for java.net.* API. This test check if the cacerts keytool database is configured properly and SSL is really working. The test should

[security-dev 01703]: Re: Please review new regression test for java.net.* API

2010-03-18 Thread Christopher Hegarty -Sun Microsystems Ireland
Sean Mullan wrote: Security folk: Do we currently have any tests with a dependency on cacerts? yes, but they would be in the closed tests. So we have your own non public tests for this. Maybe RedHat should take a similar approach then. -Chris. --Sean

[security-dev 01709]: Re: Please review new regression test for java.net.* API

2010-03-18 Thread Christopher Hegarty -Sun Microsystems Ireland
URL to hit. It's the very URL that causes the OpenJDK build to fail to bootstrap itself and I assume Oracle do control dev.java.net to some degree. Brad On 3/18/2010 8:50 AM, Pavel Tisnovsky wrote: Christopher Hegarty -Sun Microsystems Ireland wrote: Alan Bateman wrote: Pavel Tisnovsky

[security-dev 01711]: Re: Please review new regression test for java.net.* API

2010-03-18 Thread Christopher Hegarty -Sun Microsystems Ireland
Andrew John Hughes wrote: On 18 March 2010 20:56, Christopher Hegarty -Sun Microsystems Ireland christopher.hega...@sun.com wrote: Brad, Pavel, Andrew, I'm also not comfortable with this test, but what bothers me more than the reliance on an external server is the reliance on cacerts. While

[security-dev 01691]: hg: jdk7/tl/jdk: 6934923: test/java/net/ipv6tests/TcpTest.java hangs on Solaris 10

2010-03-16 Thread christopher . hegarty
Changeset: f88f6f8ddd21 Author:chegar Date: 2010-03-16 10:05 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f88f6f8ddd21 6934923: test/java/net/ipv6tests/TcpTest.java hangs on Solaris 10 Reviewed-by: alanb ! test/java/net/ipv6tests/TcpTest.java !

[security-dev 01692]: hg: jdk7/tl/jdk: 6935199: java/net regression tests failing with Assertions

2010-03-16 Thread christopher . hegarty
Changeset: 895a1211b2e1 Author:chegar Date: 2010-03-16 14:31 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/895a1211b2e1 6935199: java/net regression tests failing with Assertions Reviewed-by: michaelm ! test/ProblemList.txt ! test/java/net/CookieHandler/TestHttpCookie.java

[security-dev 01684]: hg: jdk7/tl/jdk: 6933629: java/net/HttpURLConnection/HttpResponseCode.java fails if run in samevm mode

2010-03-11 Thread christopher . hegarty
Changeset: c342735a3e58 Author:chegar Date: 2010-03-11 17:37 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c342735a3e58 6933629: java/net/HttpURLConnection/HttpResponseCode.java fails if run in samevm mode Reviewed-by: alanb ! test/ProblemList.txt !

[security-dev 01685]: hg: jdk7/tl/jdk: 6223635: Code hangs at connect call even when Timeout is specified when using a socks proxy

2010-03-11 Thread christopher . hegarty
Changeset: c6f8c58ed51a Author:chegar Date: 2010-03-11 17:50 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c6f8c58ed51a 6223635: Code hangs at connect call even when Timeout is specified when using a socks proxy Reviewed-by: michaelm, chegar Contributed-by:

[security-dev 01680]: hg: jdk7/tl/jdk: 6933618: java/net/MulticastSocket/NoLoopbackPackets.java fails when rerun

2010-03-10 Thread christopher . hegarty
Changeset: 47958f76babc Author:chegar Date: 2010-03-10 14:44 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/47958f76babc 6933618: java/net/MulticastSocket/NoLoopbackPackets.java fails when rerun Reviewed-by: alanb ! test/java/net/MulticastSocket/NoLoopbackPackets.java

[security-dev 01611]: hg: jdk7/tl/jdk: 6693244: Java Web Start app fails on 6u10 beta w/ AssertionError in AuthenticationInfo.requestCompleted

2010-02-10 Thread christopher . hegarty
Changeset: ec438f2b6886 Author:chegar Date: 2010-02-10 13:23 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ec438f2b6886 6693244: Java Web Start app fails on 6u10 beta w/ AssertionError in AuthenticationInfo.requestCompleted Reviewed-by: michaelm !

[security-dev 01565]: hg: jdk7/tl/jdk: 6905552: libnet/nio portability issues

2010-01-27 Thread christopher . hegarty
Changeset: 8df0ffac7f4d Author:chegar Date: 2010-01-27 16:11 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8df0ffac7f4d 6905552: libnet/nio portability issues Reviewed-by: alanb ! src/share/native/java/net/net_util.c ! src/solaris/native/java/net/Inet4AddressImpl.c !

[security-dev 01558]: hg: jdk7/tl/jdk: 6707289: InterfaceAddress.getNetworkPrefixLength() does not conform to Javadoc

2010-01-25 Thread christopher . hegarty
Changeset: e67bf9abc6a5 Author:chegar Date: 2010-01-25 15:41 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e67bf9abc6a5 6707289: InterfaceAddress.getNetworkPrefixLength() does not conform to Javadoc Reviewed-by: michaelm !

[security-dev 01529]: hg: jdk7/tl/jdk: 6916890: (sctp) SctpChannel.send may cause IAE if given a heap buffer with an offset

2010-01-18 Thread christopher . hegarty
Changeset: 680d7d312a30 Author:chegar Date: 2010-01-18 14:01 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/680d7d312a30 6916890: (sctp) SctpChannel.send may cause IAE if given a heap buffer with an offset Reviewed-by: alanb !

[security-dev 01530]: hg: jdk7/tl/jdk: 6917317: (sctp) Remove dependency on handleSocketError

2010-01-18 Thread christopher . hegarty
Changeset: e0870a19b09e Author:chegar Date: 2010-01-18 14:56 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e0870a19b09e 6917317: (sctp) Remove dependency on handleSocketError Reviewed-by: alanb ! src/solaris/native/sun/nio/ch/SctpNet.c !

[security-dev 01505]: hg: jdk7/tl/jdk: 6915313: Reorganize implementation to make it more feasible to port to JDK6

2010-01-11 Thread christopher . hegarty
Changeset: fc5578368a0c Author:chegar Date: 2010-01-11 16:04 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fc5578368a0c 6915313: Reorganize implementation to make it more feasible to port to JDK6 Summary: This makes the SCTP implementation easier to run with Suns JDK6.

[security-dev 01338]: hg: jdk7/tl/jdk: 6894169: Move HttpLogFormatter into a separate package

2009-10-22 Thread christopher . hegarty
Changeset: 93f8d9494e05 Author:chegar Date: 2009-10-22 15:44 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/93f8d9494e05 6894169: Move HttpLogFormatter into a separate package Reviewed-by: alanb ! make/sun/net/FILES_java.gmk -

[security-dev 01058]: hg: jdk7/tl/jdk: 2 new changesets

2009-08-07 Thread christopher . hegarty
Changeset: 0d99696fec64 Author:chegar Date: 2009-08-07 10:50 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0d99696fec64 6826780: URLClassPath should use HashMapString, XXX instead of HashMapURL, XXX Summary: Replace URL with a String representation. Reviewed-by: michaelm,

[security-dev 01002]: hg: jdk7/tl/jdk: 6863110: Newly connected/accepted SctpChannel should fire OP_READ if registered with a Selector

2009-07-23 Thread christopher . hegarty
Changeset: 645c1d0b9db9 Author:chegar Date: 2009-07-23 14:06 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/645c1d0b9db9 6863110: Newly connected/accepted SctpChannel should fire OP_READ if registered with a Selector Reviewed-by: jccollet !

[security-dev 00937]: hg: jdk7/tl/jdk: 6855335: Several changes in the SCTP implementation.

2009-06-29 Thread christopher . hegarty
Changeset: a44009aba19f Author:chegar Date: 2009-06-29 14:53 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a44009aba19f 6855335: Several changes in the SCTP implementation. Reviewed-by: michaelm ! make/com/sun/nio/sctp/mapfile-vers !

[security-dev 00757]: Re: Code review request: Undefined requesting URL in java.net.Authenticator.getPasswordAuthentication()

2009-04-16 Thread Christopher Hegarty - Sun Microsystems Ireland
, 2009, at 8:55 PM, Max (Weijun) Wang wrote: On Apr 14, 2009, at 5:59 PM, Christopher Hegarty - Sun Microsystems Ireland wrote: Hi Max, I only looked at the networking part of the changes. They look fine, I just have a few questions/comments: 1) sun.net.www.protocol.http.HttpURLConnection

[security-dev 00752]: Re: Code review request: Undefined requesting URL in java.net.Authenticator.getPasswordAuthentication()

2009-04-14 Thread Christopher Hegarty - Sun Microsystems Ireland
Hi Max, I only looked at the networking part of the changes. They look fine, I just have a few questions/comments: 1) sun.net.www.protocol.http.HttpURLConnection Can you use the same HttpCallerInfo instance for proxy authentication at line 1108? This instance has been created using the

[security-dev 00662]: hg: jdk7/tl/jdk: 6737323: Typo in javadoc for SocketPermission

2009-03-04 Thread christopher . hegarty
Changeset: 03001e92d155 Author:chegar Date: 2009-03-04 13:36 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/03001e92d155 6737323: Typo in javadoc for SocketPermission Summary: Remove redundant line form class description Reviewed-by: jccollet !

[security-dev 00494]: hg: jdk7/tl/jdk: 6755782: It is not clear how DatagramSocket deals with broadcast enabling/disabling

2009-01-14 Thread christopher . hegarty
Changeset: 8c1c6e11204b Author:chegar Date: 2009-01-14 17:17 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8c1c6e11204b 6755782: It is not clear how DatagramSocket deals with broadcast enabling/disabling Reviewed-by: jccollet !

[security-dev 00434]: hg: jdk7/tl/jdk: 6720866: Slow performance using HttpURLConnection for upload

2008-11-26 Thread christopher . hegarty
Changeset: a0709a172b6d Author:chegar Date: 2008-11-26 15:37 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a0709a172b6d 6720866: Slow performance using HttpURLConnection for upload Reviewed-by: michaelm ! src/share/classes/sun/net/www/http/ChunkedOutputStream.java

[security-dev 00401]: hg: jdk7/tl/jdk: 2 new changesets

2008-11-13 Thread christopher . hegarty
Changeset: a85ef87f9eaa Author:chegar Date: 2008-11-12 16:38 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a85ef87f9eaa 6755625: Add HttpURLConnection.setFixedLengthStreamingMode(long) Reviewed-by: jccollet !

[security-dev 00379]: hg: jdk7/tl/jdk: 6756771: com.sun.net.httpserver.HttpServer should handle POSTs larger than 2Gig

2008-10-28 Thread christopher . hegarty
Changeset: 98ac3d398ed6 Author:chegar Date: 2008-10-28 16:14 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/98ac3d398ed6 6756771: com.sun.net.httpserver.HttpServer should handle POSTs larger than 2Gig Summary: update implementation to use long instead of int Reviewed-by:

[security-dev 00332]: hg: jdk7/jsn/jdk: 6752807: java.net test ADatagramSocket.sh is broken

2008-09-26 Thread christopher . hegarty
Changeset: 8b0be0bc4b14 Author:chegar Date: 2008-09-26 11:24 +0100 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/8b0be0bc4b14 6752807: java.net test ADatagramSocket.sh is broken Summary: update bootclasspath set by test to simply prepend TESTCLASSES Reviewed-by: michaelm !

[security-dev 00328]: hg: jdk7/jsn/jdk: 6621697: Problem with file test/sun/net/www/http/ChunkedInputStream/test.txt

2008-09-24 Thread christopher . hegarty
Changeset: de7864ec310c Author:chegar Date: 2008-09-24 17:10 +0100 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/de7864ec310c 6621697: Problem with file test/sun/net/www/http/ChunkedInputStream/test.txt Reviewed-by: michaelm !

[security-dev 00255]: hg: jdk7/jsn/jdk: 6730740: Fix for 6729881 has apparently broken several 64 bit tests: Bad address

2008-07-29 Thread christopher . hegarty
Changeset: 441f88d39988 Author:chegar Date: 2008-07-29 09:53 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/441f88d39988 6730740: Fix for 6729881 has apparently broken several 64 bit tests: Bad address Reviewed-by: alanb, jccollet !

[security-dev 00241]: hg: jdk7/jsn/jdk: 6726164: jdk\src\windows\native\java\net\NetworkInterface.h(172) : error C2365: 'IpPrefixOriginOther' : redef

2008-07-19 Thread christopher . hegarty
Changeset: 3b8e5bfe2be7 Author:chegar Date: 2008-07-19 10:27 +0100 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/3b8e5bfe2be7 6726164: jdk\src\windows\native\java\net\NetworkInterface.h(172) : error C2365: 'IpPrefixOriginOther' : redef Summary: Change the NetworkInterface

[security-dev 00164]: hg: jdk7/jsn/jdk: 6687919: REGRESSION : Classloader can handle any resource which is not included in classpath

2008-05-02 Thread christopher . hegarty
Changeset: d95a6a4ea502 Author:chegar Date: 2008-05-02 21:33 +0100 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/d95a6a4ea502 6687919: REGRESSION : Classloader can handle any resource which is not included in classpath Reviewed-by: jccollet, alanb !

[security-dev 00092]: hg: jdk7/jsn/jdk: 6615656: Removed unimplemented java.net methods

2008-03-07 Thread christopher . hegarty
Changeset: 328415dfe347 Author:chegar Date: 2008-03-07 11:30 + URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/328415dfe347 6615656: Removed unimplemented java.net methods Reviewed-by: jccollet ! src/share/classes/java/net/AbstractPlainSocketImpl.java !