I'm afraid it's not worth to build such a automatic tool.
Different resource clients uses different resource classes which have
different resource items, so such a tool must understand which resource
client is using which resource class, which is not easy or even
possible. Or we can hard code
Great work! Thanks for going deep on this issue.
Is it possible to change your manual check into an automatic test? I know
sources might not be available when running a test, but if something like
${test.src}/../../../src/java.base/share/classes/sun/security/util/ exists it
can be a good hint t
I manually checked *Resources.java under sun/security and usage of them,
my investigation shows that overall quality of "static" resource usage
is good (by "static" I mean it uses hard code resource string like
rb.getString("") rather than rb.getString(aStringVariable) ), except
of this iss
On 2017/7/12 11:06, Weijun Wang wrote:
On Jul 12, 2017, at 11:03 AM, Hamlin Li wrote:
Hi Max,
On 2017/7/12 10:50, Weijun Wang wrote:
Change looks fine.
Please remember to add a noreg-trivial label.
Added the label, and will push the change.
Also, can you do some more investigation when t
> On Jul 12, 2017, at 11:03 AM, Hamlin Li wrote:
>
> Hi Max,
>
> On 2017/7/12 10:50, Weijun Wang wrote:
>> Change looks fine.
>>
>> Please remember to add a noreg-trivial label.
> Added the label, and will push the change.
>> Also, can you do some more investigation when this starts to happen?
Hi Max,
On 2017/7/12 10:50, Weijun Wang wrote:
Change looks fine.
Please remember to add a noreg-trivial label.
Added the label, and will push the change.
Also, can you do some more investigation when this starts to happen? The bug
says affected versions are 9 and 10 but PolicyFile.java has
Change looks fine.
Please remember to add a noreg-trivial label.
Also, can you do some more investigation when this starts to happen? The bug
says affected versions are 9 and 10 but PolicyFile.java has been there long
long ago. Was there a regression?
Thanks
Max
> On Jul 12, 2017, at 10:28 AM
Would you please review the below patch?
bug: https://bugs.openjdk.java.net/browse/JDK-8184165
webrev: http://cr.openjdk.java.net/~mli/8184165/webrev.00/
Thank you
-Hamlin
