On 2013-10-10 19:45, Sean Mullan wrote:
On 10/10/2013 05:57 AM, Erik Joelsson wrote:
Adding makefiles to make/tools is not needed for the new build. Either
remove those changes or make a complete port to the old build. I'm not
pushing for porting this to the old build at this point since missin
On 10/10/13 10:45 AM, Sean Mullan wrote:
On 10/10/2013 05:57 AM, Erik Joelsson wrote:
Adding makefiles to make/tools is not needed for the new build. Either
remove those changes or make a complete port to the old build. I'm not
pushing for porting this to the old build at this point since missin
On 10/10/2013 05:57 AM, Erik Joelsson wrote:
Adding makefiles to make/tools is not needed for the new build. Either
remove those changes or make a complete port to the old build. I'm not
pushing for porting this to the old build at this point since missing
this will not cause the old build to sto
On 2013-10-09 15:20, Sean Mullan wrote:
Finally do we still use make/tools/Makefile in the new build?
No, we don't. If you want to add old build support for this, you would
also need to add usage of the tool to the correct old makefile.
I don't think it's necessary to add this to the old bu
Adding makefiles to make/tools is not needed for the new build. Either
remove those changes or make a complete port to the old build. I'm not
pushing for porting this to the old build at this point since missing
this will not cause the old build to stop working, it will just diverge
the resulti
Hello,
While you discuss TWR hazards, be aware that closing a sink (OutputStream)
as part of a "finally" branch which hides exceptions is dangerous in some
I/O scenarios because hardware write errors could be delayed until the
close. NFS for example has this tendency, but also some virtual
On 10/9/2013 6:18 PM, David Holmes wrote:
cc'ing Joe Darcy. :)
Joe: there is a try-with-resources question for you below ...
On 9/10/2013 11:20 PM, Sean Mullan wrote:
On 10/09/2013 05:14 AM, Erik Joelsson wrote:
On 2013-10-09 06:33, David Holmes wrote:
In the tool this code doesn't show cor
cc'ing Joe Darcy. :)
Joe: there is a try-with-resources question for you below ...
On 9/10/2013 11:20 PM, Sean Mullan wrote:
On 10/09/2013 05:14 AM, Erik Joelsson wrote:
On 2013-10-09 06:33, David Holmes wrote:
In the tool this code doesn't show correct use of try-with-resources:
51
Updated webrev:
http://cr.openjdk.java.net/~mullan/webrevs/8007292/webrev.01/
Let me know if there are any more comments, otherwise I will plan to
push tomorrow.
Thanks,
Sean
On 10/09/2013 09:20 AM, Sean Mullan wrote:
On 10/09/2013 05:14 AM, Erik Joelsson wrote:
Hello Sean,
On 2013-10-09
On 10/09/2013 05:14 AM, Erik Joelsson wrote:
Hello Sean,
On 2013-10-09 06:33, David Holmes wrote:
Hi Sean,
Not a full review.
On 9/10/2013 5:52 AM, Sean Mullan wrote:
Please review the fix for the following bug:
https://bugs.openjdk.java.net/browse/JDK-8007292
This bug requires build ch
Hello Sean,
On 2013-10-09 06:33, David Holmes wrote:
Hi Sean,
Not a full review.
On 9/10/2013 5:52 AM, Sean Mullan wrote:
Please review the fix for the following bug:
https://bugs.openjdk.java.net/browse/JDK-8007292
This bug requires build changes and a new build tool to add additional
r
Hi Sean,
Not a full review.
On 9/10/2013 5:52 AM, Sean Mullan wrote:
Please review the fix for the following bug:
https://bugs.openjdk.java.net/browse/JDK-8007292
This bug requires build changes and a new build tool to add additional
restricted packages to the java.security file which are
Please review the fix for the following bug:
https://bugs.openjdk.java.net/browse/JDK-8007292
This bug requires build changes and a new build tool to add additional
restricted packages to the java.security file which are not part of
OpenJDK. These packages are only added when doing a build i
13 matches
Mail list logo
