Re: [9] RFR:JDK-8143305:sun/security/ec/TestEC.java fails intermittently

2016-06-03 Thread Sean Mullan
A small nit, but the debug field should be private (and final for good measure). I know this is just a test and it doesn't expose a security issue, but I think it is good practice to adhere to secure programming conventions even when writing tests. This field is only used within the test, so

Re: [9] RFR:JDK-8143305:sun/security/ec/TestEC.java fails intermittently

2016-06-03 Thread Xuelei Fan
Looks fine to me. Thanks, Xuelei On 6/3/2016 3:52 PM, Tim Du wrote: > Thanks Sean and Xuelei > > I filed new bug for adding debug option,see > https://bugs.openjdk.java.net/browse/JDK-8158620 > The codes were also updated follow Sean's suggestion at here: >

Re: [9] RFR:JDK-8143305:sun/security/ec/TestEC.java fails intermittently

2016-06-03 Thread Tim Du
Thanks Sean and Xuelei I filed new bug for adding debug option,see https://bugs.openjdk.java.net/browse/JDK-8158620 The codes were also updated follow Sean's suggestion at here: http://cr.openjdk.java.net/~tidu/8158620/webrev.00/ Please help to review again.Thanks. Regards Tim On 2016/6/3

Re: [9] RFR:JDK-8143305:sun/security/ec/TestEC.java fails intermittently

2016-06-02 Thread Sean Mullan
On 06/02/2016 06:16 AM, Tim Du wrote: Hi, Please help to review the path for JDK-8143305 TestEC.java test for ECC algorithms in SSL/TLS with different cipher suites. It failed with javax.net.ssl.SSLException: Unsupported or unrecognized SSL message intermittently. The exception was threw at

[9] RFR:JDK-8143305:sun/security/ec/TestEC.java fails intermittently

2016-06-02 Thread Tim Du
Hi, Please help to review the path for JDK-8143305 TestEC.java test for ECC algorithms in SSL/TLS with different cipher suites. It failed with javax.net.ssl.SSLException: Unsupported or unrecognized SSL message intermittently. The exception was threw at step of handshaking, I was not able