Right, it doesn't. I will update it.
Thanks,
Valerie
On 7/25/2016 8:49 AM, Sean Mullan wrote:
Does the test need to run in othervm? It doesn't seem like it adds or
changes the order of providers.
Otherwise looks good.
--Sean
On 07/22/2016 06:19 PM, Valerie Peng wrote:
I added a new tes
Does the test need to run in othervm? It doesn't seem like it adds or
changes the order of providers.
Otherwise looks good.
--Sean
On 07/22/2016 06:19 PM, Valerie Peng wrote:
I added a new test covering the basics of getInstance() methods.
Webrev updated: http://cr.openjdk.java.net/~valerie
I added a new test covering the basics of getInstance() methods.
Webrev updated: http://cr.openjdk.java.net/~valeriep/8159488/webrev.02
If you have a particular scenario that you want me to cover, please let
me know.
Thanks,
Valerie
On 7/21/2016 12:55 PM, Valerie Peng wrote:
Existing regre
Existing regression tests for the java.xml.crypto do test the
getInstance() methods as I observed during my own testing.
Maybe not all of them are covered though. I will double check and add
test if necessary...
Thanks,
Valerie
On 7/21/2016 12:08 PM, Sean Mullan wrote:
On 07/20/2016 07:
On 07/20/2016 07:57 PM, Valerie Peng wrote:
Sean,
I have updated webrev to rid the dependency on sun.security.jca
packages. Also, I found one additional SecurityPermission is needed.
Please find the updated webrev at:
http://cr.openjdk.java.net/~valeriep/8159488/webrev.01/
So, we should close
Sean,
I have updated webrev to rid the dependency on sun.security.jca
packages. Also, I found one additional SecurityPermission is needed.
Please find the updated webrev at:
http://cr.openjdk.java.net/~valeriep/8159488/webrev.01/
So, we should close JDK-8161710 as a duplicate of JDK-815948
On 07/18/2016 05:38 PM, Valerie Peng wrote:
Hi Sean,
I found these two classes in java.xml.crypto module reading local files:
src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/storage/implementations/CertsInFilesystemDirectoryResolver.java
src/java.xml.crypto/share
Hi Sean,
I found these two classes in java.xml.crypto module reading local files:
src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/storage/implementations/CertsInFilesystemDirectoryResolver.java
src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/secur
On 07/13/2016 08:10 PM, Valerie Peng wrote:
Sean,
Can you please review the following two webrevs?
Bug: https://bugs.openjdk.java.net/browse/JDK-8159488
Webrev: http://cr.openjdk.java.net/~valeriep/8159488/
Looks good except for this one:
127 // needed for reading Certs
128
Thanks, I will proceed integrating JDK-8161171 then.
Valerie
On 7/14/2016 12:59 AM, Mandy Chung wrote:
On Jul 14, 2016, at 8:10 AM, Valerie Peng wrote:
Sean,
Can you please review the following two webrevs?
Bug: https://bugs.openjdk.java.net/browse/JDK-8159488
Webrev: http://cr.openjdk.java
> On Jul 14, 2016, at 8:10 AM, Valerie Peng wrote:
>
> Sean,
>
> Can you please review the following two webrevs?
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8159488
> Webrev: http://cr.openjdk.java.net/~valeriep/8159488/
>
Update to Modules.gmk looks good.
> While making changes for
Sean,
Can you please review the following two webrevs?
Bug: https://bugs.openjdk.java.net/browse/JDK-8159488
Webrev: http://cr.openjdk.java.net/~valeriep/8159488/
While making changes for 8159488, I noticed a problem with my earlier
putback of 8154191 - the top level Modules.gmk was not integr
12 matches
Mail list logo