Thanks!
Regards,
Sean.
On 22 September 2016 00:40:15 GMT+01:00, Valerie Peng
wrote:
>Alright, I included the hex value of the version to the exception
>message.
>In addition, one of the regression test was using 0x400 as the version
>value and that has to be removed now that the version check
Looks fine to me.
Xuelei
On 9/22/2016 7:40 AM, Valerie Peng wrote:
Alright, I included the hex value of the version to the exception message.
In addition, one of the regression test was using 0x400 as the version
value and that has to be removed now that the version check has been
corrected.
ht
Alright, I included the hex value of the version to the exception message.
In addition, one of the regression test was using 0x400 as the version
value and that has to be removed now that the version check has been
corrected.
http://cr.openjdk.java.net/~valeriep/8136355/webrev.02/
Thanks,
Vale
Hey Valerie,
There are a few calls in this code where an exception is thrown if a bad
version is received. It's code that already existed, but would you mind
enhancing the exceptions to print the version while editing the code there ?
e.g. P11TlsKeyMaterialGenerator.java
+ throw n
Good catch, I have fixed all three and updated the webrev:
http://cr.openjdk.java.net/~valeriep/8136355/webrev.01
Thanks for the prompt review~
Valerie
On 9/20/2016 8:11 PM, Xuelei Fan wrote:
P11TlsKeyMaterialGenerator.java
102-106:
There is a bug in the previous code. "&&" should be replaced w
P11TlsKeyMaterialGenerator.java
102-106:
There is a bug in the previous code. "&&" should be replaced with "||".
- (version < 0x0300) && (version > 0x0302)
+ (version < 0x0300) || (version > 0x0302)
The other two have the same issues. Otherwise, looks fine to me.
BTW, if client request to n
Xuelei,
Could you please help reviewing this change?
There are quite a few test failures on Solaris 12 due to the removal of
Solaris PKCS11 SSL3 mechanisms which SunPKCS11 provider assume to be
always present. I updated relevant classes as well as regression tests
to skip SSL3 testing when th
