Thanks
于 2014/8/27 11:37, Wang Weijun 写道:
Done at http://hg.openjdk.java.net/jdk9/dev/jdk/rev/785858138c56.
--Max
On Aug 27, 2014, at 11:23, zaiyao liu wrote:
Hi Max,
Can you help to push this code for me?
Full comments:
8048617: Tests for PKCS12 read operations
Reviewed-by: weijun
Contrib
Done at http://hg.openjdk.java.net/jdk9/dev/jdk/rev/785858138c56.
--Max
On Aug 27, 2014, at 11:23, zaiyao liu wrote:
> Hi Max,
>
> Can you help to push this code for me?
>
> Full comments:
> 8048617: Tests for PKCS12 read operations
> Reviewed-by: weijun
> Contributed-by: Zaiyao Liu
>
> Tha
Hi Max,
Can you help to push this code for me?
Full comments:
8048617: Tests for PKCS12 read operations
Reviewed-by: weijun
Contributed-by: Zaiyao Liu
Thanks
Kevin
于 2014/8/27 11:18, Wang Weijun 写道:
Change looks fine.
Thanks
Max
On Aug 27, 2014, at 11:12, zaiyao liu wrote:
Hi Max,
Th
Change looks fine.
Thanks
Max
On Aug 27, 2014, at 11:12, zaiyao liu wrote:
> Hi Max,
>
> Thanks for catching that, please review again:
> http://cr.openjdk.java.net/~tyan/kevin/JDK-8048617/webrev02/
>
> Thanks
Hi Max,
Thanks for catching that, please review again:
http://cr.openjdk.java.net/~tyan/kevin/JDK-8048617/webrev02/
Thanks
Kevin
于 2014/8/25 15:31, Wang Weijun 写道:
Several comments:
1. openjdk does not like binary files. I would store them in BASE64.
2. You can store a certificate in pkcs1
No. The PKCS12 KeyStore supports only the binary (DER) format.
On 26 Aug 2014, at 08:06, Wang Weijun wrote:
> Vinnie
>
> I'm reviewing a test fix including a lot of binary pkcs12 files. Do you think
> we can directly support PEM format pkcs12 files in our own PKCS12KeyStore?
>
> Thanks
> Max
Vinnie
I'm reviewing a test fix including a lot of binary pkcs12 files. Do you think
we can directly support PEM format pkcs12 files in our own PKCS12KeyStore?
Thanks
Max
Begin forwarded message:
> Several comments:
>
> 1. openjdk does not like binary files. I would store them in BASE64.
>
>
Several comments:
1. openjdk does not like binary files. I would store them in BASE64.
2. You can store a certificate in pkcs12 keystore now, so block at line 153 is
not correct anymore for all pkcs12 keystores. Of course, you can keep it
because all your testing pkcs12 stores should only conta
Hi Xuelei,
May I request you to review 1 new test to be added for PKCS12 read
operations. New test are added to address following:
- Implement tests for read operations with PKCS12 keystore.
JDK Issue:***https://bugs.openjdk.java.net/browse/JDK-8048617*
Webrev: http://cr.openjdk.java.net/~tyan
