Re: Code Review Request, JDK-8178728 Check the AlgorithmParameters in algorithm constraints

2017-06-06 Thread Xuelei Fan
On 6/6/2017 6:03 PM, Anthony Scarpino wrote: On 06/06/2017 04:04 PM, Xuelei Fan wrote: New webrev: http://cr.openjdk.java.net/~xuelei/8178728/webrev.01/ On 6/6/2017 1:45 PM, Anthony Scarpino wrote: On 06/05/2017 02:15 PM, Xuelei Fan wrote: Hi, Please review the JDK 10 update: http://

Re: Code Review Request, JDK-8178728 Check the AlgorithmParameters in algorithm constraints

2017-06-06 Thread Anthony Scarpino
On 06/06/2017 04:04 PM, Xuelei Fan wrote: New webrev: http://cr.openjdk.java.net/~xuelei/8178728/webrev.01/ On 6/6/2017 1:45 PM, Anthony Scarpino wrote: On 06/05/2017 02:15 PM, Xuelei Fan wrote: Hi, Please review the JDK 10 update: http://cr.openjdk.java.net/~xuelei/8178728/webrev.00/

Re: Code Review Request, JDK-8178728 Check the AlgorithmParameters in algorithm constraints

2017-06-06 Thread Xuelei Fan
New webrev: http://cr.openjdk.java.net/~xuelei/8178728/webrev.01/ On 6/6/2017 1:45 PM, Anthony Scarpino wrote: On 06/05/2017 02:15 PM, Xuelei Fan wrote: Hi, Please review the JDK 10 update: http://cr.openjdk.java.net/~xuelei/8178728/webrev.00/ This update extends the DisabledAlgorithmC

Re: Code Review Request, JDK-8178728 Check the AlgorithmParameters in algorithm constraints

2017-06-06 Thread Valerie Peng
Looks fine to me. Thanks, Valerie On 6/5/2017 2:15 PM, Xuelei Fan wrote: Hi, Please review the JDK 10 update: http://cr.openjdk.java.net/~xuelei/8178728/webrev.00/ This update extends the DisabledAlgorithmConstraints implementation by checking the AlgorithmParameters, which is ignored at

Re: Code Review Request, JDK-8178728 Check the AlgorithmParameters in algorithm constraints

2017-06-06 Thread Anthony Scarpino
On 06/05/2017 02:15 PM, Xuelei Fan wrote: Hi, Please review the JDK 10 update: http://cr.openjdk.java.net/~xuelei/8178728/webrev.00/ This update extends the DisabledAlgorithmConstraints implementation by checking the AlgorithmParameters, which is ignored at present. Thanks, Xuelei I'm fi

Code Review Request, JDK-8178728 Check the AlgorithmParameters in algorithm constraints

2017-06-05 Thread Xuelei Fan
Hi, Please review the JDK 10 update: http://cr.openjdk.java.net/~xuelei/8178728/webrev.00/ This update extends the DisabledAlgorithmConstraints implementation by checking the AlgorithmParameters, which is ignored at present. Thanks, Xuelei