The missing @since for overridden methods and missing @throws for unchecked
exceptions is a known javadoc behaviour. Apparently there's some disagreement
as to whether it is a bug but I encourage you to add the tags.
Mike
On Nov 27 2013, at 12:55 , Bradford Wetmore wrote:
> Sean wrote:
>
>
Sean wrote:
> That kind of seems like a javadoc bug to me. Shouldn't it add the
> @since tag as part of inheriting the javadoc?
On the chance that this is a real bug, I filed this yesterday:
https://bugs.openjdk.java.net/browse/JDK-8029241
@throws/@since are both missing (others?), it seem
> On Nov 27, 2013, at 10:12 AM, Sean Mullan wrote:
>
>> On 11/26/2013 08:20 PM, Bradford Wetmore wrote:
>> Tony,
>>
>> I note the @since's are missing for the new methods, both in the
>> generated output in the overridden methods (i.e. no javadoc), and the
>> methods in which you've changed the
On 11/26/2013 08:20 PM, Bradford Wetmore wrote:
Tony,
I note the @since's are missing for the new methods, both in the
generated output in the overridden methods (i.e. no javadoc), and the
methods in which you've changed the behavior (i.e. new javadoc).
I'm not sure what you can do about the pr
Tony,
I note the @since's are missing for the new methods, both in the
generated output in the overridden methods (i.e. no javadoc), and the
methods in which you've changed the behavior (i.e. new javadoc).
I'm not sure what you can do about the previous behavior (cc'ing
Mike/Sowmya, maybe th
On 10/18/2013 10:52 PM, Anthony Scarpino wrote:
I've updated the webrev
http://cr.openjdk.java.net/~ascarpino/8025763/webrev.01/
Update looks good.
--Sean
On 10/18/2013 12:44 PM, Sean Mullan wrote:
Mostly looks good, just a few comments:
- for completeness, please add @Override tags to all existing methods
that are overridden
- you need to also override the new forEach and getOrDefault methods to
first check if the provider is initialized. See, f
Mostly looks good, just a few comments:
- for completeness, please add @Override tags to all existing methods
that are overridden
- you need to also override the new forEach and getOrDefault methods to
first check if the provider is initialized. See, for example, the get
method.
- nit, say
Hi,
I need a code review for changes regarding
8025763 Provider does not override new Hashtable methods
http://cr.openjdk.java.net/~ascarpino/8025763/
thanks
Tony
