Re: RFR: 8212136: Remove BaseSSLSocketImpl finalizer method [v3]

2022-05-02 Thread Bradford Wetmore
On Tue, 3 May 2022 02:02:58 GMT, Xue-Lei Andrew Fan wrote: >>> Thanks for the rewording. Updated. >> >> I made one more tweak that reads better. > > Yes, it looks better. Updated. Thanks! Looks good, thanks. - PR: https://git.openjdk.java.net/jdk/pull/8065

Re: RFR: 8212136: Remove BaseSSLSocketImpl finalizer method [v3]

2022-05-02 Thread Xue-Lei Andrew Fan
On Mon, 2 May 2022 17:55:56 GMT, Bradford Wetmore wrote: >> Thanks for the rewording. Updated. > >> Thanks for the rewording. Updated. > > I made one more tweak that reads better. Yes, it looks better. Updated. Thanks! - PR: https://git.openjdk.java.net/jdk/pull/8065

Re: RFR: 8212136: Remove BaseSSLSocketImpl finalizer method [v3]

2022-05-02 Thread Bradford Wetmore
On Mon, 2 May 2022 17:45:44 GMT, Xue-Lei Andrew Fan wrote: > Thanks for the rewording. Updated. I made one more tweak that reads better. - PR: https://git.openjdk.java.net/jdk/pull/8065

Re: RFR: 8212136: Remove BaseSSLSocketImpl finalizer method [v3]

2022-05-02 Thread Xue-Lei Andrew Fan
On Mon, 2 May 2022 16:46:17 GMT, Bradford Wetmore wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> comment about remove finalize() method > > src/java.base/share/classes/sun/security/ssl/BaseSSLSocketImpl.java

Re: RFR: 8212136: Remove BaseSSLSocketImpl finalizer method [v3]

2022-05-02 Thread Bradford Wetmore
On Mon, 2 May 2022 05:01:21 GMT, Xue-Lei Andrew Fan wrote: >> Please review the update to remove finalizer method in the SunJSSE provider >> implementation. It is one of the efforts to clean up the use of finalizer >> method in JDK. > > Xue-Lei Andrew Fan has updated the pull request increment

Re: RFR: 8212136: Remove BaseSSLSocketImpl finalizer method [v3]

2022-05-01 Thread Xue-Lei Andrew Fan
On Sat, 30 Apr 2022 03:46:23 GMT, Bradford Wetmore wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> comment about remove finalize() method > > src/java.base/share/classes/sun/security/ssl/BaseSSLSocketImpl.jav

Re: RFR: 8212136: Remove BaseSSLSocketImpl finalizer method [v3]

2022-05-01 Thread Xue-Lei Andrew Fan
> Please review the update to remove finalizer method in the SunJSSE provider > implementation. It is one of the efforts to clean up the use of finalizer > method in JDK. Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision: commen