Thanks Erik.
在 2019年09月24日 23:19, Erik Joelsson 写道:
Sure, will do.
/Erik
Sure, will do.
/Erik
On 2019-09-23 20:57, Jia Huang wrote:
Hi Erik,
Thank you for your review and valuable comments.
Updated: http://cr.openjdk.java.net/~jiefu/8231351-huangjia/webrev.01/
- The reference to the pkcs11 README and the reviewers had been added.
Please note the user in the
Hi John Jiang,
I don't care which NSS you have skipped.
I am just curious about the root cause for the failure on Ubuntu.
It seems more reasonable to close JDK-8231338 as won't fix.
But you just closed it as can't reproduce.
Thanks.
Best regards,
Jie
On 2019/9/24 下午4:01, sha.ji...@oracle.com
Hi Jie,
IIRC, this test passed on your Ubuntu 18.04 with a new built NSS 3.35 libs.
So, I suspected your Linux or the system built-in NSS libs had something
wrong.
Now that this test passed with NSS 3.35 on others' Linux, including
mine, it may not make sense that this test is skipped for NSS
I can't understand why JDK-8231338 was closed as "Cannot Reproduce"
since it can always be reproduced on Ubuntu 18.04.2 LTS.
Reproduce on Ubuntu 18.04 is very simple:
-
make test TEST="jtreg:sun/security/pkcs11/Secmod/AddTrustedCert.java"
CONF=re
I may be a little bit hesitate to add such words, "highly recommended to
use the latest NSS version ...", in the general TOP doc. There are a
few issues that I wary about:
It is not always expected that all PKCS 11 test should be run on latest
NSS version. Otherwise, there might be
Hi John Jiang,
Thank you for your review.
在 2019年09月23日 20:54, sha.ji...@oracle.com 写道:
In fact, PKCS11 tests have their own doc at:
test/jdk/sun/security/pkcs11/README
I'm afraid most people wouldn't see test/jdk/sun/security/pkcs11/README
at all.
So it makes very little sense to add the
Hi Erik,
Thank you for your review and valuable comments.
Updated: http://cr.openjdk.java.net/~jiefu/8231351-huangjia/webrev.01/
- The reference to the pkcs11 README and the reviewers had been added.
Please note the user in the patch.
Hope you wouldn't mind it. Thanks.
Could you please
I think this type of comment fits well in the top level test doc. It
just provides basic instructions for setting up these tests so that they
pass without going into too much detail. Perhaps a reference to the
pkcs11 README for more details would be a good idea.
Looks good to me.
/Erik
On
Hi Jia,
I think this isn't a general testing problem.
It may not worthy of highlighting this point in the JDK testing doc.
In fact, PKCS11 tests have their own doc at:
test/jdk/sun/security/pkcs11/README
Best regards,
John Jiang
On 2019/9/23 18:04, Jia Huang wrote:
Hi all,
JBS:
Hi all,
JBS:https://bugs.openjdk.java.net/browse/JDK-8231351
Webrev: http://cr.openjdk.java.net/~jiefu/8231351-huangjia/webrev.00/
sun/security/pkcs11/Secmod/AddTrustedCert.java failed on Ubuntu 18.04.
According to the comments in JDK-8231338, it was caused by the improper
NSS libs of the
11 matches
Mail list logo
