(JDK-8266351) Re: [External] : Re: RFR: 8236671: NullPointerException in JKS keystore [v2]

Thanks for the pointers Will. I've added your details to the JDK-8266351 bug report. https://bugs.openjdk.java.net/browse/JDK-8266351 regards, Sean. On 24/05/2021 18:53, Will Sargent wrote: I have tried to sign up to the bug tracking system (through reset password I think?) but I'm not getting

Re: RFR: 8236671: NullPointerException in JKS keystore [v2]

I have tried to sign up to the bug tracking system (through reset password I think?) but I'm not getting an email out, so I can't add to the bug. I have created a test case in Github: https://github.com/wsargent/jca-key-failure/ The stack trace shows the invalid key store entry after saving and

Re: RFR: 8236671: NullPointerException in JKS keystore [v2]

Thanks for the feedback Will. It would be useful if you can provide a testcase and/or add comments to JDK-8266351 on your experience. regards, Sean. On 30/04/2021 17:54, Will Sargent wrote: > KeyStore specification will be tightened up via an

Re: RFR: 8236671: NullPointerException in JKS keystore [v2]

> KeyStore specification will be tightened up via another bug record This would be super helpful, as one thing that confuses me is what the relationship is between a key entry and a key alias -- in particular, the existence alias doesn't seem to guarantee a valid entry that can be retrieved. In J

Re: RFR: 8236671: NullPointerException in JKS keystore [v2]

On Wed, 28 Apr 2021 12:39:42 GMT, Sean Coffey wrote: >> Trivial enough change. Improved the exception thrown from JceKeyStore also. > > Sean Coffey has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought i

Re: RFR: 8236671: NullPointerException in JKS keystore [v2]

On Wed, 28 Apr 2021 12:39:42 GMT, Sean Coffey wrote: >> Trivial enough change. Improved the exception thrown from JceKeyStore also. > > Sean Coffey has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought i

Re: RFR: 8236671: NullPointerException in JKS keystore [v2]

> Trivial enough change. Improved the exception thrown from JceKeyStore also. Sean Coffey has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additiona

Re: RFR: 8236671: NullPointerException in JKS keystore

On Tue, 20 Apr 2021 11:54:39 GMT, Sean Coffey wrote: > Trivial enough change. Improved the exception thrown from JceKeyStore also. src/java.base/share/classes/sun/security/provider/JavaKeyStore.java line 290: > 288: > 289: // Protect the encoding of the key > 290:

Re: RFR: 8236671: NullPointerException in JKS keystore

On Tue, 20 Apr 2021 20:06:16 GMT, Sean Coffey wrote: > > It looks like a public behavior change to me. Did you want to file a CSR > > and update the specification (KeyStore) as well? I think it would be nice > > if we could keep use the old exception, IllegalArgumentException, as > > described

Re: RFR: 8236671: NullPointerException in JKS keystore

On Tue, 20 Apr 2021 17:00:40 GMT, Xue-Lei Andrew Fan wrote: > It looks like a public behavior change to me. Did you want to file a CSR and > update the specification (KeyStore) as well? I think it would be nice if we > could keep use the old exception, IllegalArgumentException, as described in

Re: RFR: 8236671: NullPointerException in JKS keystore

On Tue, 20 Apr 2021 11:54:39 GMT, Sean Coffey wrote: > Trivial enough change. Improved the exception thrown from JceKeyStore also. It looks like a public behavior change to me. Did you want to file a CSR and update the specification (KeyStore) as well? - PR: https://git.openjdk.j

Re: RFR: 8236671: NullPointerException in JKS keystore

On Tue, 20 Apr 2021 11:54:39 GMT, Sean Coffey wrote: > Trivial enough change. Improved the exception thrown from JceKeyStore also. Marked as reviewed by hchao (Committer). - PR: https://git.openjdk.java.net/jdk/pull/3588

RFR: 8236671: NullPointerException in JKS keystore

Trivial enough change. Improved the exception thrown from JceKeyStore also. - Commit messages: - Fix white space - 8236671: NullPointerException in JKS keystore Changes: https://git.openjdk.java.net/jdk/pull/3588/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3588&ran