RFR: 8240256: Better resource cleaning for SunPKCS11 Provider

2021-04-16 Thread Sean Coffey
Added capability to allow the PKCS11 Token to be destroyed once a session is logged out from. New configuration properties via pkcs11 config file. Cleaned up the native resource poller also. New unit test case to test behaviour. Some PKCS11 tests refactored to allow pkcs11 provider to be config

Re: RFR: 8240256: Better resource cleaning for SunPKCS11 Provider

2021-04-20 Thread Valerie Peng
On Fri, 16 Apr 2021 11:24:57 GMT, Sean Coffey wrote: > Added capability to allow the PKCS11 Token to be destroyed once a session is > logged out from. New configuration properties via pkcs11 config file. Cleaned > up the native resource poller also. > > New unit test case to test behaviour. So

Re: RFR: 8240256: Better resource cleaning for SunPKCS11 Provider

2021-04-26 Thread Valerie Peng
On Fri, 16 Apr 2021 11:24:57 GMT, Sean Coffey wrote: > Added capability to allow the PKCS11 Token to be destroyed once a session is > logged out from. New configuration properties via pkcs11 config file. Cleaned > up the native resource poller also. > > New unit test case to test behaviour. So

Re: RFR: 8240256: Better resource cleaning for SunPKCS11 Provider

2021-05-03 Thread Valerie Peng
On Fri, 16 Apr 2021 11:24:57 GMT, Sean Coffey wrote: > Added capability to allow the PKCS11 Token to be destroyed once a session is > logged out from. New configuration properties via pkcs11 config file. Cleaned > up the native resource poller also. > > New unit test case to test behaviour. So

Re: RFR: 8240256: Better resource cleaning for SunPKCS11 Provider

2021-05-03 Thread Valerie Peng
On Fri, 16 Apr 2021 11:24:57 GMT, Sean Coffey wrote: > Added capability to allow the PKCS11 Token to be destroyed once a session is > logged out from. New configuration properties via pkcs11 config file. Cleaned > up the native resource poller also. > > New unit test case to test behaviour. So

Re: RFR: 8240256: Better resource cleaning for SunPKCS11 Provider

2021-05-03 Thread Valerie Peng
On Fri, 16 Apr 2021 11:24:57 GMT, Sean Coffey wrote: > Added capability to allow the PKCS11 Token to be destroyed once a session is > logged out from. New configuration properties via pkcs11 config file. Cleaned > up the native resource poller also. > > New unit test case to test behaviour. So

Re: RFR: 8240256: Better resource cleaning for SunPKCS11 Provider

2021-05-07 Thread Sean Coffey
On Wed, 21 Apr 2021 01:26:18 GMT, Valerie Peng wrote: >> Added capability to allow the PKCS11 Token to be destroyed once a session is >> logged out from. New configuration properties via pkcs11 config file. >> Cleaned up the native resource poller also. >> >> New unit test case to test behavio

Re: RFR: 8240256: Better resource cleaning for SunPKCS11 Provider [v2]

2021-05-07 Thread Sean Coffey
> Added capability to allow the PKCS11 Token to be destroyed once a session is > logged out from. New configuration properties via pkcs11 config file. Cleaned > up the native resource poller also. > > New unit test case to test behaviour. Some PKCS11 tests refactored to allow > pkcs11 provider

Re: RFR: 8240256: Better resource cleaning for SunPKCS11 Provider [v2]

2021-05-12 Thread Valerie Peng
On Fri, 7 May 2021 13:51:05 GMT, Sean Coffey wrote: >> Added capability to allow the PKCS11 Token to be destroyed once a session is >> logged out from. New configuration properties via pkcs11 config file. >> Cleaned up the native resource poller also. >> >> New unit test case to test behaviour

Re: RFR: 8240256: Better resource cleaning for SunPKCS11 Provider [v2]

2021-05-28 Thread Seán Coffey
Thanks for the review Valerie. I've gone ahead and updated the test. You've a good point in that the PKCS11Test framework didn't suit the test that I needed. The new test no longer extends PKCS11Test as a result. I have kept the refactoring in PKCS11Test thought since it can offer up some usefu

Re: RFR: 8240256: Better resource cleaning for SunPKCS11 Provider [v3]

2021-05-28 Thread Sean Coffey
clean up - Merge branch 'master' into JDK-8240256-pkcs11 - Initial corrections from RFR - 8240256: Better resource cleaning for SunPKCS11 Provider - Changes: https://git.openjdk.java.net/jdk/pull/3544/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3544&a

Re: RFR: 8240256: Better resource cleaning for SunPKCS11 Provider [v3]

2021-06-02 Thread Valerie Peng
e or a rebase. The pull request now contains five commits: > > - whitespace > - Further 8240256 test clean up > - Merge branch 'master' into JDK-8240256-pkcs11 > - Initial corrections from RFR > - 8240256: Better resource cleaning for SunPKCS11 Provider Change