Re: RFR: 8248268: Support KWP in addition to KW [v3]

2021-04-12 Thread Valerie Peng
On Tue, 23 Mar 2021 19:14:16 GMT, Greg Rubin wrote: >> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Changed AlgorithmParameters impls to register under AES/KW/NoPadding and >> AES/KWP/NoPadding > > test/jdk/com/sun/cry

Re: RFR: 8248268: Support KWP in addition to KW [v3]

2021-03-26 Thread Valerie Peng
On Tue, 23 Mar 2021 17:16:04 GMT, Greg Rubin wrote: >> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Changed AlgorithmParameters impls to register under AES/KW/NoPadding and >> AES/KWP/NoPadding > > test/jdk/com/sun/cry

Re: RFR: 8248268: Support KWP in addition to KW [v3]

2021-03-26 Thread Valerie Peng
On Tue, 23 Mar 2021 19:06:30 GMT, Greg Rubin wrote: >> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Changed AlgorithmParameters impls to register under AES/KW/NoPadding and >> AES/KWP/NoPadding > > src/java.base/share/

Re: RFR: 8248268: Support KWP in addition to KW [v3]

2021-03-25 Thread Valerie Peng
On Tue, 23 Mar 2021 18:47:32 GMT, Greg Rubin wrote: >> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Changed AlgorithmParameters impls to register under AES/KW/NoPadding and >> AES/KWP/NoPadding > > src/java.base/share/

Re: RFR: 8248268: Support KWP in addition to KW [v3]

2021-03-25 Thread Valerie Peng
On Tue, 23 Mar 2021 20:09:23 GMT, Greg Rubin wrote: >> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Changed AlgorithmParameters impls to register under AES/KW/NoPadding and >> AES/KWP/NoPadding > > src/java.base/share/

Re: RFR: 8248268: Support KWP in addition to KW [v3]

2021-03-25 Thread Valerie Peng
On Tue, 23 Mar 2021 19:57:44 GMT, Greg Rubin wrote: >> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Changed AlgorithmParameters impls to register under AES/KW/NoPadding and >> AES/KWP/NoPadding > > src/java.base/share/

Re: RFR: 8248268: Support KWP in addition to KW [v3]

2021-03-24 Thread Valerie Peng
On Tue, 23 Mar 2021 19:18:14 GMT, Greg Rubin wrote: >> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Changed AlgorithmParameters impls to register under AES/KW/NoPadding and >> AES/KWP/NoPadding > > test/jdk/com/sun/cry

Re: RFR: 8248268: Support KWP in addition to KW [v3]

2021-03-24 Thread Valerie Peng
On Tue, 23 Mar 2021 19:56:40 GMT, Greg Rubin wrote: >> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Changed AlgorithmParameters impls to register under AES/KW/NoPadding and >> AES/KWP/NoPadding > > src/java.base/share/

Re: RFR: 8248268: Support KWP in addition to KW [v3]

2021-03-24 Thread Valerie Peng
On Tue, 23 Mar 2021 18:41:26 GMT, Greg Rubin wrote: >> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Changed AlgorithmParameters impls to register under AES/KW/NoPadding and >> AES/KWP/NoPadding > > src/java.base/share/

Re: RFR: 8248268: Support KWP in addition to KW [v3]

2021-03-24 Thread Valerie Peng
On Tue, 23 Mar 2021 18:39:27 GMT, Greg Rubin wrote: >> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Changed AlgorithmParameters impls to register under AES/KW/NoPadding and >> AES/KWP/NoPadding > > src/java.base/share/

Re: RFR: 8248268: Support KWP in addition to KW [v3]

2021-03-23 Thread Michael StJohns
On 3/22/2021 5:43 PM, Valerie Peng wrote: This change updates SunJCE provider as below: - updated existing AESWrap support with AES/KW/NoPadding cipher transformation. - added support for AES/KWP/NoPadding and AES/KW/PKCS5Padding. Existing AESWrap impl, i.e. AESWrapCipher class, is re-factored a

Re: RFR: 8248268: Support KWP in addition to KW [v3]

2021-03-23 Thread Michael StJohns
On 3/23/2021 4:15 PM, Greg Rubin wrote: 177: System.out.println("Testing " + ALGO); 178: c = Cipher.getInstance(ALGO, "SunJCE"); 179: for (int i = 0; i < MAX_KWP_PAD_LEN; i++) { I see that here (and earlier) we do test all padding lengths. I'd still like some KATs genera

Re: RFR: 8248268: Support KWP in addition to KW [v3]

2021-03-23 Thread Greg Rubin
On Mon, 22 Mar 2021 21:43:31 GMT, Valerie Peng wrote: >> This change updates SunJCE provider as below: >> - updated existing AESWrap support with AES/KW/NoPadding cipher >> transformation. >> - added support for AES/KWP/NoPadding and AES/KW/PKCS5Padding. >> >> Existing AESWrap impl, i.e. AESWr

Re: RFR: 8248268: Support KWP in addition to KW [v3]

2021-03-22 Thread Valerie Peng
> This change updates SunJCE provider as below: > - updated existing AESWrap support with AES/KW/NoPadding cipher > transformation. > - added support for AES/KWP/NoPadding and AES/KW/PKCS5Padding. > > Existing AESWrap impl, i.e. AESWrapCipher class, is re-factored and renamed > to KeyWrapCipher