On Fri, 13 May 2022 14:35:56 GMT, Sean Mullan wrote:
>> Hmm, would it fall under the "Otherwise, null is returned"? If not, perhaps
>> we can add back the part about returning AlgorithmParameters as below:
>>
>> **If the underlying signature implementation supports returning the
>> parameters
On Thu, 12 May 2022 19:45:37 GMT, Valerie Peng wrote:
>> That sentence is specifically if the caller did not specify parameters
>> though. The previous wording is if the caller did specify parameters (as say
>> an `AlgorithmParameterSpec`) and the implementation cannot return them as
>> `Algor
On Thu, 12 May 2022 18:23:18 GMT, Sean Mullan wrote:
>> Fixed the nit. Thanks~
>> As for the part about returning the parameters as `{@code
>> AlgorithmParameters}`, it should be covered by current sentence, i.e. `and
>> can be generated by the signature`. Perhaps we don't have to spell out all
On Wed, 11 May 2022 22:12:48 GMT, Valerie Peng wrote:
>> src/java.base/share/classes/java/security/SignatureSpi.java line 399:
>>
>>> 397: * values used by the underlying signature scheme. If the required
>>> 398: * parameters were not supplied and can be generated by the
>>> signatur
On Tue, 10 May 2022 20:42:55 GMT, Sean Mullan wrote:
>> Valerie Peng has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits
On Mon, 9 May 2022 18:45:05 GMT, Valerie Peng wrote:
>> This is to update the method javadoc of
>> java.security.Signature.getParameters() with the missing `@throws
>> UnsupportedOperationException`. In addition, the wording on the returned
>> parameters are updated to match those in Cipher an
On Mon, 9 May 2022 18:45:05 GMT, Valerie Peng wrote:
>> This is to update the method javadoc of
>> java.security.Signature.getParameters() with the missing `@throws
>> UnsupportedOperationException`. In addition, the wording on the returned
>> parameters are updated to match those in Cipher an
> This is to update the method javadoc of
> java.security.Signature.getParameters() with the missing `@throws
> UnsupportedOperationException`. In addition, the wording on the returned
> parameters are updated to match those in Cipher and CipherSpi classes.
>
> CSR will be filed later.
>
> Th
