On Thu, 22 Apr 2021 17:38:43 GMT, Naoto Sato wrote:
>> Please review the changes for the subject issue. This has been suggested in
>> a recent discussion thread for the JEP 400
>> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
>> A CSR has also been draft
On Thu, 22 Apr 2021 17:38:43 GMT, Naoto Sato wrote:
>> Please review the changes for the subject issue. This has been suggested in
>> a recent discussion thread for the JEP 400
>> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
>> A CSR has also been draft
> Please review the changes for the subject issue. This has been suggested in
> a recent discussion thread for the JEP 400
> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
> A CSR has also been drafted, and comments are welcome
> [[2](https://bugs.openjdk.
On Thu, 22 Apr 2021 16:29:35 GMT, Roger Riggs wrote:
>> Then `charset()` in the shared secret would return `null`. Would that
>> suffice your case?
>
> I read lines 575-587 as initializing CHARSET regardless of whether the
> Console was created.
OK, revived the charset() method.
-
On Thu, 22 Apr 2021 16:11:16 GMT, Naoto Sato wrote:
>> Not always, for example, if stderr was redirected to a terminal but not
>> stdin and stdout.
>> The istty check is only true if both stdin and stdout are ttys.
>
> Then `charset()` in the shared secret would return `null`. Would that suffice
On Thu, 22 Apr 2021 16:03:12 GMT, Roger Riggs wrote:
>> Would the singleton `Console.cons` be instantiated in your use case? It is
>> created only when isatty() (or Windows' equivalent) in the native code
>> returns true.
>
> Not always, for example, if stderr was redirected to a terminal but n
On Thu, 22 Apr 2021 15:42:02 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/io/Console.java line 597:
>>
>>> 595: return null;
>>> 596: }
>>> 597: });
>>
>> Please keep the charset() method and return CHARSET.
>>
>> I'm looking at a use case that
On Thu, 22 Apr 2021 15:18:11 GMT, Roger Riggs wrote:
>> Naoto Sato has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 13 additional
>> commits sinc
On Tue, 20 Apr 2021 22:35:00 GMT, Naoto Sato wrote:
>> Please review the changes for the subject issue. This has been suggested in
>> a recent discussion thread for the JEP 400
>> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
>> A CSR has also been draft
> Please review the changes for the subject issue. This has been suggested in
> a recent discussion thread for the JEP 400
> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
> A CSR has also been drafted, and comments are welcome
> [[2](https://bugs.openjdk.
> Please review the changes for the subject issue. This has been suggested in
> a recent discussion thread for the JEP 400
> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
> A CSR has also been drafted, and comments are welcome
> [[2](https://bugs.openjdk.
On Fri, 16 Apr 2021 18:15:41 GMT, Roger Riggs wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Modified javadocs per suggestions.
>
> src/java.base/share/classes/java/io/InputStreamReader.java line 48:
>
>> 46: * F
On Thu, 15 Apr 2021 18:29:17 GMT, Naoto Sato wrote:
>> Please review the changes for the subject issue. This has been suggested in
>> a recent discussion thread for the JEP 400
>> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
>> A CSR has also been draft
On Thu, 15 Apr 2021 14:17:11 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added @see links.
>
> src/java.base/share/classes/java/io/Console.java line 397:
>
>> 395: /**
>> 396: * Return
> Please review the changes for the subject issue. This has been suggested in
> a recent discussion thread for the JEP 400
> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
> A CSR has also been drafted, and comments are welcome
> [[2](https://bugs.openjdk.
On Wed, 14 Apr 2021 17:17:03 GMT, Naoto Sato wrote:
>> Please review the changes for the subject issue. This has been suggested in
>> a recent discussion thread for the JEP 400
>> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
>> A CSR has also been draft
> Please review the changes for the subject issue. This has been suggested in
> a recent discussion thread for the JEP 400
> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
> A CSR has also been drafted, and comments are welcome
> [[2](https://bugs.openjdk.
> Please review the changes for the subject issue. This has been suggested in
> a recent discussion thread for the JEP 400
> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
> A CSR has also been drafted, and comments are welcome
> [[2](https://bugs.openjdk.
On Wed, 14 Apr 2021 15:03:19 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added comment to System.out/err init.
>
> src/java.base/share/classes/java/lang/System.java line 166:
>
>> 164: * e
On Tue, 13 Apr 2021 19:59:30 GMT, Naoto Sato wrote:
>> Please review the changes for the subject issue. This has been suggested in
>> a recent discussion thread for the JEP 400
>> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
>> A CSR has also been draft
On Tue, 13 Apr 2021 19:59:30 GMT, Naoto Sato wrote:
>> Please review the changes for the subject issue. This has been suggested in
>> a recent discussion thread for the JEP 400
>> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
>> A CSR has also been draft
On Tue, 13 Apr 2021 19:30:53 GMT, Joe Wang wrote:
>> Although the code path is different, the logic to determine the encoding is
>> not changed, as `sun.stdout/err.encoding` are only set if the VM is invoked
>> from a terminal (in fact, there's a bug where they aren't set even in a
>> terminal
> Please review the changes for the subject issue. This has been suggested in
> a recent discussion thread for the JEP 400
> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
> A CSR has also been drafted, and comments are welcome
> [[2](https://bugs.openjdk.
On Tue, 13 Apr 2021 18:24:55 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/lang/System.java line 2020:
>>
>>> 2018: setIn0(new BufferedInputStream(fdIn));
>>> 2019: setOut0(newPrintStream(fdOut, cs));
>>> 2020: setErr0(newPrintStream(fdErr, cs));
>>
>> It wa
On Tue, 13 Apr 2021 13:04:17 GMT, Alan Bateman wrote:
> 1. I think method name "charset()" is too short. It's not called frequently.
> This method name should explain functionality.
As for this one, I am open for suggestions. I thought `consoel()` was concise,
and analogous to `Charset.default
On Tue, 13 Apr 2021 02:34:15 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reverted PrintStream changes
>
> src/java.base/share/classes/java/lang/System.java line 2020:
>
>> 2018: setIn0(new
> Please review the changes for the subject issue. This has been suggested in
> a recent discussion thread for the JEP 400
> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
> A CSR has also been drafted, and comments are welcome
> [[2](https://bugs.openjdk.
On Tue, 13 Apr 2021 12:54:51 GMT, Ichiroh Takiguchi
wrote:
> 1. I think method name "charset()" is too short. It's not called frequently.
> This method name should explain functionality.
> 2. Sometimes stderr may be redirected to stdout by shell. Why do we need to
> set different encodings for
On Mon, 12 Apr 2021 23:01:24 GMT, Naoto Sato wrote:
>> Please review the changes for the subject issue. This has been suggested in
>> a recent discussion thread for the JEP 400
>> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
>> A CSR has also been draft
On Mon, 12 Apr 2021 23:01:24 GMT, Naoto Sato wrote:
>> Please review the changes for the subject issue. This has been suggested in
>> a recent discussion thread for the JEP 400
>> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
>> A CSR has also been draft
On Mon, 12 Apr 2021 21:12:08 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/io/Console.java line 397:
>>
>>> 395: /**
>>> 396: * Returns the {@link java.nio.charset.Charset Charset} object
>>> used in
>>> 397: * this {@code Console}.
>>
>> The Console is a singleton a
> Please review the changes for the subject issue. This has been suggested in
> a recent discussion thread for the JEP 400
> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
> A CSR has also been drafted, and comments are welcome
> [[2](https://bugs.openjdk.
On Sun, 11 Apr 2021 13:44:05 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflected the review comments.
>
> src/java.base/share/classes/java/io/Console.java line 397:
>
>> 395: /**
>> 396:
> Please review the changes for the subject issue. This has been suggested in
> a recent discussion thread for the JEP 400
> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
> A CSR has also been drafted, and comments are welcome
> [[2](https://bugs.openjdk.
On Fri, 9 Apr 2021 21:06:00 GMT, Naoto Sato wrote:
>> Please review the changes for the subject issue. This has been suggested in
>> a recent discussion thread for the JEP 400
>> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
>> A CSR has also been drafte
: Console charset API [v2]
> Please review the changes for the subject issue. This has been suggested in
> a recent discussion thread for the JEP 400
> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
> A CSR has also been drafted, and comments
On Fri, 9 Apr 2021 21:06:00 GMT, Naoto Sato wrote:
>> Please review the changes for the subject issue. This has been suggested in
>> a recent discussion thread for the JEP 400
>> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
>> A CSR has also been drafte
On Fri, 9 Apr 2021 21:02:26 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/io/Console.java line 404:
>>
>>> 402: *
>>> 403: * @return A {@code Charset} object used in this {@code Console}.
>>> 404: * @since 17
>>
>> A couple of minor comments:
>> May replace {@code C
> Please review the changes for the subject issue. This has been suggested in
> a recent discussion thread for the JEP 400
> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
> A CSR has also been drafted, and comments are welcome
> [[2](https://bugs.openjdk.
On Fri, 9 Apr 2021 19:25:02 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflected the review comments.
>
> src/java.base/share/classes/java/io/Console.java line 404:
>
>> 402: *
>> 403: *
On Fri, 9 Apr 2021 16:47:55 GMT, Naoto Sato wrote:
> Please review the changes for the subject issue. This has been suggested in
> a recent discussion thread for the JEP 400
> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
> A CSR has also been drafted, a
Please review the changes for the subject issue. This has been suggested in a
recent discussion thread for the JEP 400
[[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
A CSR has also been drafted, and comments are welcome
[[2](https://bugs.openjdk.java.net/b
42 matches
Mail list logo
