On Thu, 6 May 2021 14:42:20 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the
>> `java.security` package to make use of the `instanceof` pattern variable?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull reques
On Mon, 26 Apr 2021 17:52:05 GMT, Jesper Steen Møller
wrote:
> Changes look good, except for the unneeded parenthesis?
>
> (but I'm not a committer, so it's less useful)
Hi Jesper, thanks for your suggestions and well spotted. I've addressed the
issues and responded to your comments with the
On Thu, 6 May 2021 14:42:20 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the
>> `java.security` package to make use of the `instanceof` pattern variable?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull reques
On Thu, 6 May 2021 14:42:20 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the
>> `java.security` package to make use of the `instanceof` pattern variable?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull reques
On Tue, 27 Apr 2021 04:38:32 GMT, Punikekk
wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8265426: changed order of equals check; refactored Identity.equals method
>
> src/java.base/share/classes/java/securi
On Thu, 6 May 2021 13:41:04 GMT, Weijun Wang wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8265426: Reverted parameter names; removed redundant parenthesis
>
> src/java.base/share/classes/java/security/cert/
> Hi,
>
> Could someone please review my code for updating the code in the
> `java.security` package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request incrementally with one
additional commit since the last revision:
> Hi,
>
> Could someone please review my code for updating the code in the
> `java.security` package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a rebase. The incremental w
On Thu, 6 May 2021 11:52:15 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the
>> `java.security` package to make use of the `instanceof` pattern variable?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull reques
On Thu, 6 May 2021 11:52:15 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the
>> `java.security` package to make use of the `instanceof` pattern variable?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull reques
On Mon, 26 Apr 2021 23:24:41 GMT, Weijun Wang wrote:
> Two comments:
>
> 1. Why not reuse the existing variable name (Ex: `t` in `Type t =
> (Type)obj`) as much as possible to avoid unnecessary renames?
>
> 2. I'm not sure if modifying argument name in a public API is a good
> idea. T
On Mon, 26 Apr 2021 17:03:52 GMT, Jesper Steen Møller
wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8265426: Reverted parameter names; removed redundant parenthesis
>
> src/java.base/share/classes/java/secu
On Mon, 26 Apr 2021 18:14:21 GMT, Roger Riggs wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8265426: Reverted parameter names; removed redundant parenthesis
>
> src/java.base/share/classes/java/security/Code
> Hi,
>
> Could someone please review my code for updating the code in the
> `java.security` package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request incrementally with one
additional commit since the last revision:
> Hi,
>
> Could someone please review my code for updating the code in the
> `java.security` package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a rebase. The incremental w
On Mon, 26 Apr 2021 08:50:36 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the
> `java.security` package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
src/java.base/share/classes/java/security/Identity.jav
On Mon, 26 Apr 2021 08:50:36 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the
> `java.security` package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Two comments:
1. Why not reuse the existing variable
On Mon, 26 Apr 2021 08:50:36 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the
> `java.security` package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Two comments:
1. Why not reuse the existing variable
On Mon, 26 Apr 2021 08:50:36 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the
> `java.security` package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Marked as reviewed by rriggs (Reviewer).
src/java.bas
On Mon, 26 Apr 2021 08:50:36 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the
> `java.security` package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Changes look good, except for the unneeded parenthesis
Hi,
Could someone please review my code for updating the code in the
`java.security` package to make use of the `instanceof` pattern variable?
Kind regards,
Patrick
-
Commit messages:
- 8265426: Update java.security to use instanceof pattern variable
Changes: https://git.openjdk.
21 matches
Mail list logo
