On Thu, 6 May 2021 13:41:04 GMT, Weijun Wang wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8265426: Reverted parameter names; removed redundant parenthesis
>
>
On Thu, 6 May 2021 11:52:15 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the
>> `java.security` package to make use of the `instanceof` pattern variable?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull
On Thu, 6 May 2021 11:52:15 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the
>> `java.security` package to make use of the `instanceof` pattern variable?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull
On Mon, 26 Apr 2021 23:24:41 GMT, Weijun Wang wrote:
> Two comments:
>
> 1. Why not reuse the existing variable name (Ex: `t` in `Type t =
> (Type)obj`) as much as possible to avoid unnecessary renames?
>
> 2. I'm not sure if modifying argument name in a public API is a good
> idea.
On Mon, 26 Apr 2021 17:03:52 GMT, Jesper Steen Møller
wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8265426: Reverted parameter names; removed redundant parenthesis
>
>
On Mon, 26 Apr 2021 18:14:21 GMT, Roger Riggs wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8265426: Reverted parameter names; removed redundant parenthesis
>
>
> Hi,
>
> Could someone please review my code for updating the code in the
> `java.security` package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request incrementally with one
additional commit since the last revision:
