On Wed, 7 Jul 2021 16:22:25 GMT, Mandy Chung wrote:
>> Hi Mandy, thanks for reviewing this.
>>
>>> I suggest to separate the client changes (both src and test) in a separate
>>> PR for the client review.
>>
>> Does "client changes" means changes involving src/java.desktop and
>> test/java/aw
On Wed, 7 Jul 2021 02:10:10 GMT, Yi Yang wrote:
> Does "client changes" means changes involving src/java.desktop and
> test/java/awt?
src/java.desktop, test/java/awt, and test/javax/imageio
-
PR: https://git.openjdk.java.net/jdk/pull/4507
> After JDK-8265518(#3615), it's possible to replace all variants of checkIndex
> by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
> the whole JDK codebase.
Yi Yang has updated the pull request incrementally with two additional commits
since the last revision:
- re
> After JDK-8265518(#3615), it's possible to replace all variants of checkIndex
> by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
> the whole JDK codebase.
Yi Yang has updated the pull request incrementally with four additional commits
since the last revision:
- r
On Tue, 6 Jul 2021 19:06:43 GMT, Mandy Chung wrote:
>> Yi Yang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> tests rely on IOOBE exception message
>
> test/jdk/java/lang/StringBuffer/Exceptions.java line 73:
>
>> 71: n
On Wed, 23 Jun 2021 03:54:55 GMT, Yi Yang wrote:
>> After JDK-8265518(#3615), it's possible to replace all variants of
>> checkIndex by
>> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
>> the whole JDK codebase.
>
> Yi Yang has updated the pull request incrementally
On Mon, 5 Jul 2021 06:29:58 GMT, David Holmes wrote:
>> @dholmes-ora @AlanBateman @PaulSandoz do you have any comments on the latest
>> version? Thanks.
>
> @kelthuzadx I did not see any response to my query about the change in
> initialization (not load) order. I also remain concerned about i
On Mon, 5 Jul 2021 06:01:23 GMT, Yi Yang wrote:
>> Class loading order is different to class initialization order.
>>
>> There are a lot more tests than just tier1. :) I don't expect many, if any,
>> tests to be looking for a specific IOOBE message, and I can't see an easy
>> way to find such
On Mon, 5 Jul 2021 06:01:23 GMT, Yi Yang wrote:
>> Class loading order is different to class initialization order.
>>
>> There are a lot more tests than just tier1. :) I don't expect many, if any,
>> tests to be looking for a specific IOOBE message, and I can't see an easy
>> way to find such
On Thu, 17 Jun 2021 05:16:14 GMT, David Holmes wrote:
>> After JDK-8265518(#3615), it's possible to replace all variants of
>> checkIndex by
>> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
>> the whole JDK codebase.
>
> Class loading order is different to class ini
On 6/21/2021 2:02 PM, Paul Sandoz wrote:
On Mon, 21 Jun 2021 05:17:09 GMT, Yi Yang wrote:
After JDK-8265518(#3615), it's possible to replace all variants of checkIndex
by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
the whole JDK codebase.
Yi Yang has updated th
> After JDK-8265518(#3615), it's possible to replace all variants of checkIndex
> by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
> the whole JDK codebase.
Yi Yang has updated the pull request incrementally with one additional commit
since the last revision:
test
On Tue, 22 Jun 2021 02:58:28 GMT, Yi Yang wrote:
> I found that after solving the problem that Preconditions cannot be used
> during the VM startup, a series of functions such as
> String.checkIndex/checkOffset/.. can also be harmlessly replaced, but this
> changeset is somewhat large and may
On Tue, 22 Jun 2021 02:39:01 GMT, Yi Yang wrote:
>> After JDK-8265518(#3615), it's possible to replace all variants of
>> checkIndex by
>> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
>> the whole JDK codebase.
>
> Yi Yang has updated the pull request incrementally
> After JDK-8265518(#3615), it's possible to replace all variants of checkIndex
> by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
> the whole JDK codebase.
Yi Yang has updated the pull request incrementally with one additional commit
since the last revision:
corr
On Mon, 21 Jun 2021 20:49:56 GMT, Paul Sandoz wrote:
>> Yi Yang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> more replacement 2
>
> src/java.base/share/classes/jdk/internal/util/Preconditions.java line 78:
>
>> 76: = Prec
On Mon, 21 Jun 2021 05:17:09 GMT, Yi Yang wrote:
>> After JDK-8265518(#3615), it's possible to replace all variants of
>> checkIndex by
>> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
>> the whole JDK codebase.
>
> Yi Yang has updated the pull request incrementally
> After JDK-8265518(#3615), it's possible to replace all variants of checkIndex
> by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
> the whole JDK codebase.
Yi Yang has updated the pull request incrementally with one additional commit
since the last revision:
more
> After JDK-8265518(#3615), it's possible to replace all variants of checkIndex
> by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
> the whole JDK codebase.
Yi Yang has updated the pull request incrementally with one additional commit
since the last revision:
more
> After JDK-8265518(#3615), it's possible to replace all variants of checkIndex
> by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
> the whole JDK codebase.
Yi Yang has updated the pull request incrementally with one additional commit
since the last revision:
form
> After JDK-8265518(#3615), it's possible to replace all variants of checkIndex
> by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
> the whole JDK codebase.
Yi Yang has updated the pull request incrementally with one additional commit
since the last revision:
new
On Fri, 18 Jun 2021 18:03:44 GMT, Paul Sandoz wrote:
>> Yi Yang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> restore IndexOfOufBoundsException; split exception line
>
> src/java.base/share/classes/java/util/Base64.java line 935:
>
>>
On Fri, 18 Jun 2021 05:54:01 GMT, Yi Yang wrote:
>> After JDK-8265518(#3615), it's possible to replace all variants of
>> checkIndex by
>> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
>> the whole JDK codebase.
>
> Yi Yang has updated the pull request incrementally
On Thu, 17 Jun 2021 15:45:47 GMT, Paul Sandoz wrote:
>> src/java.base/share/classes/java/util/Base64.java line 934:
>>
>>> 932: if (closed)
>>> 933: throw new IOException("Stream is closed");
>>> 934: Preconditions.checkFromIndexSize(len, off, b.length, (x
On Fri, 18 Jun 2021 05:54:01 GMT, Yi Yang wrote:
>> After JDK-8265518(#3615), it's possible to replace all variants of
>> checkIndex by
>> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
>> the whole JDK codebase.
>
> Yi Yang has updated the pull request incrementally
On Thu, 17 Jun 2021 10:19:43 GMT, Alan Bateman wrote:
>> Yi Yang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> restore IndexOfOufBoundsException; split exception line
>
> src/java.base/share/classes/java/lang/AbstractStringBuilder.java
> After JDK-8265518(#3615), it's possible to replace all variants of checkIndex
> by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
> the whole JDK codebase.
Yi Yang has updated the pull request incrementally with one additional commit
since the last revision:
rest
On Thu, 17 Jun 2021 10:21:35 GMT, Alan Bateman wrote:
>> After JDK-8265518(#3615), it's possible to replace all variants of
>> checkIndex by
>> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
>> the whole JDK codebase.
>
> src/java.base/share/classes/java/util/Base64.
On 17/06/2021 8:50 pm, Alan Bateman wrote:
On Thu, 17 Jun 2021 05:16:14 GMT, David Holmes wrote:
There are a lot more tests than just tier1. :) I don't expect many, if any,
tests to be looking for a specific IOOBE message, and I can't see an easy way
to find such tests without running them.
On Thu, 17 Jun 2021 05:16:14 GMT, David Holmes wrote:
> There are a lot more tests than just tier1. :) I don't expect many, if any,
> tests to be looking for a specific IOOBE message, and I can't see an easy way
> to find such tests without running them. If core-libs folk are okay with this
>
On Wed, 16 Jun 2021 08:08:47 GMT, Yi Yang wrote:
> After JDK-8265518(#3615), it's possible to replace all variants of checkIndex
> by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
> the whole JDK codebase.
I looked through the changes in java.base and only spotted o
On Wed, 16 Jun 2021 08:08:47 GMT, Yi Yang wrote:
> After JDK-8265518(#3615), it's possible to replace all variants of checkIndex
> by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
> the whole JDK codebase.
Class loading order is different to class initialization ord
On Thu, 17 Jun 2021 01:51:41 GMT, David Holmes wrote:
> I skimmed through all these and the changes seem fine in principal.
> I have two mild concerns:
>
> 1. How does this change the class initialization order on VM startup?
> 2. Do any tests need adjusting due to potential changes in the exact
On Wed, 16 Jun 2021 08:08:47 GMT, Yi Yang wrote:
> After JDK-8265518(#3615), it's possible to replace all variants of checkIndex
> by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
> the whole JDK codebase.
I skimmed through all these and the changes seem fine in pri
After JDK-8265518, it's possible to replace all variants of checkIndex by
Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in the
whole JDK codebase.
-
Commit messages:
- use checkIndex globally
Changes: https://git.openjdk.java.net/jdk/pull/4507/files
Webre
35 matches
Mail list logo