Re: RFR: 8274308: Improve efficiency for HandshakeContext initialization. [v2]

2021-11-09 Thread Clive Verghese
On Sat, 6 Nov 2021 08:54:33 GMT, Daniel Jeliński wrote: >>> Hi @XueleiFan, >>> >>> Thank you for the feedback, though it’s not recommended to set the >>> protocols and cipher suites, various frameworks often do set these values, >>> [Some references below]. Would it still make sense to only op

Re: RFR: 8274308: Improve efficiency for HandshakeContext initialization. [v2]

2021-11-09 Thread Xue-Lei Andrew Fan
On Sat, 6 Nov 2021 08:54:33 GMT, Daniel Jeliński wrote: >>> Hi @XueleiFan, >>> >>> Thank you for the feedback, though it’s not recommended to set the >>> protocols and cipher suites, various frameworks often do set these values, >>> [Some references below]. Would it still make sense to only op

Re: RFR: 8274308: Improve efficiency for HandshakeContext initialization. [v2]

2021-11-09 Thread Clive Verghese
On Sat, 6 Nov 2021 08:54:33 GMT, Daniel Jeliński wrote: >>> Hi @XueleiFan, >>> >>> Thank you for the feedback, though it’s not recommended to set the >>> protocols and cipher suites, various frameworks often do set these values, >>> [Some references below]. Would it still make sense to only op

Re: RFR: 8274308: Improve efficiency for HandshakeContext initialization. [v2]

2021-11-07 Thread Xue-Lei Andrew Fan
On Sat, 6 Nov 2021 08:54:33 GMT, Daniel Jeliński wrote: > Can we extend the public API of `SSLContext` with methods for managing > `activeProtocols`, `activeCipherSuites` and possibly `algorithmConstraints`? > Without this API change we would need to check every time if the active > protocols,

Re: RFR: 8274308: Improve efficiency for HandshakeContext initialization. [v2]

2021-11-06 Thread Daniel Jeliński
On Fri, 5 Nov 2021 22:57:24 GMT, Xue-Lei Andrew Fan wrote: >> src/java.base/share/classes/sun/security/ssl/HandshakeContext.java line 74: >> >>> 72: "sun.security.ssl.allowLegacyHelloMessages", true); >>> 73: >>> 74: static Cache >>> handshakeContextCache; >> >> I thin

Re: RFR: 8274308: Improve efficiency for HandshakeContext initialization. [v2]

2021-11-05 Thread Xue-Lei Andrew Fan
On Sat, 30 Oct 2021 04:57:22 GMT, Xue-Lei Andrew Fan wrote: >> Clive Verghese has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. > > src/java.base/share/classes/su

Re: RFR: 8274308: Improve efficiency for HandshakeContext initialization. [v2]

2021-11-05 Thread Clive Verghese
On Sat, 30 Oct 2021 04:57:22 GMT, Xue-Lei Andrew Fan wrote: >> Clive Verghese has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains three >

Re: RFR: 8274308: Improve efficiency for HandshakeContext initialization. [v2]

2021-10-29 Thread Xue-Lei Andrew Fan
On Fri, 29 Oct 2021 23:58:06 GMT, Clive Verghese wrote: >> Hi, >> >> We have identified that the `HandshakeContext` initialization takes up a >> close to 50% of the flame graph for startHandshake. I have moved the >> computation of the `activeProtocols` and `activeCipherSuites` from the >> Ha

Re: RFR: 8274308: Improve efficiency for HandshakeContext initialization. [v2]

2021-10-29 Thread Clive Verghese
> Hi, > > We have identified that the `HandshakeContext` initialization takes up a > close to 50% of the flame graph for startHandshake. I have moved the > computation of the `activeProtocols` and `activeCipherSuites` from the > HandshakeContext constructor to SSLConfiguration class because the