Hi,
I have pushed this change. Thanks Brad, Alan and Chris for reviews.
Regards, Peter
On 01/06/2015 08:52 PM, Bradford Wetmore wrote:
I only looked at test, looks good to me.
I'd rarely ask to remove extra prints in tests. It adds initial
debugging data points in case something breaks
I only looked at test, looks good to me.
I'd rarely ask to remove extra prints in tests. It adds initial
debugging data points in case something breaks down the road.
Brad
On 1/4/2015 8:25 AM, Peter Levart wrote:
Hi Brad,
So I created another webrev (just removed the unneeded import and
Hi Brad,
So I created another webrev (just removed the unneeded import and
left-over System.out.println from test):
http://cr.openjdk.java.net/~plevart/jdk9-dev/FileInputStreamPool.8047769/webrev.06/
I'll leave it here to rest for a couple of days and if no one objects,
I'll push it to
On 1/1/2015 12:22 PM, Peter Levart wrote:
Hi Brad,
Here's next webrev which tries to cover all your comments:
http://cr.openjdk.java.net/~plevart/jdk9-dev/FileInputStreamPool.8047769/webrev.04/
I downloaded the webrev.05 (Chris' later followup email) and ran it
through JPRT. The only
On 12/29/2014 04:51 PM, Alan Bateman wrote:
On 29/12/2014 09:45, Peter Levart wrote:
Thanks for looking at this, Alan.
You're right about File.getCanonicalFile(). It already checks read
permission for a file. The additional explicit check is superfluous.
I have removed it.
With explicit
This looks very nice Peter.
Just a small comment on the test; it may avoid future problems if the test use
deleteFileWithRetry, from the test library [1], rather than file.delete().
-Chris.
[1]
Hi Brad,
Here's next webrev which tries to cover all your comments:
http://cr.openjdk.java.net/~plevart/jdk9-dev/FileInputStreamPool.8047769/webrev.04/
Answers inline...
On 12/30/2014 02:48 AM, Bradford Wetmore wrote:
I'm looking at this version of the webrev.
On 01/01/2015 08:56 PM, Chris Hegarty wrote:
This looks very nice Peter.
Just a small comment on the test; it may avoid future problems if the
test use deleteFileWithRetry, from the test library [1], rather than
file.delete().
-Chris.
[1]
Just to followup, I've analyzed the whole PIT run. The second one's
call stack is identical to:
JDK-8067344: Adjust
java/lang/invoke/LFCaching/LFGarbageCollectedTest.java for recent
changes in java.lang.invoke
So, really the only problem is the use of Asserts in your test case.
Brad
On 24/12/2014 11:37, Peter Levart wrote:
Hi Brad,
Thanks for looking into this. Here's updated webrev:
http://cr.openjdk.java.net/~plevart/jdk9-dev/FileInputStreamPool.8047769/webrev.02/
This mostly looks good to me too, except the permission checking. As I
read it, getInputStream uses
On 12/29/2014 10:08 AM, Alan Bateman wrote:
On 24/12/2014 11:37, Peter Levart wrote:
Hi Brad,
Thanks for looking into this. Here's updated webrev:
http://cr.openjdk.java.net/~plevart/jdk9-dev/FileInputStreamPool.8047769/webrev.02/
This mostly looks good to me too, except the permission
On 29/12/2014 09:45, Peter Levart wrote:
Thanks for looking at this, Alan.
You're right about File.getCanonicalFile(). It already checks read
permission for a file. The additional explicit check is superfluous. I
have removed it.
With explicit check I wanted the API to behave uniformly
I'm looking at this version of the webrev.
http://cr.openjdk.java.net/~plevart/jdk9-dev/FileInputStreamPool.8047769/webrev.03/
I just assigned 8047769 to you. My username is wetmore, Alan is alanb.
On 12/24/2014 3:37 AM, Peter Levart wrote:
Looks like you have a committer status, will
Hi Brad,
Thanks for looking into this. Here's updated webrev:
http://cr.openjdk.java.net/~plevart/jdk9-dev/FileInputStreamPool.8047769/webrev.02/
...and answers are inline...
On 12/23/2014 02:30 AM, Bradford Wetmore wrote:
Hi Peter,
Looks like you have a committer status, will you be
Hi Peter,
Looks like you have a committer status, will you be pushing this?
On 12/18/2014 5:23 AM, Peter Levart wrote:
Hi,
I propose a patch for the following issue:
https://bugs.openjdk.java.net/browse/JDK-8047769
Here's the webrev:
Hi,
I propose a patch for the following issue:
https://bugs.openjdk.java.net/browse/JDK-8047769
Here's the webrev:
http://cr.openjdk.java.net/~plevart/jdk9-dev/FileInputStreamPool.8047769/webrev.01/
The patch uses a package-private FileInputStreamPool class that caches
open
Peter,
Thanks for looking into this.
I'll in the middle of reviewing your change (and TLR/SplittableRandom
reply), but have several appointments over the next few days.
But did want to respond to:
sun/security/provider/PolicyFile/GrantAllPermToExtWhenNoPolicy.java:
Make sure that when no
17 matches
Mail list logo
